From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.198 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794177594; b=ga3t+QBoykpK3BULTlVl4RPfuvYJ0R8VW8bzOjVKJmMbZVoWc093cgk/cwMVUKziNOKa LeV0+KcPG1t4zu/t6GZru/Z+LbGu3Md5lmdI6x/sngFseopJdiRutcoDMTG6kH0ZWJNVT ngGFnV/vVcqp+Ji074B0XzLF0w+TiMC07jgXxQwmg7BKFwL8QLyNXrB5Hcsvvx3K0avv6 ICefkYrAKgVo89VSc1kmCoEdbuEXmLXdizx20Xy1FxZufZsH0ta+UYfyALFuBTYrw4tPe 4GeaJMbwW69jI9sVPZ3i8p/jsW8HwFHui8//f3UX79Q8ByejGffNZgm4gFmaOMoGVdw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794177594; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=noN8ey05POi7MkRY5IldCk9pju5ZMENfN/kneqqJ3/c=; b=mZYgyyFwX31MtMv9WCJWtn0+jocinJLXMY4NknrnRY05CWZVpG12BgP654yC0qVXNpCa BaquQvZnPXDXDqIREQMHpi3Gt0xdlij1iExIAn69zL8fMubVPBvXPi/ssg5Fqlqa43W45 qYnPof/V1nbXUVCOh9GWpTdWloJJSutaQ6TTLigTrfCOjE2CUGydE12CINltyl0iisDHD YdzZ0zcdNxSH3FfWbXBPttUNtHKcIswAEjf8K1Nd8Ou8HdXl33UCHEnb9jXe0SKvpDZHo elttIrBEApu5fQhPXDTHkiw5LpALPft0jaRg8O0afXi61ZidDlkn+qCl5HwSXGmzs6Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=oRwpm0Ae; arc=none smtp.remote-ip=74.125.82.198 Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 901486082BCE for ; Sun, 8 Nov 2026 22:39:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 901486082BCE Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=oRwpm0Ae Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-33c35f5ca6cso849393eec.1 for ; Sun, 08 Nov 2026 14:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794177593; x=1794782393; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=noN8ey05POi7MkRY5IldCk9pju5ZMENfN/kneqqJ3/c=; b=oRwpm0AeMBeuz+uwk/SScXYdUV9FjfHSkaA+8EymCFnKPpZ+8uBypl9pX7mf1XQMyJ x27Js4Yde77wTsomG4sUPRnlcsAvIiwdHvJ+Bn47KtEz2SeyuOq81ujcpJdauWUbVDcP ex20Sn93Q0DYhXIPHUa/Z1KzEPiiBP6sOuCXFRq8PIb2NbG9h/4aicL+k7EMSHsPhwrk JKJRXF9Kdm3iFAXs121DCGjYsyCtJDEL6ThzN0RyPXZyEPzwCDw8qz6Z5WCGRHsUBw83 DQoRJwyE7usHhHQqGQFr5zu4BDx92KcdfxS3YYxMNav1zOQAW230wXhXo7YiB7kYZ7UK 3Z7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794177593; x=1794782393; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=noN8ey05POi7MkRY5IldCk9pju5ZMENfN/kneqqJ3/c=; b=l+p2BdIShKzSjckIKTAQAaNXQ4CnLUZbvwIoFortUik0htjVxhXkTUnVDKLSnC+VSU Mhnp9g7Ucywegi7tKiqBLf5wvx/tZzsYNh8dpHGxToZzgENTJe4ThwtYRK/JHtJlarXJ nmJYShu/6d++c9fHU8sWEqfP5VHJuvtMPjtNK4v/XezTGcpMhd7ue+AlwRb/WbVpPG49 WCEk9ooH9BGFbgAPYmz1RxCtco6iGTEseAB4vvnfsrOE3XJjNGeOlSV1xACDdqN98Onk PfTbaU8+BW0lMmi+hy3M80Ry2k4FPAeHFq+FKKO0QjaCLk4srIBsiEkLsKusg46rOJz8 JwRQ== X-Forwarded-Encrypted: i=1; AL+hErFnXugjakGrDnr3Ln9Jw6ZIcVofLTpLxb7gC94dOuHALrFymyY3hrAFBE1j2E2hIGH3f68uda889Alydg==@lists.linux.dev X-Gm-Message-State: APuU4Z9uMXs3UstsqmmB/f3MEmdZM7pQWn50ceXuy4y94RqVZY2rv0z9 xFo0S5iwcDlxQsUDMUeDOg9O+tiouQ377W4qg8LPWNPGSgiQ3VDXW3CTuqVp7AMvOSyJuaaEn6B X8UxD6UNuSQ== X-Received: from dlam9-n1.prod.google.com ([2002:a05:701b:2089:10b0:195:beb6:14cc]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:28b:10b0:1b0:430d:d81c with SMTP id a92af1059eb24-1b39feab6a4mr3897188c88.25.1794177592505; Sun, 08 Nov 2026 14:39:52 -0800 (PST) Date: Sun, 8 Nov 2026 14:39:10 -0800 In-Reply-To: <20261108223913.3624571-1-irogers@google.com> X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261108223913.3624571-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261108223913.3624571-7-irogers@google.com> Subject: [PATCH v3 6/9] xen/sys-hypervisor: Add release callback to hyp_sysfs_kobj_type From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Srish Srinivasan , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" hypervisor_init() in drivers/base/hypervisor.c creates hypervisor_kobj with kobject_create_and_add() (which allocates a dynamic kobject using dynamic_kobj_ktype), and hypervisor_subsys_init() in drivers/xen/sys-hypervisor.c then overwrites hypervisor_kobj->ktype with &hyp_sysfs_kobj_type, which had no .release callback. Add hyp_sysfs_release() calling kfree(kobj) to preserve the dynamic kobject release behavior. Fixes: cff7e81b3dd7 ("xen: add /sys/hypervisor support") Signed-off-by: Ian Rogers --- drivers/xen/sys-hypervisor.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c index 91923242a5ae..0e8a2cd69fd6 100644 --- a/drivers/xen/sys-hypervisor.c +++ b/drivers/xen/sys-hypervisor.c @@ -659,7 +659,13 @@ static const struct sysfs_ops hyp_sysfs_ops = { .store = hyp_sysfs_store, }; +static void hyp_sysfs_release(struct kobject *kobj) +{ + kfree(kobj); +} + static const struct kobj_type hyp_sysfs_kobj_type = { + .release = hyp_sysfs_release, .sysfs_ops = &hyp_sysfs_ops, }; -- 2.56.0.455.g6c5a503b38-goog