From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.197 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794177596; b=sn/J92oMbeMrh0A6TzI1VAPvg6TrF8mOFZPolAMKcstevsGy3dKB5MBMc6EoQjaarCpI Ru/zUJbakN0rdK857nOUchlQlSKcZJKaXbupNGqBQaYeGzAmuK10HIgbj1SXoSnYQseeF 7gdwZ+7yvhY1qwikmdKDHmvcnFLm3uYKoK8sPnSRnedOLnuUzQDF4fRUVl+npD4vA27tW lkh+X1SDWckE9aUjJd9El6yqr0ml83V1hwD90ZwKsnnCiu4Ul4bozdqTTP2UXePMXy2z+ RnJmIkCGJacuC8stS3BA8VYaECRi7PQuTJh8SJLX3mKipvnJP1FpcVDHHkwu2SLPG2w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794177596; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=Vy7610mZpT38CbXCq7RNEhhWWcPldBtQplNazUNUwLE=; b=En5JRc7sNNgehnMMFQhr/IkZgB30Q88fzKCv9MDWxgY1bhx47A6dmP0LNDsYuL1eqBOA i1/L0GO46A9lbncXNWB8RG5fiINhRQbbPOKD1HcWw5X4Y93yww4gPKzor9f3qDz42WuyM rDrUeUfezgSrAHIpA4LrBrCl5NIZ5mR8ndnuUEReS33pc+h6YXQAPJylXvGvnYllRq0Yu vf4XX62lv4EdcuflDE5bbyBAR/7Jkxtnpkr5YmNNawDD/NwZyV85xsI//9+uF7BEfOh6j ubRqJ1fKumk6AgfyyHPRk0MaNpXlCbLNR/BX+9p6SFW2Z2reUbd377OwGtSm3FZVB/g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=WcUoK9yY; arc=none smtp.remote-ip=74.125.82.197 Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 973EF6082BEC for ; Sun, 8 Nov 2026 22:39:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 973EF6082BEC Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=WcUoK9yY Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-36efb506f29so200266eec.1 for ; Sun, 08 Nov 2026 14:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794177595; x=1794782395; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Vy7610mZpT38CbXCq7RNEhhWWcPldBtQplNazUNUwLE=; b=WcUoK9yYKh+DDiSpxOb7MYsgQe/XcbUoawTIQfsAHz4OApFQdLOSkvBZ2M+nPrSLP8 MyvEBrPCjeyD3wt0Rjw1R5jUtGwevIFLIIHehk94nzVj4TgECcga4X4DKYuIpNUzl+wx iNOL6G8fs29K2M8rywDO4AZahUl6ft3si9Dp64qpYOt7xOfKJbionm3lwLkkMHXOsJse ypQLDaY+bgvulwXsGvp7/UTmE+vn2UdBOSgArlvJnEcyJo0ytB86Y5gIr1easn/vqIZs xmmEmFU9gw4V4SpvdZvpkhRXcZCNdNJ1QmUURkRwydtykeOfcoU+rt3i7iZbUfkngY77 yu6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794177595; x=1794782395; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Vy7610mZpT38CbXCq7RNEhhWWcPldBtQplNazUNUwLE=; b=1P/jj032sNRuNb/rJwBHuxjVSF8QLceeli7BLI7HgU5cr3VTpCiU6lt20/5oXOX6LT pQU06WYYeG3QgeMQhip2D12Dhrr3vnqLp3rbBndM3TRHW21g7HF3zdSsy2+sbPX4j+0i bi5EfO+ywvRzrnRsNKn39+2dlB2CdOZHf9PP8035x1oRiDOOlhGmvhJfilkgRpJ4EstQ j2U2BtwFgRk774EjBIUE6Iu6owINcHJjjHNDX1Unh7lkzh4AP9+CCjz9jJ05FlTwfaKJ ZNd/6DCgv4ZQImfyQCvtBdW/qh0ANBuvJqNGUQ1XXZaZDn/QFjsoAMq9h8205UK14HrX DOKg== X-Forwarded-Encrypted: i=1; AL+hErGWYHxGIKEKZxW3aLyXNxpW76cacZGUYLnJGY5RIYjBPBp9mLOR/XWPqlXfAvIdDt50vlWtr9SgtrR6lg==@lists.linux.dev X-Gm-Message-State: APuU4Z+r89494wB0Sa4aV0NnfrmR1Fmaz65gqrwlvC8OkUjRsvn+h3XN ew69VIuj5fBgNagVGWA/v8Up7l2gcJgN25b2zdj1FZnsg5BfcTZUyIwCGb1AmRRsYgLIEQJ+2E3 AZYHDi102yA== X-Received: from dyblf39.prod.google.com ([2002:a05:7301:a27:b0:373:6c70:7c9c]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:d584:b0:36c:9f1a:30b8 with SMTP id 5a478bee46e88-3725661520amr5331882eec.31.1794177594363; Sun, 08 Nov 2026 14:39:54 -0800 (PST) Date: Sun, 8 Nov 2026 14:39:11 -0800 In-Reply-To: <20261108223913.3624571-1-irogers@google.com> X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261108223913.3624571-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261108223913.3624571-8-irogers@google.com> Subject: [PATCH v3 7/9] ubifs: sysfs: Use kset_create_and_add() for ubifs_kset From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Srish Srinivasan , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" ubifs_kset was a static struct kset using a custom ubifs_ktype that had no default_groups and no .release callback. With CONFIG_DEBUG_KOBJECT_RELEASE=y, unloading the ubifs module while delayed kobject release is pending causes a use-after-free on the static kset. Replace the static ubifs_kset and empty ubifs_ktype with a dynamically allocated kset via kset_create_and_add(). Fixes: 203a55f04f66 ("ubifs: Fix memory leak in ubifs_sysfs_init()") Tested-by: Zhihao Cheng Reviewed-by: Zhihao Cheng Signed-off-by: Ian Rogers --- fs/ubifs/sysfs.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/fs/ubifs/sysfs.c b/fs/ubifs/sysfs.c index dbf967dcf26e..e20931e3a62f 100644 --- a/fs/ubifs/sysfs.c +++ b/fs/ubifs/sysfs.c @@ -80,13 +80,7 @@ static const struct kobj_type ubifs_sb_ktype = { .release = ubifs_sb_release, }; -static const struct kobj_type ubifs_ktype = { - .sysfs_ops = &ubifs_attr_ops, -}; - -static struct kset ubifs_kset = { - .kobj = {.ktype = &ubifs_ktype}, -}; +static struct kset *ubifs_kset; int ubifs_sysfs_register(struct ubifs_info *c) { @@ -107,7 +101,7 @@ int ubifs_sysfs_register(struct ubifs_info *c) goto out_free; } - c->kobj.kset = &ubifs_kset; + c->kobj.kset = ubifs_kset; init_completion(&c->kobj_unregister); ret = kobject_init_and_add(&c->kobj, &ubifs_sb_ktype, NULL, @@ -139,18 +133,14 @@ void ubifs_sysfs_unregister(struct ubifs_info *c) int __init ubifs_sysfs_init(void) { - int ret; + ubifs_kset = kset_create_and_add("ubifs", NULL, fs_kobj); + if (!ubifs_kset) + return -ENOMEM; - kobject_set_name(&ubifs_kset.kobj, "ubifs"); - ubifs_kset.kobj.parent = fs_kobj; - ret = kset_register(&ubifs_kset); - if (ret) - kset_put(&ubifs_kset); - - return ret; + return 0; } void ubifs_sysfs_exit(void) { - kset_unregister(&ubifs_kset); + kset_unregister(ubifs_kset); } -- 2.56.0.455.g6c5a503b38-goog