From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.71 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795097580; b=TONRiKu6d2VNLZ2rh9F5MuCuggjBPob6KnFVbctPdVPR7FcOX0xOH55q+z7G5YX+zYV0 um74y2HbzYGLB9/w0rsPeAvRfrsCVw5+6B9w/nSk6sB4lq96xzMCGoPKJHW6cLZZ5JwX0 Re10dQ9GiXXegNuaZYhNaWleE5KyjHK0iVc011hvLTexVU5iXsQjNlcnmiWdf/bouqYOR qutxdImYywJ0N+7pfn/DvvLbPjl/9adb4Ga4smHp+7rFiiOGPtO7isfppsS3jzqKotlpW SeE2jbrhEvRJqjQpyI1tr899daTfDer8yNPbG8SDQPXdTvWaffIUwoiMN7yBJ3yOwdg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795097580; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Developer-Key:X-Developer-Signature: X-Mailer:Message-ID:Subject:From:To:Cc:Content-Type; bh=h4XtWA1ZlEFtabMN7MuXGTzxwKlfoTdqYE31n0Pgw94=; b=toHkPe3zSPdZOoUHIwCUKqfEih2QOm//GELBLnyMWPhENfVctddwNjCICEzyKzfELiwN nfS8P0OIgZ9X1VOvhQSRTurcGBIv1SmBZg9hK7nAOnehmN4Zwg1akV2kXBJvME0asciir d+wrQN3DrQvwg51Qd4VFeu8hSXef3Y81i4W5MyY3Xm35RMVtCWfE6jbYY/rRdoui8r+Yq Yvi9rdXiq0e9HMgDn2zEj40AY9Ywb4plR2/PRWLhJKLrJdIGG9wt/ZdGQVaUiKleO5Ine KfcRyt5WO9GVU1dpWHLmqoLyFL/0B0+cBC9bHHeH8URija44z9GKTZ5T/If+iVJcPSQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=GHA7ePEY; arc=none smtp.remote-ip=209.85.221.71 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F7B9606A33B for ; Thu, 19 Nov 2026 14:13:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2F7B9606A33B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=GHA7ePEY Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4a647e776b4so1770322f8f.1 for ; Thu, 19 Nov 2026 06:12:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795097578; x=1795702378; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=h4XtWA1ZlEFtabMN7MuXGTzxwKlfoTdqYE31n0Pgw94=; b=GHA7ePEY+Zs8bbQxMGaSMhpVPPkfbopK9JdKtT9bUxRvJe6OU27J/4qos0z1yJik49 NZFBH6o7+rhFiHqce9eQ7/epCkmnnUmLL3YSGVVJ+C5XB8Q+wng3jH6eQsYdjPBZi3kV ntar+iRw/pZ9RIyjnK0wHosP3sBl+K/q7OyK0IayPGo85gjkZMolfp9COXK+ur1wqbxU 4KSjYP3GR8QcFsUU6X3u88JGByLupXUGdcIGC7Vb3iVfg70TlQDLWtDnwsFYEZoSkL8l xP6FexL+IE6B4ty9qC5qMItXgryvB95KbFzXRYA6Dq0D9USdp3/8cunLuGVHZMq2Ac4J f7Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795097578; x=1795702378; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=h4XtWA1ZlEFtabMN7MuXGTzxwKlfoTdqYE31n0Pgw94=; b=oJvaW52PS1zvoAeNEQdfZ6pI+BIkc+xdxVKJKuVQahFQsQVbEWH6W7nwVVTNnMp/MD cK8KFJT7PT4VH0Lzw37YhXrGcjIwCA+m2M3RLc7Da7NYJcMO9fYEr34KxYUO+sczfgAU 5qgqYXRYtF8B4kZS83+R7qwCufKDwmy6PBxSnVnoROj+yruAXBjx/7wiQXqrA3/2XMO+ MZsma7hyTd2+HURy0QJJDaNajKzueqkF2qniumXTMFdK3CgEJug8TFfRbAph0wH4tl98 eWyIjPwIbYoCEXqZRu47qmj6Rrp1dBXzM4u7+7tu5caSGYv8lqzPxEIHmfvRJwKtqzKe SLRQ== X-Forwarded-Encrypted: i=1; AL+hErF0RpJgF6StmChOTdiorfuilt3pxwws7D8rKF1xTH1qPj8s51R2EPl6BDZpWiw8mQejH9EV26KEgXi+vA==@lists.linux.dev X-Gm-Message-State: APuU4Z+PV2NhVNUkxhAXa6MoOzTtr4iBbN1HhnjD+C9jyKhFEBZSaLGB vuqdpQGf5dz2qJ/VlgUrNcBjlQ2wMGSs34wU9VjPK13PRKghjgrYH75lqWIjMPbNrJwJ80ELit8 UG7qBnZYTQOZCao3uUQ== X-Received: from wroc4.prod.google.com ([2002:adf:ed84:0:b0:4a3:2cb4:4f6a]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2602:b0:48e:824:f0b9 with SMTP id ffacd0b85a97d-4a63ae5678fmr11825158f8f.45.1795097578307; Thu, 19 Nov 2026 06:12:58 -0800 (PST) Date: Thu, 19 Nov 2026 14:12:43 +0000 In-Reply-To: <20261119-rust-workqueue-v4-0-707c68994940@google.com> X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261119-rust-workqueue-v4-0-707c68994940@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1874; i=aliceryhl@google.com; h=from:subject:message-id; bh=5sQiayq21AJaQOqbklWWBdtbINqEna/wJifMJMxolCI=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBq/wPjTLxLRE6bF8To20FERIvaafMs+3+IlhPd9 VF/U38MG1mJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCav8D4wAKCRAEWL7uWMY5 RqWrD/9saTvcm0dmVaK6ZU6wMav3kkCa8+lP25N7dtJPuKanuA8Z+vpFUw2cmuir67lB089fACL maBtektbUuhdKLtwyN1t+KQlERluM/9OL7C3M47uzuevqBg0IObtB7MpUBXpYzO0EdsVUwH0vlm 8M78WlElwh0vjDLil0VID04Mif/W47fXKczY22Wi6XptBS0VE2Fg3dhzvGJ8O45s1v4e89DtOSJ zLzjPIw30AHbGP0YGflcjDoT1qhRjpx6jgV/r2AlLZt+29YdPe/JGON1DO793nknP9fdsGlrzB2 hLg5jvgvirAttTeS4RlecETf+LbmhwuECmoV9HM23tArEA70h4fypQa8Ivas7a2KOwzrDLQgEMn PBDGIXKPTSHGYz5JI0Uy8YnUDZfR05t+hfeX7PD3lAtrxxVngwWSbilRl5keJEHdFQVNE2vkXoO sZAN6ZCd9p8Y57gVOcdDsItZZXCNW2kvFF4TV2UkZE9oX5ykwilAFMTcOjOQNiws+HC+xKgnZeo VwYLm1QThwHzk1TXq9B0zLQlopICV+i0iOIyY9kZui/9Rm5QqUu0pSkuzhF7wp/nHfLUmJC4YAH csOFHqyicA5dNtRAOInOoQ5E1v9EQxh/PwLX10x2Ao1WIGBjZoye8mPJZwtuttOSQuqd/y+9W4q ah0e6zGJ5zyUPBA== X-Mailer: b4 0.14.3 Message-ID: <20261119-rust-workqueue-v4-2-707c68994940@google.com> Subject: [PATCH v4 2/5] rust: workqueue: restrict delayed work to global wqs From: Alice Ryhl To: Tejun Heo , Lai Jiangshan , Danilo Krummrich Cc: Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , "=?utf-8?q?Onur_=C3=96zkan?=" , John Hubbard , Philipp Stanner , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, Alice Ryhl , stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" When a workqueue is shut down, delayed work that is pending but not scheduled does not get properly cleaned up, so it's not safe to use `enqueue_delayed` on a workqueue that might be destroyed. To fix this, restricted `enqueue_delayed` to static queues. This may be fixed in the future by an approach along the lines of [1]. Cc: stable@vger.kernel.org Fixes: 7c098cd5eaae ("workqueue: rust: add delayed work items") Reviewed-by: John Hubbard Reviewed-by: Danilo Krummrich Reviewed-by: Gary Guo Reviewed-by: Andreas Hindborg Reviewed-by: Daniel Almeida Link: https://lore.kernel.org/r/20250423-destroy-workqueue-flush-v1-1-3d74820780a5@google.com [1] Signed-off-by: Alice Ryhl --- rust/kernel/workqueue.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/rust/kernel/workqueue.rs b/rust/kernel/workqueue.rs index 6eb6c40138f2..5ef807ed6a33 100644 --- a/rust/kernel/workqueue.rs +++ b/rust/kernel/workqueue.rs @@ -302,8 +302,15 @@ pub fn enqueue(&self, w: W) -> W::EnqueueOutput /// /// This may fail if the work item is already enqueued in a workqueue. /// + /// This is only valid for global workqueues (with static lifetimes) because those are the only + /// ones that outlive all possible delayed work items. + /// /// The work item will be submitted using `WORK_CPU_UNBOUND`. - pub fn enqueue_delayed(&self, w: W, delay: Jiffies) -> W::EnqueueOutput + pub fn enqueue_delayed( + &'static self, + w: W, + delay: Jiffies, + ) -> W::EnqueueOutput where W: RawDelayedWorkItem + Send + 'static, { -- 2.56.1.708.g77570a6a1d-goog