From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84DFA5349D7 for ; Wed, 23 Sep 2026 13:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790171150; cv=none; b=rwOylBUozajzMiIq8WsMWdcuBTLVuOJrk4SzG/+yL6V12WTtA79rl2R+WsggtxRQWI7Bp8E1slnYd22JAlzFOFwjWh01+Mvo/jzFDwoMvk4e5v7X8GxZsLfqwwUepSy+nswzTd7yEiZ2dWdzRrFNpvQNCj25dXB0wNOY8RGf7VQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790171150; c=relaxed/simple; bh=hAUIAJP2KyIPOrXkm/QtyPmhhjrZyPRauTKH3tyreRE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BkMzRWsUr5TLJxAmM4kapmPLEf7WuNi/usuGmaSSe3HpVKlzlRoN35f1P59El/8K3NYmeF21nLDjJWE8+GiuR2B4BLtPJlSlasTrY2gule7gwgwiVYE3dV3vciDRjhyWpF+11LTjI7fPP1du7qByAbS/fd7WEkSoI9hFVYMgRfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NHhZfGyt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gAg/X4Lt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NHhZfGyt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gAg/X4Lt" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NBbY0p3028025 for ; Wed, 23 Sep 2026 13:45:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bvAW3yceqnT6AttFLk4NW8DsgIwVtqPiNNE7x4zTQZg=; b=NHhZfGytzmWFyCsj Zbq1+A+FQqTZC64KnzfYTjTVPG4qQ2PppdfaDev7x8JA0PLgl8xEusRGtaUk2Jnu dktSsj6AkBdohfO4tO1sewfq6TnnSSJAfWsSJiulrAuLH1YzPMPiVH1eN1YzL+gr rXl5tjJO3b9ESRI7PcAkNumaqBIipyJqWDIi7+ikcMskQZRd0A3wRk2DfxasF1it 2mcq9TNtRWWuNicMFsLObGoyuSiP7WGMx9NrG7MnL3ooMu+9W0VVVhVHfTo5swQf RGt6T1OymuOg3EfZA02+riv6lxDfUWyRTWk+mzOgJ+2ZyLA7Gl/eBGkdBvnXp9gg Mxdl+Q== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvbwas3sq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 23 Sep 2026 13:45:47 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-7a760965865so70618137.3 for ; Wed, 23 Sep 2026 06:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790171146; x=1790775946; darn=lists.linux.dev; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bvAW3yceqnT6AttFLk4NW8DsgIwVtqPiNNE7x4zTQZg=; b=gAg/X4LtWQSSwkdCZanQXrp6WWWxRDYOl9sEVtEmS17VL/LELEm6HKDknza6IGq/GB uBDpQuDVwl4R1qCdGmmJ7XN/ETbiq/b1bhsmrtqQcaQ4A1yqugamv3gloPoe0c1a8Syg 5S8YVRYJf3hMtYzBHJ/Sb2cJOyLKzGPuzCNSyeE9/mbH0CvHtQWVk7ruH+E2xqFzP+kV 9pLA9R7O//6PT6sdZ1le+dMpy7clBUvNV0yleaELTRMBKB2k6mirTHEdLU0+M/YurqQ5 hIGCH6eequ6YUp1+d9XOzGKBepijk6TYMRO3Tyc8cVJxH84/n4joO/UNNtqcAhIRO0ne bipQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790171146; x=1790775946; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bvAW3yceqnT6AttFLk4NW8DsgIwVtqPiNNE7x4zTQZg=; b=UUX7KEXy06+nXKIvRneuW3enJD90e5lapIogRf2URL4/dZ18K9BphxhUb6GU+qLSsq XF3NYxqYPJwmcfS9o8hKLr2XbznzQt8Mo50fM0t0TTxo1aolCcbQtLOQ9TskydG7M9ki 41DGjfKD8IOgdNK2GY9kJ/6tWQ2QyEx1+MTLWTEypduy9wFhQtZwxseTHYrCResvazQo OORW3aX2BHHI+p1nelx+jxsd6dgFrOIC63hANyYovdr7bFQR/jt07lq51c/UOpbl544G NKi0uCXIVOb317Azj0CzTN4W+1eJaZ8ExOqA8oEsGtttKX8B5wqzuTqTiUtfMEiZ+W6Q 9Ntg== X-Forwarded-Encrypted: i=1; AKwUvBw1Ub/MIbNG4BlabgPomNYLEPFXHKEBSdHcfpzWRGAw1XiwaZN1D2s8r6GpDW+UpC+EOAX4V5ePn3uRtQ==@lists.linux.dev X-Gm-Message-State: AFuF++nF7yemczac8jqhGQPdq9gMMugrsbeRfju3NaObBkRscpR2j++l TqFE7/FQKV8LwuHBZ7PHnAvAh3uZPdYMjFq8rHhYqKRvxM8ZhHfPVW8x9Qjtudtjxc+HHjsvOIa 56RpMF2G6/71naRrKSZQb/T+cuw/NfwRcU9N4rgn/Rrg3xcrlOEtt9p+HVYFXIx4IWg== X-Gm-Gg: AYBFou0PsaVip09jiAE4sjSvEo3k0LMTNTcdkKI7YhsweM0DD6va5wYPHQhog1mIC34 fYOvgjiMHPVzRJDnJl1Mb77F3BLd3Sg9s5vSHMQBie/u/JpxqiK96ithlaweiaj82njm0rPa0Tz 0XlZPdK9v6LXxE4GwYeu3veOlvaMzaItfZQo238CDqjCfb1hkBZZTEUPJ3D46glqIK0wLFHnEcy g4sVl7cuXyuE5YcCIaFv0eqnzImzITQPRK7YW5hMDmAojqRcCclTVVxCOyyBlJ7a/viP3UUN7rs 3LZLn4ToZ6ekAeygkws0wuMTKh0zkKhqo0/K/7wDzCuQkZEY1wcIgsieblJEpKQxAS1MLKJapL8 HQBT1zkZ7LWIRh7U3XY5kJA== X-Received: by 2002:a05:6102:5121:b0:7a7:326b:688d with SMTP id ada2fe7eead31-7ac1c454b57mr2548263137.2.1790171146492; Wed, 23 Sep 2026 06:45:46 -0700 (PDT) X-Received: by 2002:a05:6102:5121:b0:7a7:326b:688d with SMTP id ada2fe7eead31-7ac1c454b57mr2548220137.2.1790171145961; Wed, 23 Sep 2026 06:45:45 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6aab37478c9sm1722267a12.0.2026.09.23.06.45.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2026 06:45:44 -0700 (PDT) Message-ID: <32bceb7e-d06b-4537-9d34-91bfe27f4ff7@oss.qualcomm.com> Date: Wed, 23 Sep 2026 15:45:40 +0200 Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 06/16] usb: hub: Associate port@ fwnode with USB port device To: wens@kernel.org Cc: Chen-Yu Tsai , Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski References: <20260721065413.2306137-1-wenst@chromium.org> <20260721065413.2306137-7-wenst@chromium.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA1NCBTYWx0ZWRfX636z3xMb7kGM dmv62sdGdB9V5oJUTKs1Nd29av5JNyvIbFsepx0oXRSKe3p+iVqfNQ5qWn4EGa++p0vpKBZSb1I svAi0YXzd2bMR2dfAf8nPou3/0S0oUAi3HrKVsolycebmWZ5AA/oPdxbW2V9BN/9wxTU0R5oiJ+ dLxjtgmvMmZEg5xixsvjK10lKe5tcfzU95ctGGFTzgFzVgqRo5/Gf49A55ie1+11+i5y0BotCbo iupVZQn/PY0fHjVnN7tD6EgDT2yJGxiwn7Gx5CY96fgUl2KSCWAQyQIlWNvJ/sQTzApiEZs+v13 1tkS3Dhb3VdkZbffqJoxGjhUzKeNhTrC/Xyt3F4k7pdBhLVPzxydBmBQCC8l/9GYWnJPR8kwsY5 f0e2X4i9xUCNnVclTKt+OdeabgnQvvyrLawMYNBWV2d5w4nfvKscSyldx3fMP7ZJ1r48MOMF9eG 80sEmaNqGxJPiSuuTrg== X-Authority-Analysis: v=2.4 cv=HfuB3SE8 c=1 sm=1 tr=0 ts=6ab3d80b cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=M7ONEjnSaIfHBpTaVFwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-GUID: 3MHrJ4avI5RZtZlhF476LA3ZVOhi2IPF X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA1NCBTYWx0ZWRfX4Y/Ybh70r4IG 9hr5hajtchzgcmbpYrQZETcWJaEBx22opUovaG5f4DobhnpRkrA6fb4gFRX77OOWF8D6Ihu+vug +juTH+mbT1iPOLfQKfu8C2Qqu/H+jZc= X-Proofpoint-ORIG-GUID: 3MHrJ4avI5RZtZlhF476LA3ZVOhi2IPF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230054 On 9/4/26 12:30 PM, Chen-Yu Tsai wrote: > (dug this out of my kernel.org email) > > On Fri, Jul 31, 2026 at 10:44 PM Konrad Dybcio > wrote: >> >> On 7/21/26 8:54 AM, Chen-Yu Tsai wrote: >>> When a USB hub port is connected to a connector in a firmware node >>> graph, the port itself has a node in the graph. [...] >> But something I faced when I was poking at USB4 was that dt-bindings >> currently assume every controller is effectively single-port and the >> of_graph ports under it represent HS/SS lanes, i.e. the entire >> "ports" subnode represents a single USB port > > Which controller is this? AFAIK for xHCI hosts there currently is no > "ports" node specified in the common usb-hcd.yaml binding. I plan to > add this separately, as it can already be used for USB A connectors. DWC3, the qcom flavor specifically (qcom,snps-dwc3) > The kernel maps every downstream port of the root hub to a separate > node. On the XHCI it is more complicated because it has two root hubs, > one for HS and one for SS. I'm not familiar with the hardware specifics > but they seem to map into one common namespace, so you probably get > ports 1~8 for HS and then 9~12 for SS. Note the number of ports is > different. This is just an example from my x86 workstation. And on > x86 each port is mapped to a different ACPI node. > >> I think the solution here would be to do ports {} under the controller >> and have every one of them have 2 endpoints (for HS and SS >> respectively) - then, each DT-port would correspond to a USB port >> (sorta like in the hub case, minus the hubs are split for HS/SS so >> they have just a single endpoint under each port) > > But the hardware descriptors actually give two ports, one for HS and one > for SS. And in the case of dwc3, I suspect that they always come with > one downstream HS port and (optionally) one downstream SS port. So the > binding is actually correct, except for the numbering. Ohh yeah I overlooked the HS/SS port split.. I think you're right! > I'm looking into the dwc3 case. Changing the numbering might actually > not break anything. Linux seems to just need one *a* graph connection, > but doesn't care about the number. I looked through some other projects: > > - FreeBSD doesn't use the OF graph for anything > - U-boot doesn't use the OF graph for USB > - OpenBSD doesn't support dwc3, only the XHCI in dwc3, and doesn't use the > OF graph for USB > - coreboot doesn't use the OF graph for anything > - Zephyr doesn't support dwc3 > - TF-A doesn't use the OF graph for anything > - EDK2 doesn't support dwc3 and doesn't support OF graph > - OP-TEE doesn't support dwc3 and doesn't support OF graph > >> But that comes with a big breakage, as always.. > > As I mentioned, it probably isn't as large of a breakage. That's very welcome for a change! Thanks for checking all of them. Konrad