From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A10C3D6CD6; Fri, 29 May 2026 12:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780057468; cv=none; b=qRDTCfSynMZkg4NdHOiqSfG1XEHtDx8GpVwvauPqMnDVHky1gHHEbHzaoEIMaZst3hYBR9xq0RIVt2LVHocWEZWUfy1htgxX3+6/WPRouVH+cr7N08DXtYtzNBZUvvZVUyAHx3Ymxgtgvkyxfp+F76U+F04BrPJ8Bq/Mq8TK0m4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780057468; c=relaxed/simple; bh=fjbO4t8XdyU8NOb41mG4ChhG+m/bzPP3BywWNtdYqoA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=btjAgdJXyV/tFlF5kTRjcBnxVl8x2i0VKcfxQZncA2vlEIfD5E53s4OM9OZNzuATqLSHgY9RahokqelZKunFJL8YabHf+a2gW9dmCvoYttxsJAt4FmZtE1w+LLiy4DrY8OCTn4ghCLSwjB0hnO3fuAvZptwOp+kvWzK18bw3CFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=aPrsjUKC; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="aPrsjUKC" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45FEC204C; Fri, 29 May 2026 05:24:20 -0700 (PDT) Received: from [10.57.37.50] (unknown [10.57.37.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16BE13F632; Fri, 29 May 2026 05:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1780057465; bh=fjbO4t8XdyU8NOb41mG4ChhG+m/bzPP3BywWNtdYqoA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aPrsjUKCk50s149VeWZk4F2Llmjdo90qP4DWtdM9ATKguxbUU6gRebVq07f2uJFK0 YVnIN2oOqMRDRFm11YWBgDWM/xTptKipB8Q9REDRnovKPHG2ooZaALp7Zti/C2KUQ+ b4qPfWs6v4eF/TgyfabaRYMbwAxOu8OUsO69761s= Message-ID: <3a4e22fe-b8ce-4e62-9139-113e0cd4f16b@arm.com> Date: Fri, 29 May 2026 13:24:02 +0100 Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/16] psci: simplify hotplug_tests() To: Yury Norov , Andrew Morton , Rasmus Villemoes Cc: Russell King , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Thomas Gleixner , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Danilo Krummrich , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Heiko Stuebner , Lorenzo Pieralisi , Xu Yilun , Tom Rix , Moritz Fischer , Yicong Yang , Jonathan Cameron , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Bjorn Helgaas , Shuai Xue , Will Deacon , Jiucheng Xu , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jing Zhang , Xu Yang , Linu Cherian , Gowthami Thiagarajan , Ji Sheng Teoh , Khuong Dinh , Daniel Lezcano , Zhang Rui , Lukasz Luba , Yury Norov , Kees Cook , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Aboorva Devarajan , "Ritesh Harjani (IBM)" , Ilkka Koskinen , Besar Wicaksono , Ma Ke , Chengwen Feng , linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-perf-users@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-fpga@vger.kernel.org, linux-rdma@vger.kernel.org, nvdimm@lists.linux.dev, linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-cxl@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260528183625.870813-1-ynorov@nvidia.com> <20260528183625.870813-2-ynorov@nvidia.com> From: Robin Murphy Content-Language: en-GB In-Reply-To: <20260528183625.870813-2-ynorov@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-05-28 7:36 pm, Yury Norov wrote: > Switch to pr_info("... %pbl"), and drop the temporary buffer allocation. I would say this is simply an improvement in its own right, regardless of whether cpumap_print_to_pagebuf() deserves to be removed or not. For the change itself, FWIW, Reviewed-by: Robin Murphy > This prepares for removing cpumap_print_to_pagebuf(). > > Signed-off-by: Yury Norov > --- > drivers/firmware/psci/psci_checker.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c > index e67ba9891082..ecd745bb90bf 100644 > --- a/drivers/firmware/psci/psci_checker.c > +++ b/drivers/firmware/psci/psci_checker.c > @@ -186,7 +186,6 @@ static int hotplug_tests(void) > { > int i, nb_cpu_group, err = -ENOMEM; > cpumask_var_t offlined_cpus, *cpu_groups; > - char *page_buf; > > if (!alloc_cpumask_var(&offlined_cpus, GFP_KERNEL)) > return err; > @@ -194,10 +193,6 @@ static int hotplug_tests(void) > nb_cpu_group = alloc_init_cpu_groups(&cpu_groups); > if (nb_cpu_group < 0) > goto out_free_cpus; > - page_buf = (char *)__get_free_page(GFP_KERNEL); > - if (!page_buf) > - goto out_free_cpu_groups; > - > /* > * Of course the last CPU cannot be powered down and cpu_down() should > * refuse doing that. > @@ -210,16 +205,11 @@ static int hotplug_tests(void) > * off, the cpu group itself should shut down. > */ > for (i = 0; i < nb_cpu_group; ++i) { > - ssize_t len = cpumap_print_to_pagebuf(true, page_buf, > - cpu_groups[i]); > - /* Remove trailing newline. */ > - page_buf[len - 1] = '\0'; > - pr_info("Trying to turn off and on again group %d (CPUs %s)\n", > - i, page_buf); > + pr_info("Trying to turn off and on again group %d (CPUs %*pbl)\n", > + i, cpumask_pr_args(cpu_groups[i])); > err += down_and_up_cpus(cpu_groups[i], offlined_cpus); > } > > - free_page((unsigned long)page_buf); > out_free_cpu_groups: > free_cpu_groups(nb_cpu_group, &cpu_groups); > out_free_cpus: