From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A068402429 for ; Thu, 9 Jul 2026 09:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783590598; cv=none; b=i16B1jxRQkr7EY9bOiJtFx5IIZEddNnw+JoJD1mxNf3nNEeV3nzYmEhyQr1cUMn3+of7JkyZhtHBkmmRjYMzTv7jj+LrbBApmAsklq1ip5oj1IpDJu0GHsw0cCCdE/KjYcs0EuXhHF2Bs8yJURGWGigcVKrtaP2EuDMX88Sv+1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783590598; c=relaxed/simple; bh=jTFvyUggpn9b7ir5dJXF/0vV6aESSqllkJsE1EJX8x0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qB6WuXC78EHO3BJ6mcnIG+YPRY7IDFdjgOlf6rCGoq5EuCnXJ45jlPADSQWpgdUKHeXlsUb9NUEMLur2R51LPD73w+PzZBnoB4Uh+Iq+9ZJtpNj8LmBVEvScarwXwa7DyqsOZZbHuR4UYYKdI5BTC54vV1yVnh4ukk5F0OsDjik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=dTc1iAnX; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="dTc1iAnX" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493ba701891so11941625e9.3 for ; Thu, 09 Jul 2026 02:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783590589; x=1784195389; darn=lists.linux.dev; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MXemn+RWgfgniHXL+Z+iccp115cwF5wMpUS4nNjdkFs=; b=dTc1iAnXumS0eNcGGlimMKO2m7K9g1JFHC1iml+S0JqltjW0qdQ/Y3yEUFwdg2h/Y/ SM0WRe5dY+82t3F5TqpBqaZrGy/GmYTpKPo2o4wguM478KY128lsyKJHhTWBXuvxsiYf ieHwqJuYyMVm7qSSUiIozNBvCZ9sFhkMvdjmPClUd+INpNjIAYtWxrxjmSI8fdXD90xY CKmFeGoqUuqxnHsvy2es+garUf0TFNNidPgfgTGIUHWsOPyVOwabFjnQj8NuVDu+wBj+ xLuB4LVDvcWQ9n69+upXARGTRgqqIwKr8Xt4sCGOLSnAvEmd7XRj+YpoBp1xhPZASvXm SlCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783590589; x=1784195389; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MXemn+RWgfgniHXL+Z+iccp115cwF5wMpUS4nNjdkFs=; b=HI16E6k280XJrqAiuyHezImlw8cGdK/kxevF+znkjrSFh/dY7400sdM8X3VGpQnm0/ wm6JW5UZQ9bEolshHnJp3WwXqQPfGRu91Y08p5IW/bTf1dJDnZ808zdCUhWKhvw21fsp 2MlZoQTw4JcqU+Lg4mpv+uZ7sq21GU1Imv8K1oAVozvbcKB310L5duzX3SEraCobMMk1 T2h8pQEIX14TXAYk6fYrgvNlbl8MHoyDVHiXiZ2Cejy0RdF9XRC942RSxTG/PMVjpTVv FkqEjLMSgBYA/HlN0E2sULiEYkaF7FkGrD0BuDOL1//clwSybUFUJHIksMozkuiRBAkk G95A== X-Forwarded-Encrypted: i=1; AHgh+RpWdSRY/hGGuCqqNbi4PSuAild4Us0uL6MpnjXfGMnFlIdP3zBOns1rWuPhQUJ2LaFoPYZBYczWzloRpA==@lists.linux.dev X-Gm-Message-State: AOJu0YyLRW1o5p4f6ahj/TKsK6iX7ZPiDQgY2eyIEvZwBqVPhxECqfWt ukF3yNe1VNiTRVPNHjyLq6R43V+27HCk64KOryrRcWjyELf19zqO6RxGYvFAS8O1gBM= X-Gm-Gg: AfdE7clN9OHGftj+DsZdDOvvcEVOOby3qlftctXnDt+3aeXo1yKEdQP1+ZSvrY2u4Im dSMFrEtLA+KB+8AC4Z7RehQjtPHQ+n0Naj1Z/Do8MahMi8DRXa/+zS/8A/AtFeVdF/+5q4q8+Nr NGsnunlbt33N7k0Byy2/iEEzjyDlrqivaZeBV6x6dL4OfC79Z9kKRcK6KMOB4F3U6Hq/c6JjRN1 JVA35oDV2lT/egqM4Mr4+ifK/rOhssrAJ56UeOFElp/px6nJ07bSC3rjbOR2i4GkxiP6sSz7TEj u1RAYp+vGO5Br8N4a+cs1PjaUWQx0312oiic3uey01hyVvXU58whbhmWdgeQq1rRzA+r5uyNxG5 VvK+FhPGO0DDhxkdIiHLSzxDt/u3FZR5YPiGTcJWO0BHzATUdCEYFQNSWO2T819La5GoU8vnB4R uveLJ08rIw9evRVOlJSdSf5fhBQ9Yz4iD6xA== X-Received: by 2002:a05:600c:c1d7:20b0:490:9782:3eb8 with SMTP id 5b1f17b1804b1-493e68c3535mr47652155e9.25.1783590588957; Thu, 09 Jul 2026 02:49:48 -0700 (PDT) Received: from [192.168.42.79] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6d53absm47837275e9.6.2026.07.09.02.49.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 02:49:48 -0700 (PDT) Message-ID: <3e2ae6e8-41ad-45f0-a885-131a5711c276@suse.com> Date: Thu, 9 Jul 2026 11:49:45 +0200 Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] umh, treewide: Explicitly include linux/umh.h where needed To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Jens Axboe , Johan Hovold , Alex Elder , Greg Kroah-Hartman , "Rafael J. Wysocki" , Michal Januszewski , Helge Deller , Alexander Viro , Christian Brauner , Jan Kara , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Mark Fasheh , Joel Becker , Joseph Qi , Tejun Heo , Johannes Weiner , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Pavel Machek , Len Brown , Andrew Morton , Danilo Krummrich , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , Kentaro Takeda , Tetsuo Handa , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linux.dev, linux-block@vger.kernel.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, cgroups@vger.kernel.org, linux-modules@vger.kernel.org, linux-pm@vger.kernel.org, driver-core@lists.linux.dev, bridge@lists.linux.dev, netdev@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org References: <20260708154510.6794-1-petr.pavlu@suse.com> <20260708154510.6794-2-petr.pavlu@suse.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/8/26 8:13 PM, Michal Koutný wrote: > Hi Petr. > > On Wed, Jul 08, 2026 at 05:44:29PM +0200, Petr Pavlu wrote: >> diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c >> index a4337c9b5287..60eb994c32ae 100644 >> --- a/kernel/cgroup/cgroup-v1.c >> +++ b/kernel/cgroup/cgroup-v1.c >> @@ -16,6 +16,7 @@ >> #include >> #include >> #include >> +#include >> >> #include > > There is kmod.h in here too but it's unnecessary, no module lazy loading > in this code. You're right. I'll remove the kmod.h include from kernel/cgroup/cgroup-v1.c. I went through all the files again and it seems this was the only place I missed. -- Thanks, Petr