From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Danilo Krummrich <dakr@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Linux Driver Core Development <driver-core@lists.linux.dev>
Subject: [PATCH v1 2/2] Revert "thermal/core: Allocate the thermal class dynamically"
Date: Mon, 24 Aug 2026 19:53:00 +0200 [thread overview]
Message-ID: <4761117.LvFx2qVVIh@rafael.j.wysocki> (raw)
In-Reply-To: <12960456.O9o76ZdvQC@rafael.j.wysocki>
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
This reverts commit 34f54003643e ("thermal/core: Allocate the thermal
class dynamically") that went against driver core changes aiming at the
elimination of class_create() [1].
No intentional functional impact.
Link: https://lore.kernel.org/linux-pm/2026082411-flask-rewire-434f@gregkh/
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/thermal/thermal_core.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 2d9d8740491f..82e2f0d8a26d 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -889,7 +889,9 @@ static void thermal_unbind_cdev_from_trip(struct thermal_zone_device *tz,
kfree(pos);
}
-static struct class *thermal_class __ro_after_init;
+static const struct class thermal_class = {
+ .name = "thermal",
+};
static bool thermal_class_unavailable __ro_after_init = true;
static inline
@@ -1011,7 +1013,7 @@ int thermal_cooling_device_add(struct thermal_cooling_device *cdev, void *devdat
mutex_init(&cdev->lock);
INIT_LIST_HEAD(&cdev->thermal_instances);
cdev->updated = false;
- cdev->device.class = thermal_class;
+ cdev->device.class = &thermal_class;
cdev->device.release = thermal_cdev_release;
device_initialize(&cdev->device);
cdev->devdata = devdata;
@@ -1484,7 +1486,7 @@ thermal_zone_device_register_with_trips(const char *type,
if (!tz->ops.critical)
tz->ops.critical = thermal_zone_device_critical;
- tz->device.class = thermal_class;
+ tz->device.class = &thermal_class;
tz->device.release = thermal_zone_device_release;
tz->devdata = devdata;
tz->num_trips = num_trips;
@@ -1790,7 +1792,6 @@ void thermal_pm_complete(void)
static int __init thermal_init(void)
{
- struct class *tc;
int result;
thermal_debug_init();
@@ -1809,13 +1810,10 @@ static int __init thermal_init(void)
if (result)
goto unregister_governors;
- tc = class_create("thermal");
- if (IS_ERR(tc)) {
- result = PTR_ERR(tc);
+ result = class_register(&thermal_class);
+ if (result)
goto unregister_governors;
- }
- thermal_class = tc;
thermal_class_unavailable = false;
return 0;
--
2.51.0
next prev parent reply other threads:[~2026-08-24 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 17:50 [PATCH v1 0/2] thermal: core: Revert two cosmetic update that go against driver core changes Rafael J. Wysocki
2026-08-24 17:52 ` [PATCH v1 1/2] Revert "thermal/core: Use the thermal class pointer as init guard" Rafael J. Wysocki
2026-08-24 17:53 ` Rafael J. Wysocki [this message]
2026-08-25 5:55 ` [PATCH v1 0/2] thermal: core: Revert two cosmetic update that go against driver core changes Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4761117.LvFx2qVVIh@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox