From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF74E3A63F8 for ; Tue, 31 Mar 2026 06:52:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774939960; cv=none; b=geF9qMjZM6Vjgk3AeksFRjZbFpcEch7LD66vtDwdc6ShaqGPOmKKUr8sqOooxraviDtZwfj8Y9qqV+pi+OerH3g9HZ80JNRAj2mzy4nK6b6j/j/XQ3zDb2UG1oScFYCAPaMxsodTMcqoN/IqXhm7QHt1TjaVguyj0ynzUgbMOHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774939960; c=relaxed/simple; bh=PLN12L/J2iyyWxe2If0sxXyHDGxdLInF1MDvYiDe6+8=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=OKPdXf9TERRSalwUWxz4wRt7S2+nXcLMw1BmTViTkYyeSZ2rAbnXvTyfdcKHcTkxvH3lrP/0dZdsGCAf/sANaCYW0Ou3peMC9RiN+sAk4JlSgcAav1a6cDmqiguV6/BIUXrFuqwWw8xdpFCuOqzIgeiYxUxGg3p/W+Esr9NDmU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cLFp5yHh; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cLFp5yHh" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-12776bebe9fso114523c88.1 for ; Mon, 30 Mar 2026 23:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774939958; x=1775544758; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=GbP8tAe8emnfrefImNYaY1sC/mYPUiQj77TYwG/NXDY=; b=cLFp5yHhD4dzWLd8COs0wKM5ykufiYgwqWLKVAcbN5k5jIFIt1pADPUx3bXCq98G55 b3D/FoG5UxrN5lX4Z/3sSCxZ1Pucd2FAr8vTNVk1GF5t9X9fJJmP898Uhup38KOkPtHm JwCE0nT9pDvq6npgd7hRqX9fJ9W8tqMpAGYCk9y6nGO/y6U78DjFKf8cGsx1Yo3iVF5A yyzMwV8vQkWpfyoHQ4MUbIax5j9PXFPcTvSdoIquYIhj/w2yN7Rr4Ehy7kRsWIxnhp4Y ovqgwJvBaUs5bEBjb/7vJTvGXVQwDgKxEL3/KPqyv9UohK4Hk/vfSMSo/Tx1V2hbZ5/A I06w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774939958; x=1775544758; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GbP8tAe8emnfrefImNYaY1sC/mYPUiQj77TYwG/NXDY=; b=Mpf2RL+2T/yEg0/s+EGU70tsOGtTUFocAm70+S5jU9r1ldwDqiWh0HME1qdXlNxBsy ZLRzuZoiXo6CaShmrJb6amJ4OVTmfFRq4oRWOewRP7O+KzbCsHJvZ2iSvUKFkcqV3Dx7 fBWcJ+64KzX59ZRXNcvEZrJ1x2xDcRVoOmGR8JqLbRfmmcdsUBqYRCGjnFq2YvfnReX3 Xpc6DdqPNQSvP3e++eaHmTxGZQBWaTWT3/uLKFdMWyWGHa6ZRvMLydDXMFGNi8N3s66l Ph9zZtUuDoiSsd4aztlPz0l9iteXVBB2BlPRBEBoE6BAtYRoY6VieSii+KK2a44W4Gsk 3pkw== X-Forwarded-Encrypted: i=1; AJvYcCWCfu72rZECAdMLzUyW2ModZjSO9mE1SGpxCfVhZG+3XnvOv3z+6GrT++4qjijwFoU3SPPF9KX7ZROz1g==@lists.linux.dev X-Gm-Message-State: AOJu0YzCTDh+jJlA0gPa7kGt6h/L6+ONXGwF3ZRnLPDiE/AGJ34b0cTh 4V9GLWJsM81XOxdOThxsQu/2vnHzRhFlpO5pc2g+TRsxo1huMWKJbd05 X-Gm-Gg: ATEYQzwIJL/NdCRc/a0t3roKSV+l/GvYwO6+/IfmCd00MAWx2Bj3txInQ6gy3+Xkbxm FuTx5BPBbNpYycCZxuAPK5yILvgjfeGEaxE/28qnao0fU1Hf0Y22zN609II2NAEWe1QguyPtml1 wot5DXrNOsb/nOnvAiGlO3Yri0ZwgndCcGq3Xchctw/UCcPQ8qhZQfKJGjjrxV3DuieP7dJvAD/ DiHN2rrzBqn28GOTHuzdvrPVa0517+cOrBr07IsStQ7Bi/sJ8zdht090QI5s0oVeVV51kJXkV+M MOoAhbXoPMsR+rsU1P76wDFMtvMrSM+nifAnDDeJmAa/QUIml0FuCrU0LY4YD+//AIjTTX///xG H6pHMA01r5Uxq3P0aVrZ/X56WBfBSS02PfsrsnboQ5kaCssvJRq/CviphSEMWI3tCKtzC93KD1L oHQskbcjGt4veGCdMJ+bM+7GbCYmJNbZyO1ixHcIflOxw= X-Received: by 2002:a05:7022:4393:b0:12a:94ab:e20 with SMTP id a92af1059eb24-12ab28d8bb8mr9317994c88.20.1774939957860; Mon, 30 Mar 2026 23:52:37 -0700 (PDT) Received: from ehlo.thunderbird.net ([2601:647:5e00:4acd:7f58:87c9:ef3d:71ac]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab983f904sm13792148c88.9.2026.03.30.23.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 23:52:37 -0700 (PDT) Date: Mon, 30 Mar 2026 23:52:34 -0700 From: Dmitry Torokhov To: Andy Shevchenko CC: Bartosz Golaszewski , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Daniel Scally , Heikki Krogerus , Sakari Ailus , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Kevin Hilman , Arnd Bergmann , brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v4 2/3] driver core: make software nodes available earlier User-Agent: K-9 Mail for Android In-Reply-To: References: <20260330-nokia770-gpio-swnodes-v4-0-b68592e977d0@oss.qualcomm.com> <20260330-nokia770-gpio-swnodes-v4-2-b68592e977d0@oss.qualcomm.com> Message-ID: Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On March 30, 2026 11:25:33 PM PDT, Andy Shevchenko wrote: >On Mon, Mar 30, 2026 at 02:46:45PM -0700, Dmitry Torokhov wrote: >> On Mon, Mar 30, 2026 at 11:24:45PM +0300, Andy Shevchenko wrote: >> > On Mon, Mar 30, 2026 at 02:40:47PM +0200, Bartosz Golaszewski wrote: > >=2E=2E=2E > >> > > -static void __exit software_node_exit(void) >> > > -{ >> > > - ida_destroy(&swnode_root_ids); >> > > - kset_unregister(swnode_kset); >> > > } >> > > -__exitcall(software_node_exit); >> >=20 >> > Why? What's wrong with the __exitcall? >>=20 >> It's dead code=2E Always was, always will be=2E >>=20 >> Maybe split in a separate patch, but I sometimes feel the idea of "one >> change" is taken to extreme and adds to both developer's and maintainer= s >> burden by needing to keep track of extra patches=2E > >Why does __exitcall() exist then? It's also used in other places=2E >I think it's generally good to have a possibility to clean up >after run=2E > The code section will be discarded when the kernel finishes booting so it = only increases image size on disk=2E=20 >A bit of archaeology: > >The first time it appeared was in the bcc2152647b8 ("Import 2=2E4=2E0-tes= t3pre3")=2E >Then somehow spread a bit (but not much)=2E > And it shows how useful it is=2E Maybe it had some purpose a long time ago= , but at present time this code will never be executed since it cannot be b= uilt as a module=2E Thanks=2E=20 --=20 Dmitry