From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 611701531E8; Tue, 30 Jun 2026 21:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782856325; cv=none; b=CxM44oeg98246htN9MgPNYynvWkss5yQjTIlR2Hl80Ls79eW+yePOm9LYisePUouyejunvF1rKd0C8n7vhe+/EXRR6FYSr8KvRyUGD76Ess2Ga7xUq3Ci0ZYgcE1HVUQp1yo6hvTPfGDV+XnkGy2GhTes6l/qRrrw7PGWwP8Xe0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782856325; c=relaxed/simple; bh=8JiTjT5Lrqsx/ou5nc3RDpYw9aXzkKLqhT9tlPUe2lY=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=Hu/WuUW63hHQ0L49db1ghT6T7DK3TmzEIahqwGFqu1iy4ZoEwq3GxbSbgy2IpxccS4DVV7oSYVgvp520dP1MAeMMy1jSOvHUFtbPzckhhlipXWB5uw/CoXNy6w26mD5U8qr+FRi1STeZr7jI9q9al1Tte+wm3JPN1Cj8FxsXD3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BmvDpbkc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BmvDpbkc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67D301F000E9; Tue, 30 Jun 2026 21:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782856324; bh=8JiTjT5Lrqsx/ou5nc3RDpYw9aXzkKLqhT9tlPUe2lY=; h=Date:Subject:Cc:To:From:References:In-Reply-To; b=BmvDpbkclL7RvwJJXqL+tIOJ+TeLHCqo/H4wLUG/20aHB7tpTy8PyToDfQLJhuFvH 5ZHnNKih9HdLwy5NeqyUFQm1MJfKflHZWDPkpFKXFNdKGqRMYW8itbl48MThGDIT8r UWJd8Iu8KQ86fNw8TX9JXxWVnqlNef9QAph5jiSQ3k98Mr/KBBIifL3SEUvsWYkk0O kZXI7+lgIQ2sAwYyxsT6k9keBwmes2RIOpE5pYH4cYbyiIsTWtBDazAb6A25jOK7pa DnqINSq6Z2yEqAvzd5DRja/g6Dv+ng/Gwdno6LA2Tczh8/cyzCD5Gax6xDzwgM+2rI vjW/Iu7hldm+Q== Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 30 Jun 2026 23:52:00 +0200 Message-Id: Subject: Re: [PATCH 3/4] usb: serial: spcp8x5: don't keep usb_device_id Cc: "Greg Kroah-Hartman" , "Rafael J. Wysocki" , =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , "Johan Hovold" , , , , To: "Gary Guo" From: "Danilo Krummrich" References: <20260630-usb_dyn_id_uaf-v1-0-160a02be5ac2@garyguo.net> <20260630-usb_dyn_id_uaf-v1-3-160a02be5ac2@garyguo.net> In-Reply-To: <20260630-usb_dyn_id_uaf-v1-3-160a02be5ac2@garyguo.net> On Tue Jun 30, 2026 at 1:38 PM CEST, Gary Guo wrote: > USB probe functions should not keep usb_device_id for longer than probe d= ue > to presence of dynamic ID removal. USB serial does not support ID removal= , > however in this case only driver_data is ever needed, there is no reason > keeping the usb_device_id in the first place, so convert it as well. > > Signed-off-by: Gary Guo > --- Reviewed-by: Danilo Krummrich