From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v5 2/2] regcache: Move HW readback after cache initialisation
Date: Tue, 3 Mar 2026 17:29:49 +0200 [thread overview]
Message-ID: <aab-baa1AwINiug9@ashevche-desk.local> (raw)
In-Reply-To: <b619232e-d7d6-493e-b033-86850429af6c@sirena.org.uk>
On Tue, Mar 03, 2026 at 01:03:11PM +0000, Mark Brown wrote:
> On Tue, Mar 03, 2026 at 10:26:25AM +0100, Andy Shevchenko wrote:
...
> > int regcache_init(struct regmap *map, const struct regmap_config *config)
> > ret = map->cache_ops->init(map);
> > map->unlock(map->lock_arg);
> > if (ret)
> > - goto err_free;
> > + return ret;
> > }
>
> We might still need to free the copy we take of supplied reg_defaults,
> it's not just the hw_init case.
I see, so someone transfers an ownership to that allocation...
I'll check more, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-03 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 9:26 [PATCH v5 0/2] regcache: Avoid accessing non-initialised cache Andy Shevchenko
2026-03-03 9:26 ` [PATCH v5 1/2] regcache: Factor out regcache_hw_exit() helper Andy Shevchenko
2026-03-03 9:26 ` [PATCH v5 2/2] regcache: Move HW readback after cache initialisation Andy Shevchenko
2026-03-03 13:03 ` Mark Brown
2026-03-03 15:29 ` Andy Shevchenko [this message]
2026-03-03 19:20 ` [PATCH v5 0/2] regcache: Avoid accessing non-initialised cache Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aab-baa1AwINiug9@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox