From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5860237F006 for ; Mon, 23 Mar 2026 21:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774301981; cv=none; b=U/uVnRjBPQsuDGGC15azu/Csz3vPmJzZx2iWDzkmIlvnlfKuxuF9tqpo8J0HZ8qmANClHl4qPJE8gqwHif2hYoT0vIATRmG2VIFfsTmdk0g+/RfBevCuesWcEgsPonulRKpXO12zE/VMhe3X39Aknr/i/Ep1CZZWeZfZlzezfps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774301981; c=relaxed/simple; bh=4+vcXD+1P3FXjL2Owm4YaNBB0CpFOHixgkjfmiDa1M4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P6qNIfPuRVyB8mAr+hy8MCqFU3rjF3SNQZN94IAosHLAy14OH2vB49IEev8uFRYWhONJRa47MN+wjIfeGZl4WzgqQQOrX+Fr9QBUPILoTue9AEycgIgzgXQ4DfodZ12J0txr58+Ygq7t4BIoBbE0fUcCM6YCpjh3wC/nIykEtrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H0ge84mg; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H0ge84mg" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-12a74039dc6so548496c88.0 for ; Mon, 23 Mar 2026 14:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774301979; x=1774906779; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yGHdDoGsiDtOdNrXq7SHzA/I1zh7boK5LF3ZF/OlV0U=; b=H0ge84mgk8KGJGNRX4p60H+Y6bpkLH6P99y2LCYiw7zoiAXbMaMSoHhedZkKab9P+D Wlsq1wtNqUhneXINr1B56o6RrCt4eLcZVkG9w3hxGT20E18dJ6n5pSSqEhtKRngCo43t FfX3rwda64MzjyaaUB8SXzp6oMkp091yarc5y/SOzdwzyHfMFfxCM/XHeqKWNAUZvhlG 4kr9+FWi9q2dr+oKKTLeQQEuLnyy2WVMCvrHXSZtjtiCBVBSezK/BQ/wS0ihHvYuFQ8E /tH2uE61Qb3DtQcCyyWXSR0wf+Hr6EmrzisM4lNmTPFbC2IsYMm2SjigTpwYKJPXuAz3 5AMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774301979; x=1774906779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yGHdDoGsiDtOdNrXq7SHzA/I1zh7boK5LF3ZF/OlV0U=; b=UqOv2qxL+/G4O+Z1IVAERxcv33aaX6YE1FpTT8ozFooAIrEgphVZfzKRymoElPAVq8 1MB9xEQYtQplV/ARIkpMBUinJ67bg0zdEDvNFYAbYmjNI/qx8HFdSABbVun4uFp9qCAA MBGUiXjnh/oUU7WidyghQqRBD1jhLUgxj5JeD218ayrcEuRWHaJUecpf2PX0dVjFVF96 nn/nHdWpNpoNF73G4AzxIQ/AWjgAmc/+mxQyOywoW9/XPzUlBeEf8g/xEWENaaoAl+KA sF5SDaZWApBkzB4Q/ApNb5HCR8l1szBwV2aIFwe7YjBY4r7v+9t8sI46MGd9X6bwIewU GQEQ== X-Forwarded-Encrypted: i=1; AJvYcCWPaXLhQwFqZ92+FRwt50aM1C1OGe6koASV38V586q1iiY5r9Eg/nJBEr9v+viEfJTSoWzr43/uX9sdrQ==@lists.linux.dev X-Gm-Message-State: AOJu0Yxfbj3mPuM0Vps4k0Wphy6Ge8dJjvbtX4YKDUHBmzB1omTu367P JUQew3ryv4hchQ0+nG7aXC+q/YTPIV9xY8XXKzBTCuN9GsKk5niWEQ9r X-Gm-Gg: ATEYQzyK3V7vnZ/dCIOoPARvOJcSV2ZGRXA6eV8phqBfiY6r42rHaapr30kRGSopnG1 7FY4WJwE4pl/R7U9paebjrOsMefs+cOHGuBPFVVGTa47e8vNhIpyZYRU5K20Tty/XtatRbv6JmU Xa03yzZJhS96WWr18qMTeXJDZLAf6Le4N8SU4mL9UjQnbzqQVSLDBTUVDUJcCZN9P5hPSjyx7DE vuzjdLmQjil8sktmUJFIrANot+Led6Vnpej4cDL1tJ3/llZEJ7ElA0zBf9Q0qRw6zi3sbTaq9++ Mf0C1A7Uf3iVYe9qkD52rkiOcSkcEV6tXSSffRH0edYFZt+CV4hfoccUS6xsMxqRT9I2obQB1dt QpAANZSJWuaLGYlwlClcQVu2qdjFMCBN9UX7T8ut8YhZraGA3R2+VwN69H/BmH494Mc1leH1I3W NAogaJbGcMBEgELgMouTOUdhLWePPCvqZ0spXt+LILlR+3dvaURIJRJZTwLvBg7qan X-Received: by 2002:a05:7300:dc94:b0:2ba:6819:2e9b with SMTP id 5a478bee46e88-2c1095a5302mr6126697eec.3.1774301979400; Mon, 23 Mar 2026 14:39:39 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a296:1211:5ab0:bc95]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b2d01f7sm13145631eec.23.2026.03.23.14.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 14:39:38 -0700 (PDT) Date: Mon, 23 Mar 2026 14:39:35 -0700 From: Dmitry Torokhov To: Mark Brown Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Neil Armstrong , Liam Girdwood , Lee Jones , Pavel Machek , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , Moritz Fischer , Xu Yilun , Tom Rix , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-spi@vger.kernel.org, linux-leds@vger.kernel.org, linux-fpga@vger.kernel.org, driver-core@lists.linux.dev Subject: Re: [PATCH 04/10] regulator: of: switch to using class_find_device_by_fwnode() Message-ID: References: <20260322-remove-device-find-by-of-node-v1-0-b72eb22a1215@gmail.com> <20260322-remove-device-find-by-of-node-v1-4-b72eb22a1215@gmail.com> <360a8b4a-6507-417a-9fc1-c53b14868657@sirena.org.uk> <7d46803e-b285-4e9c-8856-10100fa0ea85@sirena.org.uk> <55abcc68-747a-468a-abdf-b6340d658c4f@sirena.org.uk> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55abcc68-747a-468a-abdf-b6340d658c4f@sirena.org.uk> On Mon, Mar 23, 2026 at 07:58:14PM +0000, Mark Brown wrote: > On Mon, Mar 23, 2026 at 12:41:59PM -0700, Dmitry Torokhov wrote: > > On Mon, Mar 23, 2026 at 07:05:13PM +0000, Mark Brown wrote: > > > > I think this is a worrying idea for core code like this, we have > > > specific firmware bindings for specific firmware interfaces with the > > > different interfaces having very different ideas of how things should be > > > modelled. The chances that firmware agnostic code is going to do the > > > right thing seem low, and encouraging the use of generic APIs that might > > > happen to run OK raises the risk that we'll get firmware vendors relying > > > on them and leaving us with a conceptual mishmash to sort through. > > > Firmware vendors can introduce incompatible DT bindings and have them in > > their devices too and we have to deal with that... > > The case that's worrying me is mixing the ACPI and DT design models in > one system, and especially having that happen to actually work without > modification purely by luck rather than by design. > > > I think if this pushes closer ACPI and OF schemas for at least some > > subsystems closer to each other it would not be a bad thing. > > I think we shouldn't be encouraging people to just throw random stuff at > the wall and see if it happens to run OK with whatever OS they tried > booting. The differences between ACPI and DT in areas like the > regulator bindings are fundamental conceptual ones. There's some areas > where things are closer and it winds up being fine actually, especially > for leaf devices, but there's others where that's less likely. Maybe we should just have explicit checks with nice comments at the beginning of the schema parsing stating that this schema is intentionally restricted to OF (or ACPI) in cases where we ave distinct schemas? This way it is explicit that it is a thought out decision and not simply a legacy artefact. I think we want to hanel software nodes because they do not form their own schemas, they follow the existing ones (DT usually). -- Dmitry