From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Hans de Goede <hansg@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
driver-core@lists.linux.dev
Subject: Re: [PATCH v2 4/4] x86/geode: use PROPERTY_ENTRY_REF for GPIO properties
Date: Mon, 30 Mar 2026 13:48:15 +0300 [thread overview]
Message-ID: <acpU76DX4m7Vcq1c@ashevche-desk.local> (raw)
In-Reply-To: <20260329-property-gpio-fix-v2-4-3cca5ba136d8@gmail.com>
On Sun, Mar 29, 2026 at 07:27:51PM -0700, Dmitry Torokhov wrote:
> Now that the PROPERTY_ENTRY_REF macro can accept a pointer to struct
PROPERTY_ENTRY_REF()
> software_node_ref_args directly, we don't need to use the more
> cumbersome PROPERTY_ENTRY_REF_ARRAY_LEN(..., 1) variant.
...
> int __init geode_create_leds(const char *label, const struct geode_led *leds,
> leds[i].pin,
> GPIO_ACTIVE_LOW);
Wondering if we want to have a wrapper for the above like
#define PROPERTY_ENTRY_GPIO_REF(...) \
SOFTWARE_NODE_REFERENCE(...)
(naming most likely sucks, and yeah, it would make sense if name is shorter
than the currently used one).
> props[i * 3 + 0] =
> - PROPERTY_ENTRY_REF_ARRAY_LEN("gpios", &gpio_refs[i], 1);
> + PROPERTY_ENTRY_REF("gpios", &gpio_refs[i]);
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-30 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 2:27 [PATCH v2 0/4] Fix handling of GPIO keys and LEDs on geode Dmitry Torokhov
2026-03-30 2:27 ` [PATCH v2 1/4] x86/geode: fix on-stack property data usage Dmitry Torokhov
2026-03-31 5:49 ` Dmitry Torokhov
2026-03-31 8:09 ` Ingo Molnar
2026-03-30 2:27 ` [PATCH v2 2/4] software node: allow passing reference args to PROPERTY_ENTRY_REF Dmitry Torokhov
2026-03-30 10:21 ` Andy Shevchenko
2026-03-30 2:27 ` [PATCH v2 3/4] software node: verify that property data is not on stack Dmitry Torokhov
2026-03-30 10:33 ` Andy Shevchenko
2026-03-30 21:49 ` Dmitry Torokhov
2026-03-31 8:02 ` Andy Shevchenko
2026-03-31 8:33 ` Andy Shevchenko
2026-04-05 3:27 ` Dmitry Torokhov
2026-04-05 3:29 ` Dmitry Torokhov
2026-03-30 2:27 ` [PATCH v2 4/4] x86/geode: use PROPERTY_ENTRY_REF for GPIO properties Dmitry Torokhov
2026-03-30 10:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acpU76DX4m7Vcq1c@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dakr@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox