Re: [PATCH v4 2/3] driver core: make software nodes available earlier

Dmitry Torokhov
2026-03-30T21:46:51Z

On Mon, Mar 30, 2026 at 11:24:45PM +0300, Andy Shevchenko wrote:
> On Mon, Mar 30, 2026 at 02:40:47PM +0200, Bartosz Golaszewski wrote:
> > Software nodes are currently initialized in a function registered as
> > a postcore_initcall(). However, some devices may want to register
> > software nodes earlier than that (or also in a postcore_initcall() where
> > they're at the merci of the link order). Move the initialization to
> > driver_init() making swnode available much earlier as well as making
> > their initialization time deterministic.
>
> ...
>
> > -static void __exit software_node_exit(void)
> > -{
> > - ida_destroy(&swnode_root_ids);
> > - kset_unregister(swnode_kset);
> > }
> > -__exitcall(software_node_exit);
>
>
> Why? What's wrong with the __exitcall?
>

It's dead code. Always was, always will be.

Maybe split in a separate patch, but I sometimes feel the idea of "one
change" is taken to extreme and adds to both developer's and maintainers
burden by needing to keep track of extra patches.

Thanks.

--
Dmitry