From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48F753D4130 for ; Mon, 27 Apr 2026 14:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777301238; cv=none; b=DtT03dTkUxk46iK1jEr4lG064KHkxlu0hDI1hK1Raneprd98xptfmxvW/rQ8lcVSb5VuBB4PpOsWAASe+zuXNJiRSXo2DNE/tBYk2coz6+Qd26CkR6ZndQj/m4W6galGQdgLTiO3SEoNm8L4KuFbpPa/+SloGbOLeKlFXayRU98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777301238; c=relaxed/simple; bh=jT2AkInyBs5AHhImaePhMXJs0gLBgOo64GulDs2fmD8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MKeK0ED5sGigPols1rWvnyWIRTZEuEul0yipvsD1NEAaA8+UXdP14y2OV2tO9KmIN06tZOA6zTxsCdfxU9JfYozl9UW77cimrTB2eKJAza79nzM3wPCZaPrrvqvYNL93SnvMzcTkqJyn3yyQzTD8ZakE4aiq6OFg8vq92FQ9Kxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LNTQelJS; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LNTQelJS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777301235; x=1808837235; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jT2AkInyBs5AHhImaePhMXJs0gLBgOo64GulDs2fmD8=; b=LNTQelJSFd6nDSZTI9/ParbhchKVrfivoKtnRFXV5E/OvAuQ0ebtsZ+w uP9+mUspQ2+/NoryAsH4dOFtVGdUvYB50FqJvlm8xv3BhfPJrfgSXnKPx g/tPiqExnCZxA+5kY/6LQFz899n2lGKdaQ8+5SgiFpvTZ/w5xl/Dh2ECt 12mZcB62rE5WgiGsaj7AsZyex+eD1q28L1bLBMd0Rr3yBgomfbQ6Pv8vG duMfrfqlzUHs5CFkwF0ylvitp9BPYfDLqlWTHjDpqKDgHb7jx0JSRqMqD DC9Yp5bZJobGDaLvROYgWFEO3SywaHbYPPRNFYHHRooaGTVEI0rJGc/mC w==; X-CSE-ConnectionGUID: n6+mXdL6R02F7HeU4y0ppw== X-CSE-MsgGUID: fsHTAJHJTDyO0FsBt1AGJQ== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="78248694" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="78248694" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 07:47:09 -0700 X-CSE-ConnectionGUID: Oe2us8pQSNqzXlSerDdJsw== X-CSE-MsgGUID: PBgU0GbSSoquH4xNqUNteQ== X-ExtLoop1: 1 Received: from fpallare-mobl4.ger.corp.intel.com (HELO localhost) ([10.245.244.2]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 07:47:05 -0700 Date: Mon, 27 Apr 2026 17:47:03 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Daniel Scally , Heikki Krogerus , Sakari Ailus , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Dmitry Torokhov , Kevin Hilman , Arnd Bergmann , brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 2/3] ARM: omap1: use platform_device_register_full() for GPIO devices on OMAP 16xx Message-ID: References: <20260427-nokia770-gpio-swnodes-v6-0-b693296c1985@oss.qualcomm.com> <20260427-nokia770-gpio-swnodes-v6-2-b693296c1985@oss.qualcomm.com> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Apr 27, 2026 at 05:44:05PM +0300, Andy Shevchenko wrote: > On Mon, Apr 27, 2026 at 12:46:33PM +0200, Bartosz Golaszewski wrote: ... > > for (i = 0; i < ARRAY_SIZE(omap16xx_gpio_dev); i++) { > > - pdev = omap16xx_gpio_dev[i]; > > + pdevinfo = omap16xx_gpio_dev[i]; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + res = &pdevinfo->res[0]; > > if (unlikely(!res)) { > > dev_err(&pdev->dev, "Invalid mem resource.\n"); > > return -ENODEV; > > > base = ioremap(res->start, resource_size(res)); > > if (unlikely(!base)) { > > - dev_err(&pdev->dev, "ioremap failed.\n"); > > + pr_err("ioremap failed.\n"); > > return -ENOMEM; > > } > > Isn't this a stray change? Or why then? And why the previous dev_err() is left untouched? If you go with pr_*(), please use ->name and ->id from pdevinfo to make it on par with the previously called dev_err(). Perhaps even pr_fmt() on top of that (on top of the file). > > __raw_writel(SYSCONFIG_WORD, base + OMAP1610_GPIO_SYSCONFIG); > > iounmap(base); > > > > - platform_device_register(omap16xx_gpio_dev[i]); > > + platform_device_register_full(omap16xx_gpio_dev[i]); > > } -- With Best Regards, Andy Shevchenko