Re: [PATCH v6 3/3] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770

Andy Shevchenko
2026-04-27T14:52:56Z

On Mon, Apr 27, 2026 at 12:46:34PM +0200, Bartosz Golaszewski wrote:
> Currently the board file for Nokia 770 creates dummy software nodes not
> attached in any way to the actual GPIO controller devices and uses the
> fact that GPIOLIB matching swnode's name to the GPIO chip's label during
> software node lookup. This behavior is wrong and we want to remove it.
> To that end, we need to first convert all existing users to creating
> actual fwnode links.
>
> Create real software nodes for GPIO controllers on OMAP16xx and
> reference them from the software nodes in the nokia board file.

...

> #define ADS7846_PENDOWN_GPIO 15

This is the only definition for a GPIO pin and its purpose obvious from the
GPIO con_id below. So, while at it, perhaps get rid of it as well?..

> - PROPERTY_ENTRY_GPIO("pendown-gpios", &nokia770_gpiochip1_node,
> + PROPERTY_ENTRY_GPIO("pendown-gpios", &omap16xx_gpio1_swnode,
> ADS7846_PENDOWN_GPIO, GPIO_ACTIVE_LOW),

...will become

PROPERTY_ENTRY_GPIO("pendown-gpios", &omap16xx_gpio1_swnode, 15, GPIO_ACTIVE_LOW),

(or wrapped version).

--
With Best Regards,
Andy Shevchenko