From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 401DE39A06E for ; Thu, 30 Apr 2026 12:52:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777553526; cv=none; b=V0WUwHtPZMuaqimCbbNRsVzmbEvi8aQoggwb/JgDBWcPj0jKmymojMIw4d7UTjbOm/5XDXEwm8TMb12uObOI0vjXJzkW8b7CMLHSLO0mSq7xxXMYtQfzOM+tiFrvntJT9/N2GO1ubfd+u06SQUn0+mBoiMu/8QECXcEQeLUlpQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777553526; c=relaxed/simple; bh=3A+ZKlTiXYyj3m20/8ggC63q8vnO7tm6cFlVhOyzMLk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Oi8oQSw7PoklcwNxKfYI0HGRLvU/YT7fuepNwzvqoQCiYt83KNH2p1KI6xE4B/oFkiq+UFEZedMvqIZ08o+3pCUkM8VNrXTDP12RobmURh2CPaA+U7XOvx/TQO2TuSiQ5KY5sQTjVCgNRmB2olyhIlX6I7P14bITPrkLQlczQ+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=H+acccv+; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="H+acccv+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777553525; x=1809089525; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3A+ZKlTiXYyj3m20/8ggC63q8vnO7tm6cFlVhOyzMLk=; b=H+acccv+Q40wKMtD0dE0ii0hMwWCpKKlWErNw7/2LMcMEOwBqO0ameCC 3tfzHRnH6kthzypUVBP7VOJfFIpqmbc6fqGFRSJ7OEXYWlOV87Z+JeuqB CYyJPvhkxIEx7j7RdDvTB1Rs+rHZDw9+yMsolo1OTy+aJO53FPXJrNZsx TPd4Izw2pBGFcDuRFJPEa/N4Vbqsg3tvHFy2HYINc7whYNBOcDeA+IuYa namlv6VFoP+SeAPbZ6665NnVwb83H2c2ibqfgYh6nj+GZRXHekvNnxIg2 nDXfEKY2zmoIsLQc3M2vcVxakT7AzVmMaJI3H80pQ4Nfgqt1k5HRNMz8w g==; X-CSE-ConnectionGUID: DtoJ6ZdMSAWcwILrFBoLxg== X-CSE-MsgGUID: DWGXBOvoRAyES/2LJzimzw== X-IronPort-AV: E=McAfee;i="6800,10657,11771"; a="81075734" X-IronPort-AV: E=Sophos;i="6.23,208,1770624000"; d="scan'208";a="81075734" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2026 05:52:05 -0700 X-CSE-ConnectionGUID: 3iFZh2LPSv6l+Uj1zSqRAQ== X-CSE-MsgGUID: bp9WQx6kRm6e+OedyEC20A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,208,1770624000"; d="scan'208";a="228063936" Received: from zzombora-mobl1 (HELO localhost) ([10.245.244.42]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2026 05:52:00 -0700 Date: Thu, 30 Apr 2026 15:51:58 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mika Westerberg , Andy Shevchenko , Linus Walleij , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Dmitry Torokhov , Len Brown , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, brgl@kernel.org Subject: Re: [PATCH v4 2/2] platform/x86: x86-android-tablets: enable fwnode matching of GPIO chips Message-ID: References: <20260430-baytrail-real-swnode-v4-0-767bcda6667f@oss.qualcomm.com> <20260430-baytrail-real-swnode-v4-2-767bcda6667f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430-baytrail-real-swnode-v4-2-767bcda6667f@oss.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Apr 30, 2026 at 09:34:06AM +0200, Bartosz Golaszewski wrote: > In order to allow GPIOLIB to match cherryview and baytrail GPIO > controllers by their firmware nodes instead of their names, we need to > attach the - currently "dangling" - existing software nodes to their > target devices dynamically. > > The driver uses platform_create_bundle() and expects all required > providers to be present before it itself is probed. We know the name of > the device we're waiting for so look them up and assign the appropriate > software node as the secondary firmware node of the underlying ACPI node. > > Scheduling fine-grained devres actions allows for proper teardown and > unsetting of the secondary firmware nodes. ... > +static void auto_secondary_unset(void *data) > +{ > + struct fwnode_handle *fwnode = data; > + > + fwnode->secondary = NULL; > +} > + > +static int acpi_set_secondary_fwnode(struct device *parent, struct device *dev, > + const struct software_node *const swnode) > +{ > + struct acpi_device *device = to_acpi_device(dev); > + struct fwnode_handle *fwnode; > + int ret; > + > + fwnode = software_node_fwnode(swnode); > + if (WARN_ON(!fwnode)) > + return -ENOENT; > + > + fwnode->secondary = ERR_PTR(-ENODEV); > + device->fwnode.secondary = fwnode; > + > + ret = devm_add_action_or_reset(parent, auto_secondary_unset, &device->fwnode); > + if (ret) > + dev_err(parent, "Failed to schedule the unset action for secondary fwnode\n"); > + > + return ret; > +} Why don't we use set_secondary_fwnode() in the above functions? Drivers are not supposed to know the guts of the fwnode implementation. ... > +static int auto_secondary_fwnode_init(struct device *parent) > +{ > + const struct software_node *const *swnode; > + int ret; > + > + if (!gpiochip_node_group) > + return 0; > + > + ret = software_node_register_node_group(gpiochip_node_group); > + if (ret) > + return ret; > + > + ret = devm_add_action_or_reset(parent, > + auto_secondary_unregister_node_group, > + gpiochip_node_group); > + if (ret) > + return ret; > + > + for (swnode = gpiochip_node_group; *swnode; swnode++) { > + struct device *dev __free(put_device) = > + acpi_bus_find_device_by_name((*swnode)->name); > + if (!dev) { > + dev_err(parent, "Failed to find the required GPIO controller: %s\n", > + (*swnode)->name); swnode at this point is registered, meaning we have an associated fwnode handle, hence why not use %pfwP here? > + return -ENODEV; > + } > + > + ret = acpi_set_secondary_fwnode(parent, dev, *swnode); > + if (ret) > + return ret; > + } > + > + return 0; > +} -- With Best Regards, Andy Shevchenko