From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D65C48C3EF;
	Tue, 12 May 2026 08:12:57 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778573577; cv=none; b=k7NrrVy9ZhzcwV11RWF4vshM2GIDW9bGxdU0eovWBnMshRhKz+eiX300Q3YpOUfljPvqKExi5lUIInIAukNTdPuDoR4ybk02tB0szgdz2mfchy/sPhHvz2I6gtAiv8QMxDL9zo/iG8d4z0ZWoeSRMW5JPBfESD45HEu3pFw3BR8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778573577; c=relaxed/simple;
	bh=qtiatd0nSAUF+Q89Nbewhk7WjkI1dAtQGkhYNYnelVA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=b0/osmfEWEWbZMQN2hvVUPHf11SQ4uFbXdsXFE1481rjurBTgrABVk/oMSO3ga1u5yZrzLj4qBxszvzPpKvQ6J/NykbmNgMrMWzDH8HqBsLo/Gr2MMetL6LEVWaF949AXmzgtQ4ZlND7MwnARuZJjE3xekQXPqUqcl7yPnu9eT0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IVMDGeKc; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IVMDGeKc"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66D55C2BCB0;
	Tue, 12 May 2026 08:12:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1778573577;
	bh=qtiatd0nSAUF+Q89Nbewhk7WjkI1dAtQGkhYNYnelVA=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=IVMDGeKcoSZJpErcSiCIpceir4ZQBLuUMyEnnsBTnDdwoAz/7DPGZbYpOTtbBWLaB
	 OyxJ/dYLtyVvLYcRdQOu/5H8WYZACUWvoDk3o7qqZ67y2H4DYn+7ANTRPjgDKDwShy
	 sLexeyBPANojkuPiUQHrHtDTatbjh1yfYe2eh5w5+Clrh4Z8Y+BnbnO9K+5+cJEnFQ
	 VYrZ18oBx0TmvZjQtq4C5mlmGEzwaYH5Z+cG+Xq8XlON9GMHdUwePztAikZqEsFvyf
	 ndvel5ZtClcEmmPnRvuu/Wje6FJDjCOi/K7VqKaGwAoHtiUnpsGAQJIRvnUfw2LsjE
	 MFR2qp3d0U/Iw==
Date: Tue, 12 May 2026 08:12:52 +0000
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Benson Leung <bleung@chromium.org>, linux-kernel@vger.kernel.org,
	chrome-platform@lists.linux.dev, driver-core@lists.linux.dev,
	linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Johan Hovold <johan@kernel.org>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linusw@kernel.org>
Subject: Re: [PATCH v10 2/9] revocable: Add KUnit test cases
Message-ID: <agLhBHb5fMaNYpV7@google.com>
References: <20260508105448.31799-1-tzungbi@kernel.org>
 <20260508105448.31799-3-tzungbi@kernel.org>
 <CAMRc=McPez6Ver5NgrDPnM9YDb7cPonWE7BBsS_5AnY9tGf3xQ@mail.gmail.com>
Precedence: bulk
X-Mailing-List: driver-core@lists.linux.dev
List-Id: <driver-core.lists.linux.dev>
List-Subscribe: <mailto:driver-core+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:driver-core+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMRc=McPez6Ver5NgrDPnM9YDb7cPonWE7BBsS_5AnY9tGf3xQ@mail.gmail.com>

On Mon, May 11, 2026 at 06:10:32AM -0700, Bartosz Golaszewski wrote:
> On Fri, 8 May 2026 12:54:41 +0200, Tzung-Bi Shih <tzungbi@kernel.org> said:
> > diff --git a/drivers/base/revocable_test.c b/drivers/base/revocable_test.c
> 
> Please move this under drivers/base/tests/ where the rest of kunit modules
> live and name it revocable-test.c for consistency with the existing ones.

Ack, I overlooked the folder.  Will move the test to drivers/base/test/ and
rename it in the next version.

> > +#include <kunit/test.h>
> 
> Add a newline here as do other kunit modules.

Ack, will fix it in the next version.