From: Yury Norov <ynorov@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, "Zhi Wang" <zhiw@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
nova-gpu@lists.linux.dev, driver-core@lists.linux.dev
Subject: Re: [PATCH v4 3/7] rust: bitfield: fully qualify types in macro
Date: Wed, 27 May 2026 16:51:37 -0400 [thread overview]
Message-ID: <ahdZWR7xTJYgamy_@yury> (raw)
In-Reply-To: <DITI5K1PSC3E.PEYYIBWQCW38@nvidia.com>
On Wed, May 27, 2026 at 10:44:16PM +0900, Alexandre Courbot wrote:
> On Wed May 27, 2026 at 10:24 PM JST, Miguel Ojeda wrote:
> > On Wed, May 27, 2026 at 2:52 PM Alexandre Courbot <acourbot@nvidia.com> wrote:
> >>
> >> These types were not fully qualified, which could cause issues if the
> >> local module shadows them.
> >>
> >> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> >
> > Should we fixup this into #1? (on apply maybe?)
> >
> > Similarly, for #2, I guess it may separate to give credit to Gary (?),
> > but typically we don't create extra commits if it is still not landed.
> >
> > Or what am I missing? Perhaps they are intended to show the changelog (?).
>
> The intent was to make #1 a pure code move - except that, upon actual
> inspection, it does not move the code but only extracts it, which weakens
> that argument.
>
> So yes, if you prefer it that way I agree that squashing #2 and #3 into
> #1 (with a description of the changes in the commit log) should be fine.
Both ways are OK for me. If you decide to merge the patches, can you
explicitly list everything that is not a plain move in the change log?
Acked-by: Yury Norov <yury.norov@gmail.com>
next prev parent reply other threads:[~2026-05-27 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 12:51 [PATCH v4 0/7] rust: add `bitfield!` macro Alexandre Courbot
2026-05-27 12:51 ` [PATCH v4 1/7] rust: extract `bitfield!` macro from `register!` Alexandre Courbot
2026-05-27 12:51 ` [PATCH v4 2/7] rust: bitfield: inline private accessors Alexandre Courbot
2026-05-27 12:51 ` [PATCH v4 3/7] rust: bitfield: fully qualify types in macro Alexandre Courbot
2026-05-27 13:24 ` Miguel Ojeda
2026-05-27 13:44 ` Alexandre Courbot
2026-05-27 20:51 ` Yury Norov [this message]
2026-05-27 12:51 ` [PATCH v4 4/7] rust: io: use the `bitfield!` macro in `register!` Alexandre Courbot
2026-05-27 12:51 ` [PATCH v4 5/7] gpu: nova-core: switch to kernel bitfield macro Alexandre Courbot
2026-05-27 12:52 ` [PATCH v4 6/7] gpu: nova-core: remove the driver-local `bitfield!` macro Alexandre Courbot
2026-05-27 12:52 ` [PATCH v4 7/7] rust: bitfield: Add KUnit tests for bitfield Alexandre Courbot
2026-05-27 20:48 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahdZWR7xTJYgamy_@yury \
--to=ynorov@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=driver-core@lists.linux.dev \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=yury.norov@gmail.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox