From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6016F3BE659; Thu, 25 Jun 2026 07:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782372293; cv=none; b=q6aI9pZ1O/uVGgd5h0AAEcEROTwna+xgB7MUaH8pFKLicxwDk+HEXjROClTeupmM6by7EC2vnp1sJWZ5884XBw+tiuKya7kDM4CMcyobaZytRk/tgxYi+FK1jBnhV+KpcrtcJJ+7bPiJN/p5m1yT+slhAQakvIoPO10AgJrZHeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782372293; c=relaxed/simple; bh=h5ocJXXKpSTKpkJaGKhd2kaVYd35m9dsl6aoMK/+5oE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fm08fW6aGgvSMSt2NRwGDWtsubFguFdFTeLV90g1tSBUp2y9RT63urwolbKDEp0ApBZpqWBn802biaZlRSuhxXlBY6Ofdx6qUGchtig58n64LPYy4zCS4o51ZJydpDBbpnt1sce2CNiCQm0JSxZp5jcyAvMQ3MHFQwYAsy/t2zE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QRAYCWCl; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QRAYCWCl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782372292; x=1813908292; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=h5ocJXXKpSTKpkJaGKhd2kaVYd35m9dsl6aoMK/+5oE=; b=QRAYCWClaWWmT0g9P6TAypLOZzFvncy+BvIxOEuk4bA1YVqYg2zUtDjp P3PXeyxa75KOYgv/JLtcqwTC5neQRaChaUb00Rg7iBtYKNSpcvHOsnRoe W5FLzzZto9+oAIjEGA6wAI+ZDQbSIEr5X70rT2zeuk9eyO2lM9qx1nfY7 NpjeJR02FnBPdl4jdCOXuaoZSMci7tR9QD6jPYHKnyPiO6B0SQH60DmPi 54zA9oPjije7/D4OIwq192xv66TpLK49dbV+J1OrKa+YjYlHTEU68+Woe b8G7HJxAx7DLo+6EsVm6D9Jzsfxt8b2KRerf28+OvfNdb1UXlGw5U+8f+ A==; X-CSE-ConnectionGUID: GtkPLiIQT9ipIVC4upQgGw== X-CSE-MsgGUID: FuCmainKRImCSYmspefAVw== X-IronPort-AV: E=McAfee;i="6800,10657,11827"; a="86822196" X-IronPort-AV: E=Sophos;i="6.24,224,1774335600"; d="scan'208";a="86822196" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2026 00:24:39 -0700 X-CSE-ConnectionGUID: hcztOcZrRiS2v4zjDIGV1g== X-CSE-MsgGUID: OEXbgkZkRPSxlt5KzXGeSw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,224,1774335600"; d="scan'208";a="244045858" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.106]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2026 00:24:34 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id F407111FAA5; Thu, 25 Jun 2026 10:24:33 +0300 (EEST) Date: Thu, 25 Jun 2026 10:24:33 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Laurent Pinchart Cc: Frank Li , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mauro Carvalho Chehab , Dafna Hirschfeld , Heiko Stuebner , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , driver-core@lists.linux.dev, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou , Frank Li , Guoniu Zhou Subject: Re: [PATCH v2 0/4] media: add and use fwnode_graph_for_each_endpoint_scoped() Message-ID: References: <20260624-fw_scoped-v2-0-0a8db472af4a@nxp.com> <20260624191935.GG851255@killaraus.ideasonboard.com> <20260624200237.GJ851255@killaraus.ideasonboard.com> <20260624222042.GN851255@killaraus.ideasonboard.com> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624222042.GN851255@killaraus.ideasonboard.com> Hi Laurent, On Thu, Jun 25, 2026 at 01:20:42AM +0300, Laurent Pinchart wrote: > On Wed, Jun 24, 2026 at 03:46:48PM -0500, Frank Li wrote: > > On Wed, Jun 24, 2026 at 11:02:37PM +0300, Laurent Pinchart wrote: > > > On Wed, Jun 24, 2026 at 02:35:14PM -0500, Frank Li wrote: > > > > On Wed, Jun 24, 2026 at 10:19:35PM +0300, Laurent Pinchart wrote: > > > > > On Wed, Jun 24, 2026 at 01:00:08PM -0400, Frank.Li@oss.nxp.com wrote: > > > > > > Add new helper macro fwnode_graph_for_each_endpoint_scoped() and use it > > > > > > simplify media code. > > > > > > > > > > > > Typical example should qualcomm's driver (camss.c), the v4l2_mc.c and > > > > > > rkisp1-dev.c only silience improvement. > > > > > > > > > > > > Anyways, *_for_each_*_scoped() already use widely and make code clean. > > > > > > > > > > > > Build test only. > > > > > > > > > > > > Sakari Ailus: > > > > > > when I try to improve the patch > > > > > > "Add common helper library for 1-to-1 subdev registration", I found need > > > > > > camss.c pattern, so I create this small improvement firstly. > > > > > > > > > > Those are nice cleanups, thank you. > > > > > > > > > > After applying this series, the only left users of the > > > > > fwnode_graph_for_each_endpoint() macro are in drivers/base/property.c. > > > > > > > > I already checked previously, two place use it. > > > > > > > > fwnode_graph_get_endpoint_count(), it will go though all endpoints, last > > > > ep is NULL, which totally equial to scoped() version. > > > > > > > > another one fwnode_graph_get_endpoint_by_id(), which return ep, expect > > > > caller to call put(). > > > > > > > > if use scoped() version, need use no_free_ptr() at return, which make think > > > > a little bit complex. > > > > > > It would introduce a tiny bit of extra complexity there, but the > > > advantage (in my opinion) is that we'll be able to remove the less safe > > > fwnode_graph_for_each_endpoint() macro. > > > > > > Now one may argue that the risk of > > > fwnode_graph_for_each_endpoint_scoped() is returning the iterator > > > without using no_free_ptr(). I wonder if that would be easier to catch > > > in static analysis tools than the current pattern that leaks a reference > > > when exiting the loop early. > > > > It's not big deal, if everyone prefer drop fwnode_graph_for_each_endpoint(), > > I can do it. > > Let's see what others think. If people prefer keeping both versions, > I'll be OK with that. I'd prefer to keep both: it depends on the use case which one is better. -- Kind regards, Sakari Ailus