From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39CD93D891D for ; Mon, 6 Jul 2026 20:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783368608; cv=none; b=J85qLupgbxrBBxLyqicjkAlBfTp1LEX+/d90g3ifkuDOu9P5YswX3GfAb22e8oLATCwlOuQ0DbOXWCRYXHVUyO7undValWx9zPMYwiZLjc3bkTD5j0LHXzBwKpfOeE4Zbkv3aCsRMyro9LWflXZk11SBBeqhvnx/+XQW5i+Kh4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783368608; c=relaxed/simple; bh=ldkS6quYL+wbZMXQEB4I2LyPcjr/4m8xDdI3braiYSk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l6SDsQdYMt2mQpU6/39m8+WA0pQ91O0ikMoCxJFB7EeHFJ1emWyprZNNElIM1paGLpfgdvJyXzzmWJadCJj5ugx1565uqfEf172qhEHJ/Y8Gv1gDUGIDMG8GnjFoSooNVlhPpTA9ue+9I9Tf9cVeCo/gz4b1Mxp2D1ZXOC3LHDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=k8aIQtaa; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="k8aIQtaa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783368608; x=1814904608; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ldkS6quYL+wbZMXQEB4I2LyPcjr/4m8xDdI3braiYSk=; b=k8aIQtaaTUkh3YkN9URH42N4MGXkDGMXAJVMavICzEFxHVR1KlySuN1S c7l8wN302iJMmeMCNVKSQEOsccbzldwrneb1F2FxveAIPMPzQPr0phHVl 22ijqxHdzxklnLpSEXOaCV91iv9f401TreLyYhttI27ZIBvDQRD3SgtiE Vi0wcjZq3uPmjK646QlSJ7BAb/C43yklUxLu52H46GPCsYDOBafKEqTY6 qn/0Ec1xKUz/tudbd50fvfZdz6DNxt6tr8anAuwrRPFX8+BnGXsWPX79o d6kHic7rVRXRwmGldkbeVjHY67zzxSvJsNjbWg8aq+FUmtl7PFfcLWpWW g==; X-CSE-ConnectionGUID: UCTSgkQgQ/y3YGSqyN4K/Q== X-CSE-MsgGUID: zwCUqaVWQf6Hn0XPzQN+FA== X-IronPort-AV: E=McAfee;i="6800,10657,11839"; a="95525124" X-IronPort-AV: E=Sophos;i="6.25,151,1779174000"; d="scan'208";a="95525124" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2026 13:10:07 -0700 X-CSE-ConnectionGUID: NkPn3f94R++QcuJuCLmE6w== X-CSE-MsgGUID: MZ/eYlPFRaeyA8oeT/40Vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,151,1779174000"; d="scan'208";a="257379314" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.244.48]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2026 13:10:02 -0700 Date: Mon, 6 Jul 2026 23:09:39 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Brendan Higgins , David Gow , Rae Moar , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Linus Walleij , Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 5/5] gpio: kunit: add test cases verifying swnode devlink support Message-ID: References: <20260629-swnode-fw-devlink-v1-0-b90058b41839@oss.qualcomm.com> <20260629-swnode-fw-devlink-v1-5-b90058b41839@oss.qualcomm.com> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jul 06, 2026 at 08:32:28AM -0400, Bartosz Golaszewski wrote: > On Mon, 29 Jun 2026 17:58:16 +0200, Andy Shevchenko > said: > > On Mon, Jun 29, 2026 at 12:52:10PM +0200, Bartosz Golaszewski wrote: ... > >> +static int gpio_probe_defer_consumer_probe(struct platform_device *pdev) > >> +{ > >> + struct device *dev = &pdev->dev; > >> + struct gpio_probe_defer_pdata *pdata = dev_get_platdata(dev); > >> + struct gpio_desc *desc; > > > >> + pdata->probe_count++; > > > > Even in case of error? > > We're counting how many times we *enter* probe, so yes, I think it's right. Perhaps a (short) comment on top of this line? /* Count probes independently on being successful or unsuccessful */ -- With Best Regards, Andy Shevchenko