Re: [PATCH] samples: rust_dma: use vertical import style

[Guru Das Srinagesh <linux@gurudas.dev>]

On Wed, Jul 08, 2026 at 09:37:33AM +0200, Link Mauve wrote:
> Hi,
> 
> On Sun, Jul 05, 2026 at 06:25:37PM -0700, Guru Das Srinagesh wrote:
> > Convert `use` imports to vertical layout for better readability and
> > maintainability.
> > 
> > Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
> > ---
> > Came across a recent commit bc58905eb07 ("samples: rust_misc_device: use
> > vertical import style") and found a few more locations that could
> > benefit from this cleanup. No functional changes.
> > 
> > Separating out patches per-subsystem as per the review feedback in [0].
> > 
> > Tested via:
> > 
> > 	$ make LLVM=1 rustfmtcheck || echo "fail"
> > 	$
> > 
> > [0]: https://lore.kernel.org/lkml/20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@gurudas.dev/
> > ---
> >  samples/rust/rust_dma.rs | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/samples/rust/rust_dma.rs b/samples/rust/rust_dma.rs
> > index 5046b4628d0e..c46af109f4aa 100644
> > --- a/samples/rust/rust_dma.rs
> > +++ b/samples/rust/rust_dma.rs
> > @@ -12,9 +12,13 @@
> >          Device,
> >          DmaMask, //
> >      },
> > -    page, pci,
> > +    page,
> > +    pci, //
> 
> Usually we put the empty comment at the very end of the imports, not in
> the middle.
> 
> >      prelude::*,
> > -    scatterlist::{Owned, SGTable},
> > +    scatterlist::{
> > +        Owned,
> > +        SGTable, //
> > +    },
> >      sync::aref::ARef,
> 
> So here:                 ↑
> 
> >  };

Done. Thank you very much for the review and suggestion.