From: Tejun Heo <tj@kernel.org>
To: Yichong Chen <chenyichong@uniontech.com>
Cc: gregkh@linuxfoundation.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernfs: avoid iattr allocation in listxattr
Date: Sun, 2 Aug 2026 09:42:28 -1000 [thread overview]
Message-ID: <am-dpITJWlNLIWRB@slm.duckdns.org> (raw)
In-Reply-To: <20260731120554.630147-1-chenyichong@uniontech.com>
On Fri, Jul 31, 2026 at 08:05:54PM +0800, Yichong Chen wrote:
> kernfs_iop_listxattr() only needs to report existing xattrs, but it uses
> kernfs_iattrs(), which allocates kernfs_iattrs when the node does not
> have one yet.
>
> This makes a query operation create persistent per-node metadata even
> when the xattr list is empty.
>
> Use kernfs_iattrs_noalloc() instead and return an empty list when no
> iattrs exist.
>
> Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2026-08-02 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 12:05 [PATCH] kernfs: avoid iattr allocation in listxattr Yichong Chen
2026-08-02 19:42 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am-dpITJWlNLIWRB@slm.duckdns.org \
--to=tj@kernel.org \
--cc=chenyichong@uniontech.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox