From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5959E40B36D for ; Tue, 25 Aug 2026 13:21:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787664065; cv=none; b=oCmqG+QCbBYMfD+DUj079/MSYIuNfwwGUqF4bWxHGMhw43HG39lie4LRHs4eanJRhy50xaGdrO+oXgHg3ElSrn0fZ6pAQEcpQ9d+BSNTi/nAQ69rGZ284PA0vJkZsH4XPZGnwweNoHhj62DR7wnyygtr0JFgiYX4lbuWd3NGNpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787664065; c=relaxed/simple; bh=dZXT/FK7+tblCR4etoX/B8DPZXP4pkVpPaPoQ4mCAI4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IVxbvxpf6VQ8757aiSRFiSayYl3yGFDQlSbT4y7/qMTtttVJijGVLP3SDCRVPy6cMoApAizJCc74zDBjvaN9ZifrIOq4P8SNCuL/bVJ1Udj6zBRfhxZkXJ6HxNL0chW7uGLwcHRK8XSub0ARtKVz+yPzAEcVEI1mENAwvud5mfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=X6Lh1r8k; arc=none smtp.client-ip=209.85.128.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="X6Lh1r8k" Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-496c06ba017so4509095e9.0 for ; Tue, 25 Aug 2026 06:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787664059; x=1788268859; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/wDF0hN/FW6BAXrcHvW79QxhTrkNJERnJhXR31M87d4=; b=X6Lh1r8kDHieF+m+erYSnzCgwM+3yVuja4De8hUyst/5O70H9d3AFujL/noEbC3ysi gb0pfYUE9G3znZsV2Yu6IGBrdSCIq4Zj3fUJOetHqQPacRApPyls1mluFYbvaFqOsv5e fC3RHH/bCnKgHx/l9nDQhRFrdTlSlaUMN09Tblt9ILeG71urso3opPI8wyq3zbQsVUSk FwRyCHBdcxGioSJKxxQuMmEf4o/AyV9DOJB9ND2FpCrIPcauEFSsijEIPPcKo8kNHB3j vT/2pguPj0l/VXi1pbtschjLDnafXTwq1kcIj6A3krRGMOyJflMBliinIUKsCD9iCIJU UsgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787664059; x=1788268859; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/wDF0hN/FW6BAXrcHvW79QxhTrkNJERnJhXR31M87d4=; b=d/uR5TABVt6Cku212gG+nOnYM3Fzdn9IXpPQkFvZ04raDiLv2yrIA+Q8RVoVzjISZX a2mJBi/lLo+7FZo5qs0ER6xX9hNPawQA4B3tYFWLzGwUDAmSw5nk4G9N2JgdFg8I/lkQ rkIK/WS799Gs0BxEnfZc2MRAECNtVOaff3R87YcSw4vyZ9WVl0NjKrWHJlnjlhyNxeRv u36NWEK41ZxPnGCDSBSICyK7VLf2hr7uDsYYGVRP6wn8dS7c4bkm0dHjlmLIQJQQS6M8 54v4yYT4RKXhZU8dWG4KusuRpt88a/oDZV629hfo3mdWWTkeJ0F/mQK+bWRu5X1yx447 ylcQ== X-Forwarded-Encrypted: i=1; AHgh+RowrMQScIpD8t0QSwP529Kgivo+4cjs+MukIdfL8UjJ9kJ0RVRGgdV8zF15fPQZgERcQbljbitPu/KKNA==@lists.linux.dev X-Gm-Message-State: AFuF++kAHf7WkcWQQA4ayCayK+unnaR5B9f2INPv5h5gjAvzS1a05rN/ SNyv9+adhGERV6c0H/27NmIjhgu9gKKTvENlwv7kKjaIrk64tbHP2Rj4BuU+2aWUmArRXBlPFsl ICCTL1IVqG4M2Hv7fgw== X-Received: from wmjs24.prod.google.com ([2002:a7b:c398:0:b0:499:9f79:18de]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4f89:b0:493:f783:c46a with SMTP id 5b1f17b1804b1-499d63308fbmr60648795e9.6.1787664058484; Tue, 25 Aug 2026 06:20:58 -0700 (PDT) Date: Tue, 25 Aug 2026 13:20:57 +0000 In-Reply-To: <20260824-unique-ref-v20-4-490735672187@kernel.org> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260824-unique-ref-v20-0-490735672187@kernel.org> <20260824-unique-ref-v20-4-490735672187@kernel.org> Message-ID: Subject: Re: [PATCH v20 4/8] rust: page: convert to `Ownable`' From: Alice Ryhl To: Andreas Hindborg Cc: Danilo Krummrich , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Trevor Gross , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , "Onur =?utf-8?B?w5Z6a2Fu?=" , Lyude Paul , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , "Rafael J. Wysocki" , Dave Ertman , Leon Romanovsky , Paul Moore , Serge Hallyn , David Airlie , Simona Vetter , Alexander Viro , Jan Kara , Igor Korotin , Viresh Kumar , Nishanth Menon , Stephen Boyd , Bjorn Helgaas , "Krzysztof =?utf-8?Q?Wilczy=C5=84ski?=" , Pavel Tikhomirov , Michal Wilczynski , Ira Weiny , Philipp Stanner , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, driver-core@lists.linux.dev, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org, Asahi Lina Content-Type: text/plain; charset="utf-8" On Mon, Aug 24, 2026 at 01:17:56PM +0200, Andreas Hindborg wrote: > + // SAFETY: We just successfully allocated a page, so we now have ownership of the newly > + // allocated page. We transfer that ownership to the new `Owned` object. > + // Since `Page` is transparent, we can cast the pointer directly. > + Ok(unsafe { Owned::from_raw(page.cast()) }) This doesn't satisfy the safety requirements of Owned::from_raw() because the page may be used with vm_insert_page(), which increments its refcount and causes it to be shared the vma system, and this occurs before Page::release() is called. Alice