From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pavol Sakac <sakacpav@amazon.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
Xu Yang <xu.yang_2@nxp.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Alex Williamson <alex@shazbot.org>,
kvm@vger.kernel.org, nh-open-source@amazon.com
Subject: Re: [RFC PATCH 5/8] drivers: base: test: Add KUnit suite for staged sysfs registration
Date: Sat, 12 Sep 2026 16:14:59 +0300 [thread overview]
Message-ID: <aqVQU6hbDPE5zOm-@ashevche-desk.local> (raw)
In-Reply-To: <20260911174414.97060-5-sakacpav@amazon.de>
On Fri, Sep 11, 2026 at 07:43:37PM +0200, Pavol Sakac wrote:
> Add a staged_device KUnit suite under its own
> CONFIG_STAGED_DEVICE_KUNIT_TEST symbol exercising the staged mechanism.
> kobject_add() on a kobject with ->sd_staged builds the directory staged
> but does not publish it, since only device_add() does, so the tests
> drive the window directly: stage, then populate and observe, then
> sysfs_publish_dir(). The cases cover publication of plain, named-group
> and merged-group content, the failure modes of publication itself, abort
> without publication, foreign-thread access, concurrent windows including
> two that share one hashed staged mutex, glue-directory sharing, and
> bus-klist membership by the time device_add() returns. The suite also
> covers the KERNFS_STAGED_TOP/KERNFS_HAS_MMAP aliasing on a staged
> mmap-capable bin file.
>
> The publication-misuse cases intentionally trigger the publication
> guards' WARN backtraces, and the duplicate-name cases trigger
> sysfs_warn_dup() splats: those backtraces are expected output of a
> passing run, not failures. The suite is therefore unsuitable for
> runners that set panic_on_warn, which turns the first intentional splat
> into a panic, and does not follow KUNIT_ALL_TESTS: it runs only when its
> symbol is enabled explicitly.
...
> drivers/base/test/.kunitconfig | 1 +
Same question, why is this file got modified?
...
> +++ b/drivers/base/test/.kunitconfig
> @@ -1,3 +1,4 @@
> CONFIG_KUNIT=y
> CONFIG_DM_KUNIT_TEST=y
> CONFIG_GLUE_DIR_KUNIT_TEST=y
> +CONFIG_STAGED_DEVICE_KUNIT_TEST=y
It seems this series is based on some other series?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-12 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 17:43 [RFC PATCH 0/8] kernfs, driver core: staged sysfs registration Pavol Sakac
2026-09-11 17:43 ` [RFC PATCH 1/8] kernfs: factor out reusable directory helpers Pavol Sakac
2026-09-11 17:43 ` [RFC PATCH 2/8] kernfs: add staged directory creation and publication Pavol Sakac
2026-09-11 17:43 ` [RFC PATCH 3/8] sysfs: add opt-in " Pavol Sakac
2026-09-11 17:43 ` [RFC PATCH 4/8] driver core: Register opted-in devices through the staged sysfs path Pavol Sakac
2026-09-11 17:43 ` [RFC PATCH 5/8] drivers: base: test: Add KUnit suite for staged sysfs registration Pavol Sakac
2026-09-12 13:14 ` Andy Shevchenko [this message]
2026-09-11 17:43 ` [RFC PATCH 6/8] driver core: Defer uevents for devices registered in a staged window Pavol Sakac
2026-09-12 13:20 ` Andy Shevchenko
2026-09-11 17:43 ` [RFC PATCH 7/8] PCI/IOV: Register virtual functions through the staged sysfs path Pavol Sakac
2026-09-11 17:43 ` [RFC PATCH 8/8] vfio: Opt the group and vfio-dev class devices into staged sysfs Pavol Sakac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqVQU6hbDPE5zOm-@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=alex@shazbot.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nh-open-source@amazon.com \
--cc=rafael@kernel.org \
--cc=sakacpav@amazon.de \
--cc=tj@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox