From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.142.180.65 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794306112; b=GwqXZS2/NBMKBrVUoGeznsc2nxJJoj3dZrqjvrVTlKKu5kNz2zww5WIIWQRIxq6sfa1j Pes4vX2zzzDC1dgASh9AG/WZkRqBcmVNcAeyJv7ZmP+BDNXx5jIfXWFSHX7UoTQbvZhJ3 iqtT11ZDYbqjKXlV+xznLuMFr3Au2Cjak5wKJnxrjMNw9cgV9V77e736u4ukBl2yJmqwV eH0UVk4w7zoJCSTn/NySLWlF9/LDQJlZspmV592hKSSt7nxLgURx+3+nji1iEQWDcN9bW V3bdD5A3RhAJUTeSdihBW1MFRYJ38xIiIuXdcPWaTJHTH+H1rkAQJZlqzHyg2m+7hrA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794306112; h=DMARC-Filter:Received:Date:From:To:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=4RjiHFSGtFGI5JfcAYv07qfSKq6xK83qO3wQQHxqTEI=; b=QRNgOgffZTAC8DBu1/ND4wGeFW4fAAXuU2e79AhETK9XDQhr1IqHVhzhB/1H2AMlyOts 2l2k+QTQtE9tgc9NEpPeOBQcKDup3AHMkPu/wQ4NeaIxvTEeCmBrmGCGYzCwMqCXT6+QL jh7DpsoFS9YjmL57IsjDwecLO6Zn56kzx2DU1PcjsD8/RpPz06M+tbc1XDl+xkTbdJ59G t6T48umfZFeFnRrvgrpKQQ3Epawrk5KI/TPeaqOi7y9+n8h4NbgRApPfLvQ43cVV1Kolc YeZAt+ikRYLnsOJFJSltaFdUBTnslaZ+gNbU19CVe2hnxUc3jwkCTCyWUU5f2YXpsrw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.remote-ip=185.142.180.65 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF373606DE26 for ; Tue, 10 Nov 2026 10:21:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BF373606DE26 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256:X25519MLKEM768) (Exim 4.100.1) (envelope-from ) id 1xQimM-000000006so-27Tz; Tue, 10 Nov 2026 10:21:42 +0000 Date: Tue, 10 Nov 2026 10:21:35 +0000 From: Daniel Golle To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Marcel Holtmann , Luiz Augusto von Dentz , Miri Korenblit , Emmanuel Grumbach , Hans de Goede , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v4 0/4] device_schedule_reprobe(): core helper and conversions Message-ID: References: X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Greg, On Sat, Oct 17, 2026 at 09:55:17AM +0100, Daniel Golle wrote: > iwlwifi and hci_h5 re-probe their own device from a work item in module > text ending in module_put(THIS_MODULE), which a concurrent rmmod can > race, and nothing ties the re-probe to the binding that asked for it. > btintel_pcie re-probes synchronously from its own reset work. This > series adds device_schedule_reprobe() to the driver core and converts > all three. > > Tested on an Intel AX101 with patches 1 to 3, PROVE_LOCKING and > DEBUG_OBJECTS_WORK: a re-probe, and an unbind, rmmod, PCI removal, > suspend and reboot with one pending. The unbind and the removals > cancelled it, and it ran after resume. The stock iwlwifi code undid > the unbind, and rmmod with its work held just past module_put() oopsed > in lockdep. Patches 3 and 4 are untested for lack of hardware. Now that the most hardcore merge-window ever is over and v7.4-rc1 is out, can you take a look at this? The series has received positive feedback and was tested by some more of the bluetooth folks by now, and is immediately useful to address currently buggy behavior of existing popular driver, and prevent the same wrong pattern from being duplicated into new drivers. Cheers Daniel