From: John Garry <john.g.garry@oracle.com>
To: David Jeffery <djeffery@redhat.com>
Cc: bvanassche@acm.org, linux-kernel@vger.kernel.org,
driver-core@lists.linux.dev, linux-pci@vger.kernel.org,
linux-scsi@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Tarun Sahu" <tarunsahu@google.com>,
"Pasha Tatashin" <tatashin@google.com>,
"Michał Cłapiński" <mclapinski@google.com>,
"Jordan Richards" <jordanrichards@google.com>,
"Ewan Milne" <emilne@redhat.com>,
"John Meneghini" <jmeneghi@redhat.com>,
"Lombardi, Maurizio" <mlombard@redhat.com>,
"Stuart Hayes" <stuart.w.hayes@gmail.com>,
"Laurence Oberman" <loberman@redhat.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 5/5] scsi: enable async shutdown support
Date: Thu, 9 Apr 2026 13:17:39 +0100 [thread overview]
Message-ID: <c9af1723-550c-4f2b-aa04-3ce769bb4a84@oracle.com> (raw)
In-Reply-To: <CA+-xHTFdKaCCwkytXpWdvp6vZ4ZCh+Pp8wzkoVZYPOy--CjiSw@mail.gmail.com>
On 08/04/2026 20:35, David Jeffery wrote:
>> Well it is not exactly like that. We have the following:
>>
>> scsi_sysfs_add_sdev() -> device_enable_async_suspend(&sdev->sdev_gendev)
>>
>> and
>>
>> scsi_sysfs_device_initialize() ->
>> scsi_enable_async_suspend(&sdev->sdev_gendev) ->
>> device_enable_async_suspend(&sdev->sdev_gendev) when not async
>>
>> Maybe similar needs to be done for this shutdown feature. AFICS, Bart,
>> added scsi_enable_async_suspend(), so maybe he can comment.
>>
> My inclination is to drop adding device_enable_async_shutdown into
> scsi_sysfs_device_initialize. The intent is for normal scsi devices,
> and I see little value in setting the flag so early to flag partially
> initialized or pseudo devices.
That seems reasonable, but, again I am not so familiar with this async
suspend and shutdown.
Thanks!
next prev parent reply other threads:[~2026-04-09 12:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 15:35 [PATCH v13 0/5] shut down devices asynchronously David Jeffery
2026-04-07 15:35 ` [PATCH 1/5] driver core: separate function to shutdown one device David Jeffery
2026-04-07 15:35 ` [PATCH 2/5] driver core: do not always lock parent in shutdown David Jeffery
2026-04-07 15:35 ` [PATCH 3/5] driver core: async device shutdown infrastructure David Jeffery
2026-04-07 15:35 ` [PATCH 4/5] PCI: Enable async shutdown support David Jeffery
2026-04-07 15:35 ` [PATCH 5/5] scsi: enable " David Jeffery
2026-04-07 16:34 ` John Garry
2026-04-08 14:16 ` David Jeffery
2026-04-08 15:53 ` John Garry
2026-04-08 19:35 ` David Jeffery
2026-04-09 12:17 ` John Garry [this message]
2026-04-09 20:36 ` David Jeffery
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 14:11 [PATCH v12 0/5] shut down devices asynchronously David Jeffery
2026-03-19 14:11 ` [PATCH 5/5] scsi: enable async shutdown support David Jeffery
2026-03-20 2:20 ` Martin K. Petersen
2026-03-11 17:12 [PATCH 1/5] driver core: do not always lock parent in shutdown David Jeffery
2026-03-11 17:12 ` [PATCH 5/5] scsi: enable async shutdown support David Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9af1723-550c-4f2b-aa04-3ce769bb4a84@oracle.com \
--to=john.g.garry@oracle.com \
--cc=bvanassche@acm.org \
--cc=dakr@kernel.org \
--cc=djeffery@redhat.com \
--cc=driver-core@lists.linux.dev \
--cc=emilne@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=jordanrichards@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=mclapinski@google.com \
--cc=mlombard@redhat.com \
--cc=rafael@kernel.org \
--cc=stuart.w.hayes@gmail.com \
--cc=tarunsahu@google.com \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox