From: Alan Maguire <alan.maguire@oracle.com>
To: dtrace@lists.linux.dev
Cc: dtrace-devel@oss.oracle.com, Alan Maguire <alan.maguire@oracle.com>
Subject: [PATCH v3 dtrace 1/4] dt_provider_tp: add optional event data, freed on tp free
Date: Wed, 16 Oct 2024 16:54:06 +0100 [thread overview]
Message-ID: <20241016155409.4038017-2-alan.maguire@oracle.com> (raw)
In-Reply-To: <20241016155409.4038017-1-alan.maguire@oracle.com>
It will be used to store suffixed function name for kprobe attach to
"foo.isra.0"-style functions. Such functions use the unsuffixed form
as probe name, so we need to store the full function name to support
attach.
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
libdtrace/dt_provider_tp.c | 27 +++++++++++++++++++++++++++
libdtrace/dt_provider_tp.h | 8 ++++++++
2 files changed, 35 insertions(+)
diff --git a/libdtrace/dt_provider_tp.c b/libdtrace/dt_provider_tp.c
index 50df2328..fc3c216a 100644
--- a/libdtrace/dt_provider_tp.c
+++ b/libdtrace/dt_provider_tp.c
@@ -33,6 +33,7 @@
struct tp_probe {
uint32_t event_id; /* tracepoint event id or BTF id */
int event_fd; /* tracepoint perf event fd */
+ void *event_data; /* optional data */
};
/*
@@ -313,6 +314,8 @@ dt_tp_detach(dtrace_hdl_t *dtp, tp_probe_t *tpp)
void
dt_tp_destroy(dtrace_hdl_t *dtp, tp_probe_t *tpp)
{
+ if (tpp && tpp->event_data)
+ free(tpp->event_data);
dt_free(dtp, tpp);
}
@@ -334,6 +337,30 @@ dt_tp_probe_insert(dtrace_hdl_t *dtp, dt_provider_t *prov, const char *prv,
return dt_probe_insert(dtp, prov, prv, mod, fun, prb, tpp);
}
+dt_probe_t *
+dt_tp_probe_insert_data(dtrace_hdl_t *dtp, dt_provider_t *prov, const char *prv,
+ const char *mod, const char *fun, const char *prb,
+ void *data)
+{
+ tp_probe_t *tpp;
+
+ dt_probe_t *prp = dt_tp_probe_insert(dtp, prov, prv, mod, fun, prb);
+
+ if (prp) {
+ tpp = prp->prv_data;
+ tpp->event_data = data;
+ }
+ return prp;
+}
+
+void *
+dt_tp_get_event_data(const dt_probe_t *prp)
+{
+ tp_probe_t *tpp = prp->prv_data;
+
+ return tpp->event_data;
+}
+
uint32_t
dt_tp_get_event_id(const dt_probe_t *prp)
{
diff --git a/libdtrace/dt_provider_tp.h b/libdtrace/dt_provider_tp.h
index e7d52876..66a9bd80 100644
--- a/libdtrace/dt_provider_tp.h
+++ b/libdtrace/dt_provider_tp.h
@@ -41,6 +41,14 @@ extern struct dt_probe *dt_tp_probe_insert(dtrace_hdl_t *dtp,
dt_provider_t *prov,
const char *prv, const char *mod,
const char *fun, const char *prb);
+extern struct dt_probe *dt_tp_probe_insert_data(dtrace_hdl_t *dtp,
+ dt_provider_t *prov,
+ const char *prv,
+ const char *mod,
+ const char *fun,
+ const char *prb,
+ void *data);
+extern void *dt_tp_get_event_data(const struct dt_probe *prp);
extern uint32_t dt_tp_get_event_id(const struct dt_probe *prp);
extern void dt_tp_set_event_id(const struct dt_probe *prp, uint32_t id);
extern int dt_tp_probe_info(dtrace_hdl_t *dtp, FILE *f, int skip,
--
2.43.5
next prev parent reply other threads:[~2024-10-16 15:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 15:54 [PATCH v3 dtrace 0/4] kprobe support for .isra.0, sched fix Alan Maguire
2024-10-16 15:54 ` Alan Maguire [this message]
2024-11-14 5:26 ` [DTrace-devel] [PATCH v3 dtrace 1/4] dt_provider_tp: add optional event data, freed on tp free Kris Van Hees
2024-11-14 16:45 ` Alan Maguire
2024-10-16 15:54 ` [PATCH v3 dtrace 2/4] fbt: support "."-suffixed functions for kprobes Alan Maguire
2024-11-28 2:22 ` Kris Van Hees
2024-11-28 9:58 ` Alan Maguire
2024-10-16 15:54 ` [PATCH v3 dtrace 3/4] fbt: avoid mix of kprobe, fprobe implementations for used probes Alan Maguire
2024-10-16 15:54 ` [PATCH v3 dtrace 4/4] sched: fix on-cpu firing for kernels < 5.16 Alan Maguire
2024-10-18 15:41 ` [PATCH v3 dtrace 0/4] kprobe support for .isra.0, sched fix Kris Van Hees
2024-10-18 16:15 ` Alan Maguire
2024-10-18 18:38 ` Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016155409.4038017-2-alan.maguire@oracle.com \
--to=alan.maguire@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox