public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: eugene.loh@oracle.com
To: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: [PATCH 1/2] test: Clean up tst.specopen.d
Date: Mon, 28 Oct 2024 14:33:33 -0400	[thread overview]
Message-ID: <20241028183334.22140-1-eugene.loh@oracle.com> (raw)

From: Eugene Loh <eugene.loh@oracle.com>

The test does not do much.  Mostly, it is a speculation demo.
It just needed some syntactical cleanup to pass.

Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
---
 test/demo/spec/specopen.d | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/test/demo/spec/specopen.d b/test/demo/spec/specopen.d
index c510045b8..700bdd9ff 100644
--- a/test/demo/spec/specopen.d
+++ b/test/demo/spec/specopen.d
@@ -7,10 +7,7 @@
  * http://oss.oracle.com/licenses/upl.
  */
 
-/* @@runtest-opts: $_pid */
-/* @@xfail: fbt provider not yet implemented; needs a trigger with failing open()s */
-
-syscall::open:entry,
+syscall::open:entry
 {
 	/*
 	 * The call to speculation() creates a new speculation.  If this fails,
@@ -38,7 +35,7 @@ fbt:::
 	speculate(self->spec);
 }
 
-syscall::open:return,
+syscall::open:return
 /self->spec/
 {
 	/*
@@ -51,7 +48,7 @@ syscall::open:return,
 	trace(errno);
 }
 
-syscall::open:return,
+syscall::open:return
 /self->spec && errno != 0/
 {
 	/*
@@ -61,7 +58,7 @@ syscall::open:return,
 	self->spec = 0;
 }
 
-syscall::open:return,
+syscall::open:return
 /self->spec && errno == 0/
 {
 	/*
-- 
2.43.5


             reply	other threads:[~2024-10-28 18:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 18:33 eugene.loh [this message]
2024-10-28 18:33 ` [PATCH 2/2] test: Remove misformatted and incorrect @@xfail eugene.loh
2024-10-28 18:45   ` Kris Van Hees
2024-10-28 18:44 ` [PATCH 1/2] test: Clean up tst.specopen.d Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028183334.22140-1-eugene.loh@oracle.com \
    --to=eugene.loh@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox