public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Cc: sam@gentoo.org
Subject: [PATCH v2 00/14] gentoo, manpage, and assorted other small fixes
Date: Mon, 28 Oct 2024 21:17:49 +0000	[thread overview]
Message-ID: <20241028211803.458685-1-nick.alcock@oracle.com> (raw)

Most of these are bugs reported by Gentoo, but their request for a
dtprobed(8) manpage triggered a sweep of the dtrace manpage too, plus
a fix to a rather unfortunate millisecs-versus-sedcs bug which caused
us to wait for an hour and a half for a dtprobed parser child timeout
rather than the intended five seconds.

The only potentially contentious ones are libsystemd (quite a lot of
code, and not ours, but it's BSD-0-licensed and I took out the most
ridiculously overkill parts), and the last two, which drop apparently
redundant markup from the manpages whose purpose I'm not clear on but
which seems to be ancient and is probably working around bugs in old
Solaris troff or something. We can probably assume groff by this point,
it's been the only maintained troff for decades.

Changes since v1:
  Review comment adjustments, and replacement of the INT_MAX
  dt_probe_lookup2() fix with something rather more comprehensive

Many of these have already been reviewed and have a reviewed-by: I
assume having the whole series reposted is nonetheless clearer
(I can post only the non-reviewed-by:ed parts in future if you
prefer).

Nick Alcock (14):
  No longer depend on libsystemd
  pkgconfig: drop spaces in variable decls
  configure, build: make valgrind optional
  build: substitute LIBDIR in pkg-config files
  probe: improve dt_probe_lookup2()
  configure: fix dreadful behaviour of MANDIR / --mandir
  man: the synopsis is ended with .YS, not .SY
  man: use \- for option dashes, not -
  man: drop blank lines
  man: fix blank line in environment variables list
  dtprobed: fix parser child timeout
  man: add manpage for dtprobed(8)
  man: drop double-\fB at the start of every option line
  man: \fP-ize

 GNUmakefile              |   3 +-
 Makeconfig               |  37 +++++++++-
 cmd/Build                |   2 +-
 cmd/dtrace.8             | 151 ++++++++++++++++++++-------------------
 configure                |  11 ++-
 dtprobed/Build           |   9 +--
 dtprobed/dtprobed.8      |  64 +++++++++++++++++
 dtprobed/dtprobed.c      |  10 +--
 include/port.h           |   1 +
 libdtrace/dt_impl.h      |   2 +
 libdtrace/dt_probe.c     |  44 ++++--------
 libdtrace/dt_subr.c      |  10 +++
 libdtrace/dt_work.c      |  16 ++++-
 libport/Build            |   4 +-
 libport/systemd_notify.c |  70 ++++++++++++++++++
 uts/Build                |   1 +
 uts/dtrace.pc.in         |   6 +-
 uts/dtrace_sdt.pc.in     |   4 +-
 18 files changed, 310 insertions(+), 135 deletions(-)
 create mode 100644 dtprobed/dtprobed.8
 create mode 100644 libport/systemd_notify.c


base-commit: 8a1264bf0e818c8624be250eb5174714b62ed93c
-- 
2.46.0.278.g36e3a12567


             reply	other threads:[~2024-10-28 21:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 21:17 Nick Alcock [this message]
2024-10-28 21:17 ` [PATCH v2 01/14] No longer depend on libsystemd Nick Alcock
2024-10-29 18:27   ` Kris Van Hees
2024-10-29 21:51     ` Nick Alcock
2024-10-28 21:17 ` [PATCH v2 02/14] pkgconfig: drop spaces in variable decls Nick Alcock
2024-10-28 21:17 ` [PATCH v2 03/14] configure, build: make valgrind optional Nick Alcock
2024-10-28 21:17 ` [PATCH v2 04/14] build: substitute LIBDIR in pkg-config files Nick Alcock
2024-10-28 21:17 ` [PATCH v2 05/14] probe: improve dt_probe_lookup2() Nick Alcock
2024-10-29 19:50   ` [DTrace-devel] " Kris Van Hees
2024-10-29 21:57     ` Nick Alcock
2024-10-28 21:17 ` [PATCH v2 06/14] configure: fix dreadful behaviour of MANDIR / --mandir Nick Alcock
2024-10-28 21:17 ` [PATCH v2 07/14] man: the synopsis is ended with .YS, not .SY Nick Alcock
2024-10-28 21:17 ` [PATCH v2 08/14] man: use \- for option dashes, not - Nick Alcock
2024-10-28 21:17 ` [PATCH v2 09/14] man: drop blank lines Nick Alcock
2024-10-28 21:17 ` [PATCH v2 10/14] man: fix blank line in environment variables list Nick Alcock
2024-10-28 21:18 ` [PATCH v2 11/14] dtprobed: fix parser child timeout Nick Alcock
2024-10-28 21:18 ` [PATCH v2 12/14] man: add manpage for dtprobed(8) Nick Alcock
2024-10-29 21:19   ` Kris Van Hees
2024-10-28 21:18 ` [PATCH v2 13/14] man: drop double-\fB at the start of every option line Nick Alcock
2024-10-28 21:18 ` [PATCH v2 14/14] man: \fP-ize Nick Alcock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028211803.458685-1-nick.alcock@oracle.com \
    --to=nick.alcock@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox