From: Nick Alcock <nick.alcock@oracle.com>
To: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Cc: sam@gentoo.org, Kris Van Hees <kris.van.hees@oracle.com>
Subject: [PATCH v2 04/14] build: substitute LIBDIR in pkg-config files
Date: Mon, 28 Oct 2024 21:17:53 +0000 [thread overview]
Message-ID: <20241028211803.458685-5-nick.alcock@oracle.com> (raw)
In-Reply-To: <20241028211803.458685-1-nick.alcock@oracle.com>
/usr/share/pkgconfig/dtrace.pc says
libdir = @LIBDIR@
/* ... */
Libs: -L${libdir} -ldtrace
which is unlikely to work.
Fix by substituting LIBDIR properly.
(I looked at these pkg-config files after installation I don't know how many
times and never once spotted this incredibly obvious problem.)
Bug: https://github.com/oracle/dtrace-utils/issues/104
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
---
uts/Build | 1 +
1 file changed, 1 insertion(+)
diff --git a/uts/Build b/uts/Build
index 181819410624..65ddc39845c1 100644
--- a/uts/Build
+++ b/uts/Build
@@ -37,6 +37,7 @@ install::
(cd $(uts_DIR) && \
sed -e 's,@SDTINCLUDEDIR@,$(SDTINCLUDEDIR),g;' \
-e 's,@INCLUDEDIR@,$(INCLUDEDIR),g;' \
+ -e 's,@LIBDIR@,$(LIBDIR),g;' \
-e 's,@VERSION@,$(VERSION),g;' \
-e 's,@DTRACE@,$(SBINDIR)/dtrace,g' < \
$${name}.in > $(INSTPKGCONFIGDIR)/$$name;) \
--
2.46.0.278.g36e3a12567
next prev parent reply other threads:[~2024-10-28 21:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 21:17 [PATCH v2 00/14] gentoo, manpage, and assorted other small fixes Nick Alcock
2024-10-28 21:17 ` [PATCH v2 01/14] No longer depend on libsystemd Nick Alcock
2024-10-29 18:27 ` Kris Van Hees
2024-10-29 21:51 ` Nick Alcock
2024-10-28 21:17 ` [PATCH v2 02/14] pkgconfig: drop spaces in variable decls Nick Alcock
2024-10-28 21:17 ` [PATCH v2 03/14] configure, build: make valgrind optional Nick Alcock
2024-10-28 21:17 ` Nick Alcock [this message]
2024-10-28 21:17 ` [PATCH v2 05/14] probe: improve dt_probe_lookup2() Nick Alcock
2024-10-29 19:50 ` [DTrace-devel] " Kris Van Hees
2024-10-29 21:57 ` Nick Alcock
2024-10-28 21:17 ` [PATCH v2 06/14] configure: fix dreadful behaviour of MANDIR / --mandir Nick Alcock
2024-10-28 21:17 ` [PATCH v2 07/14] man: the synopsis is ended with .YS, not .SY Nick Alcock
2024-10-28 21:17 ` [PATCH v2 08/14] man: use \- for option dashes, not - Nick Alcock
2024-10-28 21:17 ` [PATCH v2 09/14] man: drop blank lines Nick Alcock
2024-10-28 21:17 ` [PATCH v2 10/14] man: fix blank line in environment variables list Nick Alcock
2024-10-28 21:18 ` [PATCH v2 11/14] dtprobed: fix parser child timeout Nick Alcock
2024-10-28 21:18 ` [PATCH v2 12/14] man: add manpage for dtprobed(8) Nick Alcock
2024-10-29 21:19 ` Kris Van Hees
2024-10-28 21:18 ` [PATCH v2 13/14] man: drop double-\fB at the start of every option line Nick Alcock
2024-10-28 21:18 ` [PATCH v2 14/14] man: \fP-ize Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028211803.458685-5-nick.alcock@oracle.com \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox