From: Nick Alcock <nick.alcock@oracle.com>
To: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Cc: Kris Van Hees <kris.van.hees@oracle.com>
Subject: [PATCH v5 6/6] usdt: fix create_underlying error path
Date: Tue, 5 Nov 2024 00:06:08 +0000 [thread overview]
Message-ID: <20241105000608.333229-7-nick.alcock@oracle.com> (raw)
In-Reply-To: <20241105000608.333229-1-nick.alcock@oracle.com>
On error, we were destroying the underlying probe using the wrong call,
as if it were an overlying probe.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
---
libdtrace/dt_prov_uprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libdtrace/dt_prov_uprobe.c b/libdtrace/dt_prov_uprobe.c
index 28f5351be21a..5882644e03e9 100644
--- a/libdtrace/dt_prov_uprobe.c
+++ b/libdtrace/dt_prov_uprobe.c
@@ -716,7 +716,7 @@ static dt_probe_t *create_underlying(dtrace_hdl_t *dtp,
fail:
dt_dprintf("Failed to instantiate %s:%s:%s:%s\n", psp->pps_prv,
psp->pps_mod, psp->pps_fn, psp->pps_prb);
- probe_destroy(dtp, upp);
+ probe_destroy_underlying(dtp, upp);
return NULL;
}
--
2.46.0.278.g36e3a12567
prev parent reply other threads:[~2024-11-05 0:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 0:06 [PATCH v5 0/6] usdt typed args, translators and arg mapping Nick Alcock
2024-11-05 0:06 ` [PATCH v5 1/6] usdt: get arg types and xlations into DTrace from the DOF Nick Alcock
2024-11-05 16:56 ` Kris Van Hees
2024-11-05 18:01 ` [DTrace-devel] " Kris Van Hees
2024-11-05 19:53 ` Nick Alcock
2024-11-05 0:06 ` [PATCH v5 2/6] dtprobed: stop skipping zero-tracepoint probes in dof_stash.c Nick Alcock
2024-11-05 0:06 ` [PATCH v5 3/6] cg: add argument mapping in the trampoline Nick Alcock
2024-11-05 17:29 ` Kris Van Hees
2024-11-05 19:58 ` Nick Alcock
2024-11-05 0:06 ` [PATCH v5 4/6] usdt: typed args and arg mapping Nick Alcock
2024-11-05 18:53 ` Kris Van Hees
2024-11-06 11:16 ` Nick Alcock
2024-11-06 22:18 ` Kris Van Hees
2024-11-05 0:06 ` [PATCH v5 5/6] usdt: new tests for USDT arg sanity with overlapping pid probes Nick Alcock
2024-11-05 0:06 ` Nick Alcock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105000608.333229-7-nick.alcock@oracle.com \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox