Re: [DTrace-devel] [PATCH v2] test: stack_fbt

Eugene Loh
2024-11-20T20:28:47Z

On 11/20/24 14:22, Kris Van Hees wrote:

> On Thu, Nov 07, 2024 at 06:28:41PM -0500, eugene.loh--- via DTrace-devel wrote:
>> From: Eugene Loh <eugene.loh@oracle.com>
>>
>> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
>
> ... with small changes as shown below.
>
>> diff --git a/test/unittest/stack/tst.stack_fbt.sh b/test/unittest/stack/tst.stack_fbt.sh
>> new file mode 100755
>> @@ -0,0 +1,122 @@
>> +#!/bin/bash
>> +#
>> +# This test verifies the nusdtprobes option.
> Surely this is a copy'n'paste error and should be removed?

Goodness.  Yes.  Good thing that at least one of us is reading this
stuff!  Oops.

> Or rather, it
> should be replaced with a message that actually states what this test
> exercises/verifies?
>
> Shall I make it:
>
> Test the stack action with default stack depth and depth 3.

Thanks.  Well put.

>> +
>> +dtrace=$1
>> +
>> +# Set up test directory.
>> +
>> +DIRNAME=$tmpdir/stack_fbt.$$.$RANDOM
>> +mkdir -p $DIRNAME
>> +cd $DIRNAME
>> +
>> +# Use DTrace to capture stack() at vfs_write:entry.
>> +
>> +$dtrace $dt_flags $nusdt -wqn '
> I assume $nusdt should not be used here.

Sigh.  Right.