public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: eugene.loh@oracle.com
To: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: [PATCH 1/6] Convert ip6_finish_output to rawfbt
Date: Fri,  5 Sep 2025 13:07:14 -0400	[thread overview]
Message-ID: <20250905170715.11981-1-eugene.loh@oracle.com> (raw)

From: Eugene Loh <eugene.loh@oracle.com>

With commit fe2101e55 ("fbt: implement based on fentry/fexit probes")
test/unittest/ip/tst.ipv6localicmp.sh started to fail.  The problem
appears to be that fbt::ip6_finish_output:entry, which is needed for
ip:::send, does not fire.

Use rawfbt for this probe to revert back to kprobes in this case.

Other fbt probes may also be impacted, but this case showed up in testing.

Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
---
 libdtrace/dt_prov_ip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libdtrace/dt_prov_ip.c b/libdtrace/dt_prov_ip.c
index e0919806..5384346b 100644
--- a/libdtrace/dt_prov_ip.c
+++ b/libdtrace/dt_prov_ip.c
@@ -25,7 +25,7 @@ static probe_dep_t	probes[] = {
 	{ "send",
 	  DTRACE_PROBESPEC_NAME,	"fbt::ip_finish_output:entry" },
 	{ "send",
-	  DTRACE_PROBESPEC_NAME,	"fbt::ip6_finish_output:entry" },
+	  DTRACE_PROBESPEC_NAME,	"rawfbt::ip6_finish_output:entry" },
 	{ NULL, }
 };
 
-- 
2.47.3


             reply	other threads:[~2025-09-05 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 17:07 eugene.loh [this message]
2025-09-05 17:07 ` [PATCH] test: Update DTrace version string eugene.loh
2025-09-11 20:49   ` [DTrace-devel] " Kris Van Hees
2025-09-05 17:08 ` [PATCH 1/6] Convert ip6_finish_output to rawfbt Eugene Loh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250905170715.11981-1-eugene.loh@oracle.com \
    --to=eugene.loh@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox