Re: [PATCH 01/20] Fix comment since pkt_addr is not NULL

Kris Van Hees
2025-10-07T15:28:57Z

On Fri, Sep 26, 2025 at 03:05:38PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
> dlibs/aarch64/5.11/net.d | 1 -
> dlibs/aarch64/5.12/net.d | 1 -
> dlibs/aarch64/5.14/net.d | 1 -
> dlibs/aarch64/5.16/net.d | 1 -
> dlibs/aarch64/5.2/net.d | 1 -
> dlibs/aarch64/5.6/net.d | 1 -
> dlibs/aarch64/6.1/net.d | 1 -
> dlibs/aarch64/6.10/net.d | 1 -
> dlibs/x86_64/5.11/net.d | 1 -
> dlibs/x86_64/5.12/net.d | 1 -
> dlibs/x86_64/5.14/net.d | 1 -
> dlibs/x86_64/5.16/net.d | 1 -
> dlibs/x86_64/5.2/net.d | 1 -
> dlibs/x86_64/5.6/net.d | 1 -
> dlibs/x86_64/6.1/net.d | 1 -
> dlibs/x86_64/6.10/net.d | 1 -
> libdtrace/net.d | 1 -
> 17 files changed, 17 deletions(-)
>
> diff --git a/dlibs/aarch64/5.11/net.d b/dlibs/aarch64/5.11/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.11/net.d
> +++ b/dlibs/aarch64/5.11/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/aarch64/5.12/net.d b/dlibs/aarch64/5.12/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.12/net.d
> +++ b/dlibs/aarch64/5.12/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/aarch64/5.14/net.d b/dlibs/aarch64/5.14/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.14/net.d
> +++ b/dlibs/aarch64/5.14/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/aarch64/5.16/net.d b/dlibs/aarch64/5.16/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.16/net.d
> +++ b/dlibs/aarch64/5.16/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/aarch64/5.2/net.d b/dlibs/aarch64/5.2/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.2/net.d
> +++ b/dlibs/aarch64/5.2/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/aarch64/5.6/net.d b/dlibs/aarch64/5.6/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.6/net.d
> +++ b/dlibs/aarch64/5.6/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/aarch64/6.1/net.d b/dlibs/aarch64/6.1/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/6.1/net.d
> +++ b/dlibs/aarch64/6.1/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/aarch64/6.10/net.d b/dlibs/aarch64/6.10/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/6.10/net.d
> +++ b/dlibs/aarch64/6.10/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/x86_64/5.11/net.d b/dlibs/x86_64/5.11/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.11/net.d
> +++ b/dlibs/x86_64/5.11/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/x86_64/5.12/net.d b/dlibs/x86_64/5.12/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.12/net.d
> +++ b/dlibs/x86_64/5.12/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/x86_64/5.14/net.d b/dlibs/x86_64/5.14/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.14/net.d
> +++ b/dlibs/x86_64/5.14/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/x86_64/5.16/net.d b/dlibs/x86_64/5.16/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.16/net.d
> +++ b/dlibs/x86_64/5.16/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/x86_64/5.2/net.d b/dlibs/x86_64/5.2/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.2/net.d
> +++ b/dlibs/x86_64/5.2/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/x86_64/5.6/net.d b/dlibs/x86_64/5.6/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.6/net.d
> +++ b/dlibs/x86_64/5.6/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/x86_64/6.1/net.d b/dlibs/x86_64/6.1/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/6.1/net.d
> +++ b/dlibs/x86_64/6.1/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/dlibs/x86_64/6.10/net.d b/dlibs/x86_64/6.10/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/6.10/net.d
> +++ b/dlibs/x86_64/6.10/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> diff --git a/libdtrace/net.d b/libdtrace/net.d
> index a81fdf087..f14013b9f 100644
> --- a/libdtrace/net.d
> +++ b/libdtrace/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr in6_addr_t;
> /*
> * pktinfo is where packet ID info can be made available for deeper analysis if
> * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
> */
> typedef struct pktinfo {
> uintptr_t pkt_addr;
> --
> 2.47.3
>