Re: [PATCH 5/5] test: Remove antiquated special case for aarch64

Kris Van Hees
2025-10-03T03:56:04Z

On Wed, Oct 01, 2025 at 02:24:18AM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> Also, add some compilation flags while we are at it.
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
> test/triggers/Build | 1 +
> test/unittest/ustack/tst.bigstack.aarch64.x | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
> delete mode 100644 test/unittest/ustack/tst.bigstack.aarch64.x
>
> diff --git a/test/triggers/Build b/test/triggers/Build
> index d49b996a6..4ff5002a8 100644
> --- a/test/triggers/Build
> +++ b/test/triggers/Build
> @@ -236,6 +236,7 @@ usdt-tst-special_PROV := usdt-tst-special-prov.d
> # ustack wants no optimization
>
> ustack-tst-basic_CFLAGS := -O0 -fno-inline -fno-omit-frame-pointer
> +ustack-tst-bigstack_CFLAGS := -O0 -fno-inline -fno-omit-frame-pointer
> ustack-tst-bigstack-spin_CFLAGS := -O0 -fno-inline -fno-omit-frame-pointer
> ustack-tst-spin_CFLAGS := -O0
> ustack-tst-mtspin_CFLAGS := -O0
> diff --git a/test/unittest/ustack/tst.bigstack.aarch64.x b/test/unittest/ustack/tst.bigstack.aarch64.x
> deleted file mode 100644
> index 735f88c35..000000000
> --- a/test/unittest/ustack/tst.bigstack.aarch64.x
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -# On aarch64, we are able to handle ustackdepth beyond 4096 so the expected
> -# BAD_STACK failure will not occur with this test.
> --
> 2.47.3
>