From: eugene.loh@oracle.com
To: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: [PATCH v2] test: Account again for variations in error messages
Date: Thu, 9 Oct 2025 23:50:03 -0400 [thread overview]
Message-ID: <20251010035003.4865-1-eugene.loh@oracle.com> (raw)
From: Eugene Loh <eugene.loh@oracle.com>
In commit 944dac095 ("test: Account for variations in error messages"),
an attempt was made to account for variations in error messages.
However, it was applied to the branch after commit 49e646183
("test: dupstruct: fix extra duplicate identifier case"), and conflict
resolution was not consistent. The earlier patch "standardized"
messages by applying an optional "enumerator" where that label was
missing; the subsequent patch did the opposite. Subsequently, some
logic got messed up.
Fix up the logic. In particular, standardize on the newer error
message (with the "enumerator" label).
Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
---
test/utils/libctf.r.p | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/utils/libctf.r.p b/test/utils/libctf.r.p
index 8a6fd8b13..504d4b59e 100755
--- a/test/utils/libctf.r.p
+++ b/test/utils/libctf.r.p
@@ -16,7 +16,7 @@
/\[D_DECL_IDRED\] line [1-9][0-9]*: identifier redeclared: [a-zA-Z]*$/ {
sub(/\[D_DECL_IDRED\] line [1-9][0-9]*: .*$/, "expected error");
}
-/\[D_UNKNOWN\] line [1-9][0-9]*: failed to define enumerator '[a-zA-Z]*': Duplicate member or variable name$/ {
+/\[D_UNKNOWN\] line [1-9][0-9]*: failed to define enumerator '[a-zA-Z]*': Duplicate member, enumerator, or variable name$/ {
sub(/\[D_UNKNOWN\] line [1-9][0-9]*: .*$/, "expected error");
}
--
2.47.3
next reply other threads:[~2025-10-10 3:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 3:50 eugene.loh [this message]
2025-10-13 19:16 ` [PATCH v2] test: Account again for variations in error messages Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010035003.4865-1-eugene.loh@oracle.com \
--to=eugene.loh@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox