Re: [PATCH v2] test: Skip tst.depth.sh

Kris Van Hees
2025-11-13T04:35:24Z

NAK...

If this is causing havoc, it is identifying a real problem that needs to be
addressed. That is what the test is for. Given that you (in this v2) now
identify that we already had some other test that got SKIPped because it
causes issues with a large number of probes, and we did not look at that with
the 2.0.4 release *because* it was a skipped test and thus did not alert us
that there are issues in this area, SKIPping is clearly not the appropriate way
to deal with these issues.

We should retain the test as-is, and investigate + fix the underlying
problem(s). Hiding them from sight is clearly not effective enough.

On Wed, Nov 12, 2025 at 07:35:55PM -0500, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> The test asks for very many pid probes. E.g.,
>
> pid$target:::entry,
> pid$target:::return,
> pid$target:a.out::,
>
> If it is successful, this can wreak havoc on some systems, in some cases
> leading to 1-2 dozen subsequent tests failing due to cascading problems:
> poor test clean up, triggers left running, persistent loads, pid=0 not
> running, tests timing out, and so on. These problems require
> investigation.
>
> For now, skip the precipitating test.
>
> See
> https://oss.oracle.com/pipermail/dtrace-devel/2025-November/006916.html
>
> Incidentally, there are similar issues for
>
> * test/unittest/pid/err.D_PROC_CREATEFAIL.many.d
> but this test is already marked SKIP, apparently for the same reason.
> See commit d9423bd79
> ("err.D_PROC_CREATEFAIL.many.d causes failures in subsequent tests").
> The current patch simply seeks to apply the same SKIP to another test.
>
> * test/demo/user/userfunc.d
> but this test is marked XFAIL since it needs a trigger
>
> All three tests should be resolved when the underlying problem is
> tackled.
>
> Orabug: 38642080
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> ---
> test/unittest/ustack/tst.depth.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/unittest/ustack/tst.depth.sh b/test/unittest/ustack/tst.depth.sh
> index dec16a3aa..4a67291de 100755
> --- a/test/unittest/ustack/tst.depth.sh
> +++ b/test/unittest/ustack/tst.depth.sh
> @@ -1,10 +1,10 @@
> #!/bin/bash
> #
> # Oracle Linux DTrace.
> -# Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> +# Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved.
> # Licensed under the Universal Permissive License v 1.0 as shown at
> # http://oss.oracle.com/licenses/upl.
> -# @@xfail: dtv2
> +# @@skip
>
> if [ $# != 1 ]; then
> echo expected one argument: '<'dtrace-path'>'
> --
> 2.47.3
>