public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: eugene.loh@oracle.com
To: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: [PATCH] test: Account for readahead tracepoints
Date: Thu, 22 Jan 2026 02:23:14 -0500	[thread overview]
Message-ID: <20260122072314.10617-1-eugene.loh@oracle.com> (raw)

From: Eugene Loh <eugene.loh@oracle.com>

Some tests check for empty probe descriptions.  In some cases, the tests
relied on the absence of any read* modules.

However, some kernels can have "readahead" tracepoints.  Tests expecting
no read* modules will therefore fail.

Change these tests to ask for readfoo* modules to ensure that the probe
descriptions will indeed find no probes.

Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
---
 test/unittest/dtrace-util/tst.ListProbesFuncEmpty.r  | 2 +-
 test/unittest/dtrace-util/tst.ListProbesFuncEmpty.sh | 2 +-
 test/unittest/dtrace-util/tst.ListProbesNameEmpty.r  | 2 +-
 test/unittest/dtrace-util/tst.ListProbesNameEmpty.sh | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/unittest/dtrace-util/tst.ListProbesFuncEmpty.r b/test/unittest/dtrace-util/tst.ListProbesFuncEmpty.r
index a1e11d575..616632628 100644
--- a/test/unittest/dtrace-util/tst.ListProbesFuncEmpty.r
+++ b/test/unittest/dtrace-util/tst.ListProbesFuncEmpty.r
@@ -8,7 +8,7 @@ dtrace: failed to match ::profile:: No probe matches description
 dtrace: failed to match ::vmlinux:: No probe matches description
 dtrace: failed to match vmlinux:::: No probe matches description
 dtrace: failed to match :read::: No probe matches description
-dtrace: failed to match :read*::: No probe matches description
+dtrace: failed to match :readfoo*::: No probe matches description
 dtrace: invalid probe specifier profile:::tick-1000: invalid probe description "profile:::tick-1000": Overspecified probe description
 dtrace: invalid probe specifier fbt:des:des3_crunch_block:return: invalid probe description "fbt:des:des3_crunch_block:return": Overspecified probe description
 dtrace: invalid probe specifier read: extraneous argument '{printf("FOUND");}' ($1 is not referenced)
diff --git a/test/unittest/dtrace-util/tst.ListProbesFuncEmpty.sh b/test/unittest/dtrace-util/tst.ListProbesFuncEmpty.sh
index 999f138b0..b5189b3f2 100755
--- a/test/unittest/dtrace-util/tst.ListProbesFuncEmpty.sh
+++ b/test/unittest/dtrace-util/tst.ListProbesFuncEmpty.sh
@@ -28,7 +28,7 @@ $dtrace $dt_flags -lf profile
 $dtrace $dt_flags -lf vmlinux
 $dtrace $dt_flags -lf :vmlinux::
 $dtrace $dt_flags -lf ::read:
-$dtrace $dt_flags -lf ::'read*':
+$dtrace $dt_flags -lf ::'readfoo*':
 $dtrace $dt_flags -lf profile:::tick-1000
 $dtrace $dt_flags -lf fbt:des:des3_crunch_block:return
 # This is curiously different from what man.ListProbesWithFunctions says should
diff --git a/test/unittest/dtrace-util/tst.ListProbesNameEmpty.r b/test/unittest/dtrace-util/tst.ListProbesNameEmpty.r
index a89124b88..a2489f19d 100644
--- a/test/unittest/dtrace-util/tst.ListProbesNameEmpty.r
+++ b/test/unittest/dtrace-util/tst.ListProbesNameEmpty.r
@@ -17,5 +17,5 @@ dtrace: failed to match ::vmlinux:read: No probe matches description
 dtrace: failed to match :syscall:vmlinux:read: No probe matches description
 dtrace: failed to match ::vmlinux:: No probe matches description
 dtrace: failed to match fbt:des:des3_crunch_block:return: No probe matches description
-dtrace: failed to match :read*::: No probe matches description
+dtrace: failed to match :readfoo*::: No probe matches description
 dtrace: failed to match :::read: No probe matches description
diff --git a/test/unittest/dtrace-util/tst.ListProbesNameEmpty.sh b/test/unittest/dtrace-util/tst.ListProbesNameEmpty.sh
index 50c7fa0a1..ab2b861c4 100755
--- a/test/unittest/dtrace-util/tst.ListProbesNameEmpty.sh
+++ b/test/unittest/dtrace-util/tst.ListProbesNameEmpty.sh
@@ -32,6 +32,6 @@ $dtrace $dt_flags -ln vmlinux:read
 $dtrace $dt_flags -ln syscall:vmlinux:read
 $dtrace $dt_flags -ln :vmlinux:
 $dtrace $dt_flags -ln fbt:des:des3_crunch_block:return
-$dtrace $dt_flags -ln :'read*'::
+$dtrace $dt_flags -ln :'readfoo*'::
 $dtrace $dt_flags -ln read'{printf("FOUND");}'
 exit 0
-- 
2.47.3


             reply	other threads:[~2026-01-22  7:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22  7:23 eugene.loh [this message]
2026-01-27 12:55 ` [DTrace-devel] [PATCH] test: Account for readahead tracepoints Nick Alcock
2026-01-27 15:11   ` Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260122072314.10617-1-eugene.loh@oracle.com \
    --to=eugene.loh@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox