From: Eugene Loh <eugene.loh@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH v3] trace: print alloca pointers as actual pointer values
Date: Tue, 16 Sep 2025 14:56:56 -0400 [thread overview]
Message-ID: <3ba2dc91-ecb4-ab5a-e715-774e849ba50b@oracle.com> (raw)
In-Reply-To: <aMmloLhzYupYUm1y@oracle.com>
On 9/16/25 14:00, Kris Van Hees wrote:
> On Tue, Sep 16, 2025 at 01:07:50PM -0400, Eugene Loh wrote:
>> Just cleaning up my inbox...
>>
>> On 9/16/25 12:02, Kris Van Hees wrote:
>>
>>> On Tue, Sep 16, 2025 at 09:17:26AM -0400, Kris Van Hees wrote:
>>>> Eugene: Can you test with my kvh/2.0-branch-dev branch from ca-tools4?
>> Yeah. I get the same issues.
>>> Ah, I just took my tree, and merged dev-queue into it, and now I am seeing the
>>> issue pop up with tst.tid_pid.sh at least so will look at that right now.
>> Cool. Let me know if you need something else.
>>>> On Mon, Sep 15, 2025 at 11:20:28PM -0400, Kris Van Hees wrote:
>>>>> Do you have the pointer subtraction patch applied before this one?
>> Yes.
> These are the failures I see:
>
> test/unittest/aggs/tst.aggmod_full2.sh: FAIL: erroneous exitcode (1).
> test/unittest/builtinvar/tst.tid_pid.sh: FAIL: erroneous exitcode (1).
> test/unittest/consumer/tst.merge_ranges_bug25767469.c: FAIL: erroneous exitcode (1).
> test/unittest/consumer/tst.symbols.c: FAIL: erroneous exitcode (1).
> test/unittest/version/err.1.1.d: FAIL: core dumped.
>
> Only the tid_pid one seems to be related to the alloca handling code in
> store_val().
Agreed.
> Do you see other failures in addition to this?
Yes. See
https://oss.oracle.com/pipermail/dtrace-devel/2025-September/006645.html
. But I tried your fresh 2.0-branch-dev and it looked fine. So I
suspect things are good now, but I'll try the full test suite and check.
prev parent reply other threads:[~2025-09-16 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 17:36 [PATCH v3] trace: print alloca pointers as actual pointer values Kris Van Hees
2025-09-15 20:41 ` [DTrace-devel] " Eugene Loh
2025-09-16 1:44 ` Kris Van Hees
2025-09-16 3:20 ` Kris Van Hees
2025-09-16 13:17 ` Kris Van Hees
2025-09-16 16:02 ` Kris Van Hees
2025-09-16 17:07 ` Eugene Loh
2025-09-16 18:00 ` Kris Van Hees
2025-09-16 18:56 ` Eugene Loh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba2dc91-ecb4-ab5a-e715-774e849ba50b@oracle.com \
--to=eugene.loh@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox