public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Eugene Loh <eugene.loh@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>,
	dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 4/4] test: fix test failure when no /usr/sbin/dtrace exists
Date: Thu, 18 Sep 2025 15:18:39 -0400	[thread overview]
Message-ID: <47bb646d-eef0-bff0-cfdf-d0775154dfa7@oracle.com> (raw)
In-Reply-To: <20250918180338.197827-4-nick.alcock@oracle.com>

Okay, but should it even be $dtrace $dt_flags?  If for no other reason 
than symmetry with prov1.d?

On 9/18/25 14:03, Nick Alcock wrote:
> A missing $ led to this test spuriously failing in this case.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> ---
>   test/unittest/usdt/tst.exec-dof-replacement.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/unittest/usdt/tst.exec-dof-replacement.sh b/test/unittest/usdt/tst.exec-dof-replacement.sh
> index b7ec5f2dc5e92..81833cc8b77f8 100755
> --- a/test/unittest/usdt/tst.exec-dof-replacement.sh
> +++ b/test/unittest/usdt/tst.exec-dof-replacement.sh
> @@ -33,7 +33,7 @@ provider test_prov {
>   };
>   EOF
>   
> -if ! { $dtrace $dt_flags -h -s prov1.d && dtrace -h -s prov2.d; } then
> +if ! { $dtrace $dt_flags -h -s prov1.d && $dtrace -h -s prov2.d; } then
>   	echo "failed to generate header files" >&2
>   	exit 1
>   fi

  reply	other threads:[~2025-09-18 19:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 18:03 [PATCH 1/4] parser: fix parser debugging yet again Nick Alcock
2025-09-18 18:03 ` [PATCH 2/4] lexer: the things inside an enum { ... } declaration are identifiers Nick Alcock
2025-10-03  0:00   ` [DTrace-devel] " Kris Van Hees
2025-09-18 18:03 ` [PATCH 3/4] test: enum tests Nick Alcock
2025-10-03  0:00   ` Kris Van Hees
2025-09-18 18:03 ` [PATCH 4/4] test: fix test failure when no /usr/sbin/dtrace exists Nick Alcock
2025-09-18 19:18   ` Eugene Loh [this message]
2025-09-23 15:15     ` Nick Alcock
2025-09-23 15:31     ` [PATCH v2 " Nick Alcock
2025-10-03  0:01   ` [DTrace-devel] [PATCH " Kris Van Hees
2025-10-03  0:00 ` [PATCH 1/4] parser: fix parser debugging yet again Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47bb646d-eef0-bff0-cfdf-d0775154dfa7@oracle.com \
    --to=eugene.loh@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox