From: Eugene Loh <eugene.loh@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH v3 2/4] test: correct file permissions
Date: Wed, 7 Jan 2026 18:44:51 -0500 [thread overview]
Message-ID: <5569d57d-da23-2b61-ec0a-2c8091f57c7f@oracle.com> (raw)
In-Reply-To: <aV7ke3WwP7G37pnu@oracle.com>
On 1/7/26 17:55, Kris Van Hees wrote:
> On Wed, Jan 07, 2026 at 04:30:57PM -0500, Eugene Loh wrote:
>> How are the tests running? Didn't assign, pid, and pgid need the -q
>> removed?
> Tests are fine. Those tests did not need any further changes apparently.
I'm confused how that could be. The tests were not running with -q, and
so the .r files had ":BEGIN" in their output. With this patch, the
tests run with -q and the .r files have not changed. I just checked:
the tests fail for me.
>> On 1/7/26 11:28, Kris Van Hees via DTrace-devel wrote:
>>> diff --git a/test/unittest/scripting/tst.assign.d b/test/unittest/scripting/tst.assign.d
>>> -#!/usr/sbin/dtrace -qs
>>> +#!dtrace -qs
>>> diff --git a/test/unittest/scripting/tst.pgid.d b/test/unittest/scripting/tst.pgid.d
>>> -#!/usr/sbin/dtrace -qs
>>> +#!dtrace -qs
>>> diff --git a/test/unittest/scripting/tst.pid.d b/test/unittest/scripting/tst.pid.d
>>> -#!/usr/sbin/dtrace -qs
>>> +#!dtrace -qs
prev parent reply other threads:[~2026-01-07 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 16:28 [PATCH v3 2/4] test: correct file permissions Kris Van Hees
2026-01-07 21:30 ` [DTrace-devel] " Eugene Loh
2026-01-07 22:55 ` Kris Van Hees
2026-01-07 23:44 ` Eugene Loh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5569d57d-da23-2b61-ec0a-2c8091f57c7f@oracle.com \
--to=eugene.loh@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox