* [PATCH v2 2/4] test: correct file permissions @ 2025-12-19 0:51 Kris Van Hees 2026-01-06 4:50 ` [DTrace-devel] " Eugene Loh 0 siblings, 1 reply; 7+ messages in thread From: Kris Van Hees @ 2025-12-19 0:51 UTC (permalink / raw) To: dtrace, dtrace-devel Various tests had a #!-invocation while still being expected to be used as scripts fed to dtrace. Removed the #!-lines and marked the files non-executable. Various tests that were meant to be invoked as standaline scripts had a runtet.sh expects standalone D scripts to use '#!dtrace' so that the correct path to the dtrace executable being tested can be inserted. Corrected the tests, and ensured they are executable. Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com> --- test/demo/script/interp.d | 2 +- test/demo/script/tracewrite.d | 4 ++-- test/demo/spec/specopen.d | 6 +++--- test/stress/fbtsafety/tst.vahole.d | 2 +- test/unittest/lockstat/tst.lockstat-summary.d | 0 test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d | 2 +- test/unittest/scripting/err.D_OP_LVAL.rdonly.d | 2 +- test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d | 2 +- test/unittest/scripting/err.D_SYNTAX.concat.d | 2 +- test/unittest/scripting/err.D_SYNTAX.desc.d | 2 +- test/unittest/scripting/err.D_SYNTAX.inval.d | 2 +- test/unittest/scripting/err.D_SYNTAX.pid.d | 2 +- test/unittest/scripting/tst.arg0.d | 2 +- test/unittest/scripting/tst.assign.d | 2 +- test/unittest/scripting/tst.basic.d | 2 +- test/unittest/scripting/tst.pgid.d | 2 +- test/unittest/scripting/tst.pid.d | 2 +- test/unittest/scripting/tst.quiet.d | 0 test/unittest/scripting/tst.sid.d | 2 +- test/unittest/scripting/tst.trace.d | 2 +- .../speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d | 5 ++--- .../speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r | 2 +- .../speculation/err.D_ACT_SPEC.SpeculateWithChill.d | 5 ++--- .../speculation/err.D_ACT_SPEC.SpeculateWithChill.r | 2 +- .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d | 5 ++--- .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r | 2 +- .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d | 5 ++--- .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r | 2 +- .../speculation/err.D_ACT_SPEC.SpeculateWithPanic.d | 5 ++--- .../speculation/err.D_ACT_SPEC.SpeculateWithPanic.r | 2 +- .../speculation/err.D_ACT_SPEC.SpeculateWithRaise.d | 5 ++--- .../speculation/err.D_ACT_SPEC.SpeculateWithRaise.r | 2 +- .../unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d | 5 ++--- .../unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r | 2 +- 34 files changed, 42 insertions(+), 49 deletions(-) mode change 100644 => 100755 test/demo/script/interp.d mode change 100644 => 100755 test/demo/script/tracewrite.d mode change 100644 => 100755 test/stress/fbtsafety/tst.vahole.d mode change 100755 => 100644 test/unittest/lockstat/tst.lockstat-summary.d mode change 100644 => 100755 test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d mode change 100644 => 100755 test/unittest/scripting/err.D_OP_LVAL.rdonly.d mode change 100644 => 100755 test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.concat.d mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.desc.d mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.inval.d mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.pid.d mode change 100644 => 100755 test/unittest/scripting/tst.arg0.d mode change 100644 => 100755 test/unittest/scripting/tst.assign.d mode change 100644 => 100755 test/unittest/scripting/tst.basic.d mode change 100644 => 100755 test/unittest/scripting/tst.pgid.d mode change 100644 => 100755 test/unittest/scripting/tst.pid.d mode change 100644 => 100755 test/unittest/scripting/tst.quiet.d mode change 100644 => 100755 test/unittest/scripting/tst.sid.d mode change 100644 => 100755 test/unittest/scripting/tst.trace.d diff --git a/test/demo/script/interp.d b/test/demo/script/interp.d old mode 100644 new mode 100755 index be690b56..f4718a41 --- a/test/demo/script/interp.d +++ b/test/demo/script/interp.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -s +#!dtrace -s /* * Oracle Linux DTrace. diff --git a/test/demo/script/tracewrite.d b/test/demo/script/tracewrite.d old mode 100644 new mode 100755 index 0c139ead..482f272b --- a/test/demo/script/tracewrite.d +++ b/test/demo/script/tracewrite.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -s +#!dtrace -s /* * Oracle Linux DTrace. @@ -7,7 +7,7 @@ * http://oss.oracle.com/licenses/upl. */ -/* @@trigger: readwholedir */ +/* @@runtest-opts: -c test/triggers/readwholedir */ syscall::write:entry /pid == $target/ diff --git a/test/demo/spec/specopen.d b/test/demo/spec/specopen.d index e7dbc3b2..6d3d79af 100644 --- a/test/demo/spec/specopen.d +++ b/test/demo/spec/specopen.d @@ -1,12 +1,12 @@ -#!/usr/sbin/dtrace -Fs - /* * Oracle Linux DTrace. - * Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ +#pragma D option flowindent + syscall::openat:entry { /* diff --git a/test/stress/fbtsafety/tst.vahole.d b/test/stress/fbtsafety/tst.vahole.d old mode 100644 new mode 100755 index b918e663..d7d6cc88 --- a/test/stress/fbtsafety/tst.vahole.d +++ b/test/stress/fbtsafety/tst.vahole.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -Cs +#!dtrace -Cs /* * Oracle Linux DTrace. diff --git a/test/unittest/lockstat/tst.lockstat-summary.d b/test/unittest/lockstat/tst.lockstat-summary.d old mode 100755 new mode 100644 diff --git a/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d b/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d old mode 100644 new mode 100755 index 45c37efe..b54ba982 --- a/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d +++ b/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/err.D_OP_LVAL.rdonly.d b/test/unittest/scripting/err.D_OP_LVAL.rdonly.d old mode 100644 new mode 100755 index b51e1160..93ddbd2a --- a/test/unittest/scripting/err.D_OP_LVAL.rdonly.d +++ b/test/unittest/scripting/err.D_OP_LVAL.rdonly.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d b/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d old mode 100644 new mode 100755 index a4880cca..fe6fe34a --- a/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d +++ b/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/err.D_SYNTAX.concat.d b/test/unittest/scripting/err.D_SYNTAX.concat.d old mode 100644 new mode 100755 index 8f7b210f..23caa113 --- a/test/unittest/scripting/err.D_SYNTAX.concat.d +++ b/test/unittest/scripting/err.D_SYNTAX.concat.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/err.D_SYNTAX.desc.d b/test/unittest/scripting/err.D_SYNTAX.desc.d old mode 100644 new mode 100755 index 34ae864c..baeb2901 --- a/test/unittest/scripting/err.D_SYNTAX.desc.d +++ b/test/unittest/scripting/err.D_SYNTAX.desc.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/err.D_SYNTAX.inval.d b/test/unittest/scripting/err.D_SYNTAX.inval.d old mode 100644 new mode 100755 index d3338cfd..bec28942 --- a/test/unittest/scripting/err.D_SYNTAX.inval.d +++ b/test/unittest/scripting/err.D_SYNTAX.inval.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/err.D_SYNTAX.pid.d b/test/unittest/scripting/err.D_SYNTAX.pid.d old mode 100644 new mode 100755 index 01044d6e..72d9dfc0 --- a/test/unittest/scripting/err.D_SYNTAX.pid.d +++ b/test/unittest/scripting/err.D_SYNTAX.pid.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/tst.arg0.d b/test/unittest/scripting/tst.arg0.d old mode 100644 new mode 100755 index 905fefb6..af7e8ded --- a/test/unittest/scripting/tst.arg0.d +++ b/test/unittest/scripting/tst.arg0.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -s +#!dtrace -s /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/tst.assign.d b/test/unittest/scripting/tst.assign.d old mode 100644 new mode 100755 index 9bbd8e49..527f3242 --- a/test/unittest/scripting/tst.assign.d +++ b/test/unittest/scripting/tst.assign.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/tst.basic.d b/test/unittest/scripting/tst.basic.d old mode 100644 new mode 100755 index cd7b716a..57b75639 --- a/test/unittest/scripting/tst.basic.d +++ b/test/unittest/scripting/tst.basic.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -s +#!dtrace -s /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/tst.pgid.d b/test/unittest/scripting/tst.pgid.d old mode 100644 new mode 100755 index 8d82f2bd..99ec11bf --- a/test/unittest/scripting/tst.pgid.d +++ b/test/unittest/scripting/tst.pgid.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/tst.pid.d b/test/unittest/scripting/tst.pid.d old mode 100644 new mode 100755 index 2d0499d7..dc3e3182 --- a/test/unittest/scripting/tst.pid.d +++ b/test/unittest/scripting/tst.pid.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -qs +#!dtrace -qs /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/tst.quiet.d b/test/unittest/scripting/tst.quiet.d old mode 100644 new mode 100755 diff --git a/test/unittest/scripting/tst.sid.d b/test/unittest/scripting/tst.sid.d old mode 100644 new mode 100755 index e4f1395c..48f45f57 --- a/test/unittest/scripting/tst.sid.d +++ b/test/unittest/scripting/tst.sid.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -s +#!dtrace -s /* * Oracle Linux DTrace. diff --git a/test/unittest/scripting/tst.trace.d b/test/unittest/scripting/tst.trace.d old mode 100644 new mode 100755 index 148e5c60..bcc4b445 --- a/test/unittest/scripting/tst.trace.d +++ b/test/unittest/scripting/tst.trace.d @@ -1,4 +1,4 @@ -#!/usr/sbin/dtrace -s +#!dtrace -s /* * Oracle Linux DTrace. diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d index 50bbf177..97c0cb6d 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d @@ -1,7 +1,6 @@ -#!/usr/sbin/dtrace -ws /* * Oracle Linux DTrace. - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ @@ -10,8 +9,8 @@ * ASSERTION: Destructive actions may never be speculative. * * SECTION: Speculative Tracing/Using a Speculation - * SECTION: dtrace(1M) Utility/ -w option */ +#pragma D option destructive #pragma D option quiet BEGIN diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r index 1590807c..206641c0 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r @@ -1,2 +1,2 @@ -- @@stderr -- -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d index 47e248d2..38a92e60 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d @@ -1,7 +1,6 @@ -#!/usr/sbin/dtrace -ws /* * Oracle Linux DTrace. - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ @@ -10,8 +9,8 @@ * ASSERTION: Destructive actions may never be speculative. * * SECTION: Speculative Tracing/Using a Speculation - * SECTION: dtrace (1M) Utility/ -w option */ +#pragma D option destructive #pragma D option quiet BEGIN diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r index d01ab558..ab7c6ed9 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r @@ -1,2 +1,2 @@ -- @@stderr -- -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d index 14cc1d5c..da6e17db 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d @@ -1,7 +1,6 @@ -#!/usr/sbin/dtrace -ws /* * Oracle Linux DTrace. - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ @@ -10,8 +9,8 @@ * ASSERTION: Destructive actions may never be speculative. * * SECTION: Speculative Tracing/Using a Speculation - * SECTION: dtrace(1M) Utility/ -w option */ +#pragma D option destructive #pragma D option quiet char a[2]; diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r index 89592786..f57aba47 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r @@ -1,2 +1,2 @@ -- @@stderr -- -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d: [D_ACT_SPEC] line 34: destructive actions may not follow speculate( ) +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d: [D_ACT_SPEC] line 33: destructive actions may not follow speculate( ) diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d index 43a41440..704b3b27 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d @@ -1,7 +1,6 @@ -#!/usr/sbin/dtrace -ws /* * Oracle Linux DTrace. - * Copyright (c) 2006, 2023, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ @@ -10,8 +9,8 @@ * ASSERTION: Destructive actions may never be speculative. * * SECTION: Speculative Tracing/Using a Speculation - * SECTION: dtrace(1M) Utility/ -w option */ +#pragma D option destructive #pragma D option quiet string str; diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r index 3bc21b18..da4038aa 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r @@ -1,2 +1,2 @@ -- @@stderr -- -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d: [D_ACT_SPEC] line 34: destructive actions may not follow speculate( ) +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d: [D_ACT_SPEC] line 33: destructive actions may not follow speculate( ) diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d index 80a3204d..d0ccfead 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d @@ -1,7 +1,6 @@ -#!/usr/sbin/dtrace -ws /* * Oracle Linux DTrace. - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ @@ -10,8 +9,8 @@ * ASSERTION: Destructive actions may never be speculative. * * SECTION: Speculative Tracing/Using a Speculation - * SECTION: dtrace(1M) Utility/ -w option */ +#pragma D option destructive #pragma D option quiet BEGIN diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r index 3c120a03..7c15314d 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r @@ -1,2 +1,2 @@ -- @@stderr -- -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d index a8c1c4d4..7e98885b 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d @@ -1,7 +1,6 @@ -#!/usr/sbin/dtrace -ws /* * Oracle Linux DTrace. - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ @@ -10,8 +9,8 @@ * ASSERTION: Destructive actions may never be speculative. * * SECTION: Speculative Tracing/Using a Speculation - * SECTION: dtrace(1M) Utility/ -w option */ +#pragma D option destructive #pragma D option quiet BEGIN diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r index 136f5cde..6e85370a 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r @@ -1,2 +1,2 @@ -- @@stderr -- -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d index a0bca73d..2518cd04 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d @@ -1,7 +1,6 @@ -#!/usr/sbin/dtrace -ws /* * Oracle Linux DTrace. - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ @@ -10,8 +9,8 @@ * ASSERTION: Destructive actions may never be speculative. * * SECTION: Speculative Tracing/Using a Speculation - * SECTION: dtrace(1M) Utility/ -w option */ +#pragma D option destructive #pragma D option quiet BEGIN diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r index 8cdc6ba1..98725509 100644 --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r @@ -1,2 +1,2 @@ -- @@stderr -- -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) -- 2.51.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [DTrace-devel] [PATCH v2 2/4] test: correct file permissions 2025-12-19 0:51 [PATCH v2 2/4] test: correct file permissions Kris Van Hees @ 2026-01-06 4:50 ` Eugene Loh 2026-01-06 5:54 ` Kris Van Hees 0 siblings, 1 reply; 7+ messages in thread From: Eugene Loh @ 2026-01-06 4:50 UTC (permalink / raw) To: Kris Van Hees, dtrace, dtrace-devel On 12/18/25 19:51, Kris Van Hees via DTrace-devel wrote: > Various tests had a #!-invocation while still being expected to be used > as scripts fed to dtrace. Removed the #!-lines and marked the files > non-executable. > > Various tests that were meant to be invoked as standaline scripts had a > runtet.sh expects standalone D scripts to use '#!dtrace' so that the After "... had a...", is some text missing or garbled? runtet.sh should be runtest.sh Some copyright updates were missing. (Also, the changes to 2025 should maybe be to 2026 at this point? I don't know.) Is it worth mentioning that some static checkers were demanding these changes? The patch otherwise reads right to me. The tests, however, are not happy. The following tests fail intermittently: test/demo/script/interp.d test/demo/script/tracewrite.d test/unittest/lockstat/tst.lockstat-summary.d test/unittest/scripting/tst.arg0.d test/unittest/scripting/tst.basic.d test/unittest/scripting/tst.trace.d These tests fail consistently: test/unittest/scripting/tst.assign.d test/unittest/scripting/tst.pgid.d test/unittest/scripting/tst.pid.d The problem for these tests is -#!/usr/sbin/dtrace -qs +#!dtrace -qs Since these files used to be invoked as scripts, the -q was ignored. The .r files relied on that. So the interpreter files should drop the -q. That does not fix them entirely; it simply makes their failures intermittent. I'll look more at the intermittent failures, but there may be more than one thing going on there. (lockstat-summary looks different) > correct path to the dtrace executable being tested can be inserted. > Corrected the tests, and ensured they are executable. > > Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com> > --- > test/demo/script/interp.d | 2 +- > test/demo/script/tracewrite.d | 4 ++-- > test/demo/spec/specopen.d | 6 +++--- > test/stress/fbtsafety/tst.vahole.d | 2 +- > test/unittest/lockstat/tst.lockstat-summary.d | 0 > test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d | 2 +- > test/unittest/scripting/err.D_OP_LVAL.rdonly.d | 2 +- > test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d | 2 +- > test/unittest/scripting/err.D_SYNTAX.concat.d | 2 +- > test/unittest/scripting/err.D_SYNTAX.desc.d | 2 +- > test/unittest/scripting/err.D_SYNTAX.inval.d | 2 +- > test/unittest/scripting/err.D_SYNTAX.pid.d | 2 +- > test/unittest/scripting/tst.arg0.d | 2 +- > test/unittest/scripting/tst.assign.d | 2 +- > test/unittest/scripting/tst.basic.d | 2 +- > test/unittest/scripting/tst.pgid.d | 2 +- > test/unittest/scripting/tst.pid.d | 2 +- > test/unittest/scripting/tst.quiet.d | 0 > test/unittest/scripting/tst.sid.d | 2 +- > test/unittest/scripting/tst.trace.d | 2 +- > .../speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d | 5 ++--- > .../speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r | 2 +- > .../speculation/err.D_ACT_SPEC.SpeculateWithChill.d | 5 ++--- > .../speculation/err.D_ACT_SPEC.SpeculateWithChill.r | 2 +- > .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d | 5 ++--- > .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r | 2 +- > .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d | 5 ++--- > .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r | 2 +- > .../speculation/err.D_ACT_SPEC.SpeculateWithPanic.d | 5 ++--- > .../speculation/err.D_ACT_SPEC.SpeculateWithPanic.r | 2 +- > .../speculation/err.D_ACT_SPEC.SpeculateWithRaise.d | 5 ++--- > .../speculation/err.D_ACT_SPEC.SpeculateWithRaise.r | 2 +- > .../unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d | 5 ++--- > .../unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r | 2 +- > 34 files changed, 42 insertions(+), 49 deletions(-) > mode change 100644 => 100755 test/demo/script/interp.d > mode change 100644 => 100755 test/demo/script/tracewrite.d > mode change 100644 => 100755 test/stress/fbtsafety/tst.vahole.d > mode change 100755 => 100644 test/unittest/lockstat/tst.lockstat-summary.d > mode change 100644 => 100755 test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d > mode change 100644 => 100755 test/unittest/scripting/err.D_OP_LVAL.rdonly.d > mode change 100644 => 100755 test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d > mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.concat.d > mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.desc.d > mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.inval.d > mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.pid.d > mode change 100644 => 100755 test/unittest/scripting/tst.arg0.d > mode change 100644 => 100755 test/unittest/scripting/tst.assign.d > mode change 100644 => 100755 test/unittest/scripting/tst.basic.d > mode change 100644 => 100755 test/unittest/scripting/tst.pgid.d > mode change 100644 => 100755 test/unittest/scripting/tst.pid.d > mode change 100644 => 100755 test/unittest/scripting/tst.quiet.d > mode change 100644 => 100755 test/unittest/scripting/tst.sid.d > mode change 100644 => 100755 test/unittest/scripting/tst.trace.d > > diff --git a/test/demo/script/interp.d b/test/demo/script/interp.d > old mode 100644 > new mode 100755 > index be690b56..f4718a41 > --- a/test/demo/script/interp.d > +++ b/test/demo/script/interp.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -s > +#!dtrace -s > > /* > * Oracle Linux DTrace. > diff --git a/test/demo/script/tracewrite.d b/test/demo/script/tracewrite.d > old mode 100644 > new mode 100755 > index 0c139ead..482f272b > --- a/test/demo/script/tracewrite.d > +++ b/test/demo/script/tracewrite.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -s > +#!dtrace -s > > /* > * Oracle Linux DTrace. > @@ -7,7 +7,7 @@ > * http://oss.oracle.com/licenses/upl. > */ > > -/* @@trigger: readwholedir */ > +/* @@runtest-opts: -c test/triggers/readwholedir */ > > syscall::write:entry > /pid == $target/ > diff --git a/test/demo/spec/specopen.d b/test/demo/spec/specopen.d > index e7dbc3b2..6d3d79af 100644 > --- a/test/demo/spec/specopen.d > +++ b/test/demo/spec/specopen.d > @@ -1,12 +1,12 @@ > -#!/usr/sbin/dtrace -Fs > - > /* > * Oracle Linux DTrace. > - * Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved. > * Licensed under the Universal Permissive License v 1.0 as shown at > * http://oss.oracle.com/licenses/upl. > */ > > +#pragma D option flowindent > + > syscall::openat:entry > { > /* > diff --git a/test/stress/fbtsafety/tst.vahole.d b/test/stress/fbtsafety/tst.vahole.d > old mode 100644 > new mode 100755 > index b918e663..d7d6cc88 > --- a/test/stress/fbtsafety/tst.vahole.d > +++ b/test/stress/fbtsafety/tst.vahole.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -Cs > +#!dtrace -Cs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/lockstat/tst.lockstat-summary.d b/test/unittest/lockstat/tst.lockstat-summary.d > old mode 100755 > new mode 100644 > diff --git a/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d b/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d > old mode 100644 > new mode 100755 > index 45c37efe..b54ba982 > --- a/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d > +++ b/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/err.D_OP_LVAL.rdonly.d b/test/unittest/scripting/err.D_OP_LVAL.rdonly.d > old mode 100644 > new mode 100755 > index b51e1160..93ddbd2a > --- a/test/unittest/scripting/err.D_OP_LVAL.rdonly.d > +++ b/test/unittest/scripting/err.D_OP_LVAL.rdonly.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d b/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d > old mode 100644 > new mode 100755 > index a4880cca..fe6fe34a > --- a/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d > +++ b/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/err.D_SYNTAX.concat.d b/test/unittest/scripting/err.D_SYNTAX.concat.d > old mode 100644 > new mode 100755 > index 8f7b210f..23caa113 > --- a/test/unittest/scripting/err.D_SYNTAX.concat.d > +++ b/test/unittest/scripting/err.D_SYNTAX.concat.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/err.D_SYNTAX.desc.d b/test/unittest/scripting/err.D_SYNTAX.desc.d > old mode 100644 > new mode 100755 > index 34ae864c..baeb2901 > --- a/test/unittest/scripting/err.D_SYNTAX.desc.d > +++ b/test/unittest/scripting/err.D_SYNTAX.desc.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/err.D_SYNTAX.inval.d b/test/unittest/scripting/err.D_SYNTAX.inval.d > old mode 100644 > new mode 100755 > index d3338cfd..bec28942 > --- a/test/unittest/scripting/err.D_SYNTAX.inval.d > +++ b/test/unittest/scripting/err.D_SYNTAX.inval.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/err.D_SYNTAX.pid.d b/test/unittest/scripting/err.D_SYNTAX.pid.d > old mode 100644 > new mode 100755 > index 01044d6e..72d9dfc0 > --- a/test/unittest/scripting/err.D_SYNTAX.pid.d > +++ b/test/unittest/scripting/err.D_SYNTAX.pid.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/tst.arg0.d b/test/unittest/scripting/tst.arg0.d > old mode 100644 > new mode 100755 > index 905fefb6..af7e8ded > --- a/test/unittest/scripting/tst.arg0.d > +++ b/test/unittest/scripting/tst.arg0.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -s > +#!dtrace -s > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/tst.assign.d b/test/unittest/scripting/tst.assign.d > old mode 100644 > new mode 100755 > index 9bbd8e49..527f3242 > --- a/test/unittest/scripting/tst.assign.d > +++ b/test/unittest/scripting/tst.assign.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/tst.basic.d b/test/unittest/scripting/tst.basic.d > old mode 100644 > new mode 100755 > index cd7b716a..57b75639 > --- a/test/unittest/scripting/tst.basic.d > +++ b/test/unittest/scripting/tst.basic.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -s > +#!dtrace -s > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/tst.pgid.d b/test/unittest/scripting/tst.pgid.d > old mode 100644 > new mode 100755 > index 8d82f2bd..99ec11bf > --- a/test/unittest/scripting/tst.pgid.d > +++ b/test/unittest/scripting/tst.pgid.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/tst.pid.d b/test/unittest/scripting/tst.pid.d > old mode 100644 > new mode 100755 > index 2d0499d7..dc3e3182 > --- a/test/unittest/scripting/tst.pid.d > +++ b/test/unittest/scripting/tst.pid.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/tst.quiet.d b/test/unittest/scripting/tst.quiet.d > old mode 100644 > new mode 100755 > diff --git a/test/unittest/scripting/tst.sid.d b/test/unittest/scripting/tst.sid.d > old mode 100644 > new mode 100755 > index e4f1395c..48f45f57 > --- a/test/unittest/scripting/tst.sid.d > +++ b/test/unittest/scripting/tst.sid.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -s > +#!dtrace -s > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/scripting/tst.trace.d b/test/unittest/scripting/tst.trace.d > old mode 100644 > new mode 100755 > index 148e5c60..bcc4b445 > --- a/test/unittest/scripting/tst.trace.d > +++ b/test/unittest/scripting/tst.trace.d > @@ -1,4 +1,4 @@ > -#!/usr/sbin/dtrace -s > +#!dtrace -s > > /* > * Oracle Linux DTrace. > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d > index 50bbf177..97c0cb6d 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d > @@ -1,7 +1,6 @@ > -#!/usr/sbin/dtrace -ws > /* > * Oracle Linux DTrace. > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > * Licensed under the Universal Permissive License v 1.0 as shown at > * http://oss.oracle.com/licenses/upl. > */ > @@ -10,8 +9,8 @@ > * ASSERTION: Destructive actions may never be speculative. > * > * SECTION: Speculative Tracing/Using a Speculation > - * SECTION: dtrace(1M) Utility/ -w option > */ > +#pragma D option destructive > #pragma D option quiet > > BEGIN > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r > index 1590807c..206641c0 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r > @@ -1,2 +1,2 @@ > -- @@stderr -- > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d > index 47e248d2..38a92e60 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d > @@ -1,7 +1,6 @@ > -#!/usr/sbin/dtrace -ws > /* > * Oracle Linux DTrace. > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > * Licensed under the Universal Permissive License v 1.0 as shown at > * http://oss.oracle.com/licenses/upl. > */ > @@ -10,8 +9,8 @@ > * ASSERTION: Destructive actions may never be speculative. > * > * SECTION: Speculative Tracing/Using a Speculation > - * SECTION: dtrace (1M) Utility/ -w option > */ > +#pragma D option destructive > #pragma D option quiet > > BEGIN > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r > index d01ab558..ab7c6ed9 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r > @@ -1,2 +1,2 @@ > -- @@stderr -- > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d > index 14cc1d5c..da6e17db 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d > @@ -1,7 +1,6 @@ > -#!/usr/sbin/dtrace -ws > /* > * Oracle Linux DTrace. > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > * Licensed under the Universal Permissive License v 1.0 as shown at > * http://oss.oracle.com/licenses/upl. > */ > @@ -10,8 +9,8 @@ > * ASSERTION: Destructive actions may never be speculative. > * > * SECTION: Speculative Tracing/Using a Speculation > - * SECTION: dtrace(1M) Utility/ -w option > */ > +#pragma D option destructive > #pragma D option quiet > > char a[2]; > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r > index 89592786..f57aba47 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r > @@ -1,2 +1,2 @@ > -- @@stderr -- > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d: [D_ACT_SPEC] line 34: destructive actions may not follow speculate( ) > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d: [D_ACT_SPEC] line 33: destructive actions may not follow speculate( ) > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d > index 43a41440..704b3b27 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d > @@ -1,7 +1,6 @@ > -#!/usr/sbin/dtrace -ws > /* > * Oracle Linux DTrace. > - * Copyright (c) 2006, 2023, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > * Licensed under the Universal Permissive License v 1.0 as shown at > * http://oss.oracle.com/licenses/upl. > */ > @@ -10,8 +9,8 @@ > * ASSERTION: Destructive actions may never be speculative. > * > * SECTION: Speculative Tracing/Using a Speculation > - * SECTION: dtrace(1M) Utility/ -w option > */ > +#pragma D option destructive > #pragma D option quiet > > string str; > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r > index 3bc21b18..da4038aa 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r > @@ -1,2 +1,2 @@ > -- @@stderr -- > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d: [D_ACT_SPEC] line 34: destructive actions may not follow speculate( ) > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d: [D_ACT_SPEC] line 33: destructive actions may not follow speculate( ) > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d > index 80a3204d..d0ccfead 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d > @@ -1,7 +1,6 @@ > -#!/usr/sbin/dtrace -ws > /* > * Oracle Linux DTrace. > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > * Licensed under the Universal Permissive License v 1.0 as shown at > * http://oss.oracle.com/licenses/upl. > */ > @@ -10,8 +9,8 @@ > * ASSERTION: Destructive actions may never be speculative. > * > * SECTION: Speculative Tracing/Using a Speculation > - * SECTION: dtrace(1M) Utility/ -w option > */ > +#pragma D option destructive > #pragma D option quiet > > BEGIN > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r > index 3c120a03..7c15314d 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r > @@ -1,2 +1,2 @@ > -- @@stderr -- > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d > index a8c1c4d4..7e98885b 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d > @@ -1,7 +1,6 @@ > -#!/usr/sbin/dtrace -ws > /* > * Oracle Linux DTrace. > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > * Licensed under the Universal Permissive License v 1.0 as shown at > * http://oss.oracle.com/licenses/upl. > */ > @@ -10,8 +9,8 @@ > * ASSERTION: Destructive actions may never be speculative. > * > * SECTION: Speculative Tracing/Using a Speculation > - * SECTION: dtrace(1M) Utility/ -w option > */ > +#pragma D option destructive > #pragma D option quiet > > BEGIN > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r > index 136f5cde..6e85370a 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r > @@ -1,2 +1,2 @@ > -- @@stderr -- > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d > index a0bca73d..2518cd04 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d > @@ -1,7 +1,6 @@ > -#!/usr/sbin/dtrace -ws > /* > * Oracle Linux DTrace. > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > * Licensed under the Universal Permissive License v 1.0 as shown at > * http://oss.oracle.com/licenses/upl. > */ > @@ -10,8 +9,8 @@ > * ASSERTION: Destructive actions may never be speculative. > * > * SECTION: Speculative Tracing/Using a Speculation > - * SECTION: dtrace(1M) Utility/ -w option > */ > +#pragma D option destructive > #pragma D option quiet > > BEGIN > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r > index 8cdc6ba1..98725509 100644 > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r > @@ -1,2 +1,2 @@ > -- @@stderr -- > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DTrace-devel] [PATCH v2 2/4] test: correct file permissions 2026-01-06 4:50 ` [DTrace-devel] " Eugene Loh @ 2026-01-06 5:54 ` Kris Van Hees 2026-01-07 1:20 ` Eugene Loh 0 siblings, 1 reply; 7+ messages in thread From: Kris Van Hees @ 2026-01-06 5:54 UTC (permalink / raw) To: Eugene Loh; +Cc: Kris Van Hees, dtrace, dtrace-devel On Mon, Jan 05, 2026 at 11:50:53PM -0500, Eugene Loh wrote: > On 12/18/25 19:51, Kris Van Hees via DTrace-devel wrote: > > > Various tests had a #!-invocation while still being expected to be used > > as scripts fed to dtrace. Removed the #!-lines and marked the files > > non-executable. > > > > Various tests that were meant to be invoked as standaline scripts had a > > runtet.sh expects standalone D scripts to use '#!dtrace' so that the > > After "... had a...", is some text missing or garbled? Hm, yes, will fix that. > runtet.sh should be runtest.sh Oops, yes. > Some copyright updates were missing. (Also, the changes to 2025 should > maybe be to 2026 at this point? I don't know.) Will fix. > Is it worth mentioning that some static checkers were demanding these > changes? I don't think that is really relevant, because the majority of these changes are actually correct in terms of how the scripts are used. THe static checked simply pointed it out to me. But the changes are not just to make it stop complaining - they are genuine fixes (either for confusing things or for things that really ought to be differet). > The patch otherwise reads right to me. The tests, however, are not happy. > The following tests fail intermittently: > > test/demo/script/interp.d > test/demo/script/tracewrite.d > test/unittest/lockstat/tst.lockstat-summary.d > test/unittest/scripting/tst.arg0.d > test/unittest/scripting/tst.basic.d > test/unittest/scripting/tst.trace.d > > These tests fail consistently: > test/unittest/scripting/tst.assign.d > test/unittest/scripting/tst.pgid.d > test/unittest/scripting/tst.pid.d > The problem for these tests is > -#!/usr/sbin/dtrace -qs > +#!dtrace -qs > Since these files used to be invoked as scripts, the -q was ignored. The .r > files relied on that. So the interpreter files should drop the -q. That > does not fix them entirely; it simply makes their failures intermittent. Yes, I caught (I think) all of the opposite cases where I added a pragma to ensure that the -q behaviour was retained, but I don't think I considered the case where the script was not invoked using the #! and that therefore the -q was not actually effective. > I'll look more at the intermittent failures, but there may be more than one > thing going on there. (lockstat-summary looks different) Thanks. > > correct path to the dtrace executable being tested can be inserted. > > Corrected the tests, and ensured they are executable. > > > > Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com> > > --- > > test/demo/script/interp.d | 2 +- > > test/demo/script/tracewrite.d | 4 ++-- > > test/demo/spec/specopen.d | 6 +++--- > > test/stress/fbtsafety/tst.vahole.d | 2 +- > > test/unittest/lockstat/tst.lockstat-summary.d | 0 > > test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d | 2 +- > > test/unittest/scripting/err.D_OP_LVAL.rdonly.d | 2 +- > > test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d | 2 +- > > test/unittest/scripting/err.D_SYNTAX.concat.d | 2 +- > > test/unittest/scripting/err.D_SYNTAX.desc.d | 2 +- > > test/unittest/scripting/err.D_SYNTAX.inval.d | 2 +- > > test/unittest/scripting/err.D_SYNTAX.pid.d | 2 +- > > test/unittest/scripting/tst.arg0.d | 2 +- > > test/unittest/scripting/tst.assign.d | 2 +- > > test/unittest/scripting/tst.basic.d | 2 +- > > test/unittest/scripting/tst.pgid.d | 2 +- > > test/unittest/scripting/tst.pid.d | 2 +- > > test/unittest/scripting/tst.quiet.d | 0 > > test/unittest/scripting/tst.sid.d | 2 +- > > test/unittest/scripting/tst.trace.d | 2 +- > > .../speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d | 5 ++--- > > .../speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r | 2 +- > > .../speculation/err.D_ACT_SPEC.SpeculateWithChill.d | 5 ++--- > > .../speculation/err.D_ACT_SPEC.SpeculateWithChill.r | 2 +- > > .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d | 5 ++--- > > .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r | 2 +- > > .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d | 5 ++--- > > .../speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r | 2 +- > > .../speculation/err.D_ACT_SPEC.SpeculateWithPanic.d | 5 ++--- > > .../speculation/err.D_ACT_SPEC.SpeculateWithPanic.r | 2 +- > > .../speculation/err.D_ACT_SPEC.SpeculateWithRaise.d | 5 ++--- > > .../speculation/err.D_ACT_SPEC.SpeculateWithRaise.r | 2 +- > > .../unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d | 5 ++--- > > .../unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r | 2 +- > > 34 files changed, 42 insertions(+), 49 deletions(-) > > mode change 100644 => 100755 test/demo/script/interp.d > > mode change 100644 => 100755 test/demo/script/tracewrite.d > > mode change 100644 => 100755 test/stress/fbtsafety/tst.vahole.d > > mode change 100755 => 100644 test/unittest/lockstat/tst.lockstat-summary.d > > mode change 100644 => 100755 test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d > > mode change 100644 => 100755 test/unittest/scripting/err.D_OP_LVAL.rdonly.d > > mode change 100644 => 100755 test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d > > mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.concat.d > > mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.desc.d > > mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.inval.d > > mode change 100644 => 100755 test/unittest/scripting/err.D_SYNTAX.pid.d > > mode change 100644 => 100755 test/unittest/scripting/tst.arg0.d > > mode change 100644 => 100755 test/unittest/scripting/tst.assign.d > > mode change 100644 => 100755 test/unittest/scripting/tst.basic.d > > mode change 100644 => 100755 test/unittest/scripting/tst.pgid.d > > mode change 100644 => 100755 test/unittest/scripting/tst.pid.d > > mode change 100644 => 100755 test/unittest/scripting/tst.quiet.d > > mode change 100644 => 100755 test/unittest/scripting/tst.sid.d > > mode change 100644 => 100755 test/unittest/scripting/tst.trace.d > > > > diff --git a/test/demo/script/interp.d b/test/demo/script/interp.d > > old mode 100644 > > new mode 100755 > > index be690b56..f4718a41 > > --- a/test/demo/script/interp.d > > +++ b/test/demo/script/interp.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -s > > +#!dtrace -s > > /* > > * Oracle Linux DTrace. > > diff --git a/test/demo/script/tracewrite.d b/test/demo/script/tracewrite.d > > old mode 100644 > > new mode 100755 > > index 0c139ead..482f272b > > --- a/test/demo/script/tracewrite.d > > +++ b/test/demo/script/tracewrite.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -s > > +#!dtrace -s > > /* > > * Oracle Linux DTrace. > > @@ -7,7 +7,7 @@ > > * http://oss.oracle.com/licenses/upl. > > */ > > -/* @@trigger: readwholedir */ > > +/* @@runtest-opts: -c test/triggers/readwholedir */ > > syscall::write:entry > > /pid == $target/ > > diff --git a/test/demo/spec/specopen.d b/test/demo/spec/specopen.d > > index e7dbc3b2..6d3d79af 100644 > > --- a/test/demo/spec/specopen.d > > +++ b/test/demo/spec/specopen.d > > @@ -1,12 +1,12 @@ > > -#!/usr/sbin/dtrace -Fs > > - > > /* > > * Oracle Linux DTrace. > > - * Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved. > > + * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved. > > * Licensed under the Universal Permissive License v 1.0 as shown at > > * http://oss.oracle.com/licenses/upl. > > */ > > +#pragma D option flowindent > > + > > syscall::openat:entry > > { > > /* > > diff --git a/test/stress/fbtsafety/tst.vahole.d b/test/stress/fbtsafety/tst.vahole.d > > old mode 100644 > > new mode 100755 > > index b918e663..d7d6cc88 > > --- a/test/stress/fbtsafety/tst.vahole.d > > +++ b/test/stress/fbtsafety/tst.vahole.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -Cs > > +#!dtrace -Cs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/lockstat/tst.lockstat-summary.d b/test/unittest/lockstat/tst.lockstat-summary.d > > old mode 100755 > > new mode 100644 > > diff --git a/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d b/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d > > old mode 100644 > > new mode 100755 > > index 45c37efe..b54ba982 > > --- a/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d > > +++ b/test/unittest/scripting/err.D_MACRO_UNDEF.invalidargs.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/err.D_OP_LVAL.rdonly.d b/test/unittest/scripting/err.D_OP_LVAL.rdonly.d > > old mode 100644 > > new mode 100755 > > index b51e1160..93ddbd2a > > --- a/test/unittest/scripting/err.D_OP_LVAL.rdonly.d > > +++ b/test/unittest/scripting/err.D_OP_LVAL.rdonly.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d b/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d > > old mode 100644 > > new mode 100755 > > index a4880cca..fe6fe34a > > --- a/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d > > +++ b/test/unittest/scripting/err.D_OP_WRITE.usepidmacro.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/err.D_SYNTAX.concat.d b/test/unittest/scripting/err.D_SYNTAX.concat.d > > old mode 100644 > > new mode 100755 > > index 8f7b210f..23caa113 > > --- a/test/unittest/scripting/err.D_SYNTAX.concat.d > > +++ b/test/unittest/scripting/err.D_SYNTAX.concat.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/err.D_SYNTAX.desc.d b/test/unittest/scripting/err.D_SYNTAX.desc.d > > old mode 100644 > > new mode 100755 > > index 34ae864c..baeb2901 > > --- a/test/unittest/scripting/err.D_SYNTAX.desc.d > > +++ b/test/unittest/scripting/err.D_SYNTAX.desc.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/err.D_SYNTAX.inval.d b/test/unittest/scripting/err.D_SYNTAX.inval.d > > old mode 100644 > > new mode 100755 > > index d3338cfd..bec28942 > > --- a/test/unittest/scripting/err.D_SYNTAX.inval.d > > +++ b/test/unittest/scripting/err.D_SYNTAX.inval.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/err.D_SYNTAX.pid.d b/test/unittest/scripting/err.D_SYNTAX.pid.d > > old mode 100644 > > new mode 100755 > > index 01044d6e..72d9dfc0 > > --- a/test/unittest/scripting/err.D_SYNTAX.pid.d > > +++ b/test/unittest/scripting/err.D_SYNTAX.pid.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/tst.arg0.d b/test/unittest/scripting/tst.arg0.d > > old mode 100644 > > new mode 100755 > > index 905fefb6..af7e8ded > > --- a/test/unittest/scripting/tst.arg0.d > > +++ b/test/unittest/scripting/tst.arg0.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -s > > +#!dtrace -s > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/tst.assign.d b/test/unittest/scripting/tst.assign.d > > old mode 100644 > > new mode 100755 > > index 9bbd8e49..527f3242 > > --- a/test/unittest/scripting/tst.assign.d > > +++ b/test/unittest/scripting/tst.assign.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/tst.basic.d b/test/unittest/scripting/tst.basic.d > > old mode 100644 > > new mode 100755 > > index cd7b716a..57b75639 > > --- a/test/unittest/scripting/tst.basic.d > > +++ b/test/unittest/scripting/tst.basic.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -s > > +#!dtrace -s > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/tst.pgid.d b/test/unittest/scripting/tst.pgid.d > > old mode 100644 > > new mode 100755 > > index 8d82f2bd..99ec11bf > > --- a/test/unittest/scripting/tst.pgid.d > > +++ b/test/unittest/scripting/tst.pgid.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/tst.pid.d b/test/unittest/scripting/tst.pid.d > > old mode 100644 > > new mode 100755 > > index 2d0499d7..dc3e3182 > > --- a/test/unittest/scripting/tst.pid.d > > +++ b/test/unittest/scripting/tst.pid.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -qs > > +#!dtrace -qs > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/tst.quiet.d b/test/unittest/scripting/tst.quiet.d > > old mode 100644 > > new mode 100755 > > diff --git a/test/unittest/scripting/tst.sid.d b/test/unittest/scripting/tst.sid.d > > old mode 100644 > > new mode 100755 > > index e4f1395c..48f45f57 > > --- a/test/unittest/scripting/tst.sid.d > > +++ b/test/unittest/scripting/tst.sid.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -s > > +#!dtrace -s > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/scripting/tst.trace.d b/test/unittest/scripting/tst.trace.d > > old mode 100644 > > new mode 100755 > > index 148e5c60..bcc4b445 > > --- a/test/unittest/scripting/tst.trace.d > > +++ b/test/unittest/scripting/tst.trace.d > > @@ -1,4 +1,4 @@ > > -#!/usr/sbin/dtrace -s > > +#!dtrace -s > > /* > > * Oracle Linux DTrace. > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d > > index 50bbf177..97c0cb6d 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d > > @@ -1,7 +1,6 @@ > > -#!/usr/sbin/dtrace -ws > > /* > > * Oracle Linux DTrace. > > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > > * Licensed under the Universal Permissive License v 1.0 as shown at > > * http://oss.oracle.com/licenses/upl. > > */ > > @@ -10,8 +9,8 @@ > > * ASSERTION: Destructive actions may never be speculative. > > * > > * SECTION: Speculative Tracing/Using a Speculation > > - * SECTION: dtrace(1M) Utility/ -w option > > */ > > +#pragma D option destructive > > #pragma D option quiet > > BEGIN > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r > > index 1590807c..206641c0 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.r > > @@ -1,2 +1,2 @@ > > -- @@stderr -- > > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithBreakPoint.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d > > index 47e248d2..38a92e60 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d > > @@ -1,7 +1,6 @@ > > -#!/usr/sbin/dtrace -ws > > /* > > * Oracle Linux DTrace. > > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > > * Licensed under the Universal Permissive License v 1.0 as shown at > > * http://oss.oracle.com/licenses/upl. > > */ > > @@ -10,8 +9,8 @@ > > * ASSERTION: Destructive actions may never be speculative. > > * > > * SECTION: Speculative Tracing/Using a Speculation > > - * SECTION: dtrace (1M) Utility/ -w option > > */ > > +#pragma D option destructive > > #pragma D option quiet > > BEGIN > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r > > index d01ab558..ab7c6ed9 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.r > > @@ -1,2 +1,2 @@ > > -- @@stderr -- > > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithChill.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d > > index 14cc1d5c..da6e17db 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d > > @@ -1,7 +1,6 @@ > > -#!/usr/sbin/dtrace -ws > > /* > > * Oracle Linux DTrace. > > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > > * Licensed under the Universal Permissive License v 1.0 as shown at > > * http://oss.oracle.com/licenses/upl. > > */ > > @@ -10,8 +9,8 @@ > > * ASSERTION: Destructive actions may never be speculative. > > * > > * SECTION: Speculative Tracing/Using a Speculation > > - * SECTION: dtrace(1M) Utility/ -w option > > */ > > +#pragma D option destructive > > #pragma D option quiet > > char a[2]; > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r > > index 89592786..f57aba47 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.r > > @@ -1,2 +1,2 @@ > > -- @@stderr -- > > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d: [D_ACT_SPEC] line 34: destructive actions may not follow speculate( ) > > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d: [D_ACT_SPEC] line 33: destructive actions may not follow speculate( ) > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d > > index 43a41440..704b3b27 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d > > @@ -1,7 +1,6 @@ > > -#!/usr/sbin/dtrace -ws > > /* > > * Oracle Linux DTrace. > > - * Copyright (c) 2006, 2023, Oracle and/or its affiliates. All rights reserved. > > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > > * Licensed under the Universal Permissive License v 1.0 as shown at > > * http://oss.oracle.com/licenses/upl. > > */ > > @@ -10,8 +9,8 @@ > > * ASSERTION: Destructive actions may never be speculative. > > * > > * SECTION: Speculative Tracing/Using a Speculation > > - * SECTION: dtrace(1M) Utility/ -w option > > */ > > +#pragma D option destructive > > #pragma D option quiet > > string str; > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r > > index 3bc21b18..da4038aa 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.r > > @@ -1,2 +1,2 @@ > > -- @@stderr -- > > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d: [D_ACT_SPEC] line 34: destructive actions may not follow speculate( ) > > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d: [D_ACT_SPEC] line 33: destructive actions may not follow speculate( ) > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d > > index 80a3204d..d0ccfead 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d > > @@ -1,7 +1,6 @@ > > -#!/usr/sbin/dtrace -ws > > /* > > * Oracle Linux DTrace. > > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > > * Licensed under the Universal Permissive License v 1.0 as shown at > > * http://oss.oracle.com/licenses/upl. > > */ > > @@ -10,8 +9,8 @@ > > * ASSERTION: Destructive actions may never be speculative. > > * > > * SECTION: Speculative Tracing/Using a Speculation > > - * SECTION: dtrace(1M) Utility/ -w option > > */ > > +#pragma D option destructive > > #pragma D option quiet > > BEGIN > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r > > index 3c120a03..7c15314d 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.r > > @@ -1,2 +1,2 @@ > > -- @@stderr -- > > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithPanic.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d > > index a8c1c4d4..7e98885b 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d > > @@ -1,7 +1,6 @@ > > -#!/usr/sbin/dtrace -ws > > /* > > * Oracle Linux DTrace. > > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > > * Licensed under the Universal Permissive License v 1.0 as shown at > > * http://oss.oracle.com/licenses/upl. > > */ > > @@ -10,8 +9,8 @@ > > * ASSERTION: Destructive actions may never be speculative. > > * > > * SECTION: Speculative Tracing/Using a Speculation > > - * SECTION: dtrace(1M) Utility/ -w option > > */ > > +#pragma D option destructive > > #pragma D option quiet > > BEGIN > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r > > index 136f5cde..6e85370a 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.r > > @@ -1,2 +1,2 @@ > > -- @@stderr -- > > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithRaise.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d > > index a0bca73d..2518cd04 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d > > @@ -1,7 +1,6 @@ > > -#!/usr/sbin/dtrace -ws > > /* > > * Oracle Linux DTrace. > > - * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. > > + * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. > > * Licensed under the Universal Permissive License v 1.0 as shown at > > * http://oss.oracle.com/licenses/upl. > > */ > > @@ -10,8 +9,8 @@ > > * ASSERTION: Destructive actions may never be speculative. > > * > > * SECTION: Speculative Tracing/Using a Speculation > > - * SECTION: dtrace(1M) Utility/ -w option > > */ > > +#pragma D option destructive > > #pragma D option quiet > > BEGIN > > diff --git a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r > > index 8cdc6ba1..98725509 100644 > > --- a/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r > > +++ b/test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.r > > @@ -1,2 +1,2 @@ > > -- @@stderr -- > > -dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d: [D_ACT_SPEC] line 28: destructive actions may not follow speculate( ) > > +dtrace: failed to compile script test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithStop.d: [D_ACT_SPEC] line 27: destructive actions may not follow speculate( ) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DTrace-devel] [PATCH v2 2/4] test: correct file permissions 2026-01-06 5:54 ` Kris Van Hees @ 2026-01-07 1:20 ` Eugene Loh 2026-01-07 2:22 ` Kris Van Hees 0 siblings, 1 reply; 7+ messages in thread From: Eugene Loh @ 2026-01-07 1:20 UTC (permalink / raw) To: Kris Van Hees; +Cc: dtrace, dtrace-devel On 1/6/26 00:54, Kris Van Hees wrote: > On Mon, Jan 05, 2026 at 11:50:53PM -0500, Eugene Loh wrote: >> The patch otherwise reads right to me. The tests, however, are not happy. >> The following tests fail intermittently: >> >> test/demo/script/interp.d >> test/demo/script/tracewrite.d >> test/unittest/lockstat/tst.lockstat-summary.d >> test/unittest/scripting/tst.arg0.d >> test/unittest/scripting/tst.basic.d >> test/unittest/scripting/tst.trace.d >> >> These tests fail consistently: >> test/unittest/scripting/tst.assign.d >> test/unittest/scripting/tst.pgid.d >> test/unittest/scripting/tst.pid.d >> The problem for these tests is >> -#!/usr/sbin/dtrace -qs >> +#!dtrace -qs >> Since these files used to be invoked as scripts, the -q was ignored. The .r >> files relied on that. So the interpreter files should drop the -q. That >> does not fix them entirely; it simply makes their failures intermittent. > Yes, I caught (I think) all of the opposite cases where I added a pragma to > ensure that the -q behaviour was retained, but I don't think I considered the > case where the script was not invoked using the #! and that therefore the -q > was not actually effective. > >> I'll look more at the intermittent failures, but there may be more than one >> thing going on there. (lockstat-summary looks different) > Thanks. The intermittent failures were weird, but that lockstat-summary.d should also fail is just plain insane. The problem actually appears to be with a different patch. So, I'm withdrawing the "intermittent failure" complaint about this patch, which should be ready for a final version. Elsewhere, I'll report on what's really going on. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DTrace-devel] [PATCH v2 2/4] test: correct file permissions 2026-01-07 1:20 ` Eugene Loh @ 2026-01-07 2:22 ` Kris Van Hees 2026-01-07 2:45 ` Eugene Loh 0 siblings, 1 reply; 7+ messages in thread From: Kris Van Hees @ 2026-01-07 2:22 UTC (permalink / raw) To: Eugene Loh; +Cc: Kris Van Hees, dtrace, dtrace-devel On Tue, Jan 06, 2026 at 08:20:10PM -0500, Eugene Loh wrote: > On 1/6/26 00:54, Kris Van Hees wrote: > > > On Mon, Jan 05, 2026 at 11:50:53PM -0500, Eugene Loh wrote: > > > The patch otherwise reads right to me. The tests, however, are not happy. > > > The following tests fail intermittently: > > > > > > test/demo/script/interp.d > > > test/demo/script/tracewrite.d > > > test/unittest/lockstat/tst.lockstat-summary.d > > > test/unittest/scripting/tst.arg0.d > > > test/unittest/scripting/tst.basic.d > > > test/unittest/scripting/tst.trace.d > > > > > > These tests fail consistently: > > > test/unittest/scripting/tst.assign.d > > > test/unittest/scripting/tst.pgid.d > > > test/unittest/scripting/tst.pid.d > > > The problem for these tests is > > > -#!/usr/sbin/dtrace -qs > > > +#!dtrace -qs > > > Since these files used to be invoked as scripts, the -q was ignored. The .r > > > files relied on that. So the interpreter files should drop the -q. That > > > does not fix them entirely; it simply makes their failures intermittent. > > Yes, I caught (I think) all of the opposite cases where I added a pragma to > > ensure that the -q behaviour was retained, but I don't think I considered the > > case where the script was not invoked using the #! and that therefore the -q > > was not actually effective. > > > > > I'll look more at the intermittent failures, but there may be more than one > > > thing going on there. (lockstat-summary looks different) > > Thanks. > > The intermittent failures were weird, but that lockstat-summary.d should > also fail is just plain insane. The problem actually appears to be with a > different patch. So, I'm withdrawing the "intermittent failure" complaint > about this patch, which should be ready for a final version. Elsewhere, > I'll report on what's really going on. Yes, I believe it is due to: [3/4] bpf: allocate the buffers BPF map to fit highest CPU id I must have introduced a bug in that patch. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DTrace-devel] [PATCH v2 2/4] test: correct file permissions 2026-01-07 2:22 ` Kris Van Hees @ 2026-01-07 2:45 ` Eugene Loh 2026-01-07 2:51 ` Kris Van Hees 0 siblings, 1 reply; 7+ messages in thread From: Eugene Loh @ 2026-01-07 2:45 UTC (permalink / raw) To: Kris Van Hees; +Cc: dtrace, dtrace-devel On 1/6/26 21:22, Kris Van Hees wrote: > On Tue, Jan 06, 2026 at 08:20:10PM -0500, Eugene Loh wrote: >> On 1/6/26 00:54, Kris Van Hees wrote: >> >>> On Mon, Jan 05, 2026 at 11:50:53PM -0500, Eugene Loh wrote: >>>> The patch otherwise reads right to me. The tests, however, are not happy. >>>> The following tests fail intermittently: >>>> >>>> test/demo/script/interp.d >>>> test/demo/script/tracewrite.d >>>> test/unittest/lockstat/tst.lockstat-summary.d >>>> test/unittest/scripting/tst.arg0.d >>>> test/unittest/scripting/tst.basic.d >>>> test/unittest/scripting/tst.trace.d >>>> >>>> These tests fail consistently: >>>> test/unittest/scripting/tst.assign.d >>>> test/unittest/scripting/tst.pgid.d >>>> test/unittest/scripting/tst.pid.d >>>> The problem for these tests is >>>> -#!/usr/sbin/dtrace -qs >>>> +#!dtrace -qs >>>> Since these files used to be invoked as scripts, the -q was ignored. The .r >>>> files relied on that. So the interpreter files should drop the -q. That >>>> does not fix them entirely; it simply makes their failures intermittent. >>> Yes, I caught (I think) all of the opposite cases where I added a pragma to >>> ensure that the -q behaviour was retained, but I don't think I considered the >>> case where the script was not invoked using the #! and that therefore the -q >>> was not actually effective. >>> >>>> I'll look more at the intermittent failures, but there may be more than one >>>> thing going on there. (lockstat-summary looks different) >>> Thanks. >> The intermittent failures were weird, but that lockstat-summary.d should >> also fail is just plain insane. The problem actually appears to be with a >> different patch. So, I'm withdrawing the "intermittent failure" complaint >> about this patch, which should be ready for a final version. Elsewhere, >> I'll report on what's really going on. > Yes, I believe it is due to: > [3/4] bpf: allocate the buffers BPF map to fit highest CPU id > > I must have introduced a bug in that patch. Right. And I reviewed it. We replace num_online_cpus with max_cpuid. That should be max_cpuid+1. Is it too late to rework that patch? If so, I can supply a patch to amend it. (Anyhow, events on the highest cpuid are missed.) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DTrace-devel] [PATCH v2 2/4] test: correct file permissions 2026-01-07 2:45 ` Eugene Loh @ 2026-01-07 2:51 ` Kris Van Hees 0 siblings, 0 replies; 7+ messages in thread From: Kris Van Hees @ 2026-01-07 2:51 UTC (permalink / raw) To: Eugene Loh; +Cc: Kris Van Hees, dtrace, dtrace-devel On Tue, Jan 06, 2026 at 09:45:36PM -0500, Eugene Loh wrote: > > On 1/6/26 21:22, Kris Van Hees wrote: > > On Tue, Jan 06, 2026 at 08:20:10PM -0500, Eugene Loh wrote: > > > On 1/6/26 00:54, Kris Van Hees wrote: > > > > > > > On Mon, Jan 05, 2026 at 11:50:53PM -0500, Eugene Loh wrote: > > > > > The patch otherwise reads right to me. The tests, however, are not happy. > > > > > The following tests fail intermittently: > > > > > > > > > > test/demo/script/interp.d > > > > > test/demo/script/tracewrite.d > > > > > test/unittest/lockstat/tst.lockstat-summary.d > > > > > test/unittest/scripting/tst.arg0.d > > > > > test/unittest/scripting/tst.basic.d > > > > > test/unittest/scripting/tst.trace.d > > > > > > > > > > These tests fail consistently: > > > > > test/unittest/scripting/tst.assign.d > > > > > test/unittest/scripting/tst.pgid.d > > > > > test/unittest/scripting/tst.pid.d > > > > > The problem for these tests is > > > > > -#!/usr/sbin/dtrace -qs > > > > > +#!dtrace -qs > > > > > Since these files used to be invoked as scripts, the -q was ignored. The .r > > > > > files relied on that. So the interpreter files should drop the -q. That > > > > > does not fix them entirely; it simply makes their failures intermittent. > > > > Yes, I caught (I think) all of the opposite cases where I added a pragma to > > > > ensure that the -q behaviour was retained, but I don't think I considered the > > > > case where the script was not invoked using the #! and that therefore the -q > > > > was not actually effective. > > > > > > > > > I'll look more at the intermittent failures, but there may be more than one > > > > > thing going on there. (lockstat-summary looks different) > > > > Thanks. > > > The intermittent failures were weird, but that lockstat-summary.d should > > > also fail is just plain insane. The problem actually appears to be with a > > > different patch. So, I'm withdrawing the "intermittent failure" complaint > > > about this patch, which should be ready for a final version. Elsewhere, > > > I'll report on what's really going on. > > Yes, I believe it is due to: > > [3/4] bpf: allocate the buffers BPF map to fit highest CPU id > > > > I must have introduced a bug in that patch. > > Right. And I reviewed it. We replace num_online_cpus with max_cpuid. That > should be max_cpuid+1. Is it too late to rework that patch? If so, I can > supply a patch to amend it. (Anyhow, events on the highest cpuid are > missed.) It is not too late - it has not been merged yet. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-01-07 2:51 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-12-19 0:51 [PATCH v2 2/4] test: correct file permissions Kris Van Hees 2026-01-06 4:50 ` [DTrace-devel] " Eugene Loh 2026-01-06 5:54 ` Kris Van Hees 2026-01-07 1:20 ` Eugene Loh 2026-01-07 2:22 ` Kris Van Hees 2026-01-07 2:45 ` Eugene Loh 2026-01-07 2:51 ` Kris Van Hees
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox