From: Nick Alcock <nick.alcock@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] test: Make the USDT "only enabled" test more stringent
Date: Fri, 13 Jun 2025 15:19:02 +0100 [thread overview]
Message-ID: <871prnenc9.fsf@esperi.org.uk> (raw)
In-Reply-To: <20250603203532.20743-1-eugene.loh@oracle.com> (eugene loh's message of "Tue, 3 Jun 2025 16:35:32 -0400")
On 3 Jun 2025, eugene loh said:
> From: Eugene Loh <eugene.loh@oracle.com>
>
> What if a program has an is-enabled probe without the corresponding
> parent probe? It should at least compile, and we test that.
>
> Add more checks to the test:
> - the is-enabled branch is not taken when run without dtrace
> - the parent USDT probe is listed with "dtrace -l"
> - the is-enabled branch is not taken even when run with dtrace
> if the parent probe is not enabled
> - the is-enabled branch is taken when run with dtrace
> and the parent probe is enabled; however, the parent probe
> does not fire since it is not in the test trigger
Nice!
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
prev parent reply other threads:[~2025-06-13 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 20:35 [PATCH] test: Make the USDT "only enabled" test more stringent eugene.loh
2025-06-13 14:19 ` Nick Alcock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871prnenc9.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox