Linux DTrace development list
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: Elena Zannoni <elena.zannoni@oracle.com>
Cc: dtrace-devel@oss.oracle.com, dtrace@lists.linux.dev
Subject: Re: [PATCH] Add examples directory to installed doc directory
Date: Thu, 18 Sep 2025 20:14:13 +0100	[thread overview]
Message-ID: <87348jlgje.fsf@esperi.org.uk> (raw)
In-Reply-To: <20250918185554.1754957-1-elena.zannoni@oracle.com> (Elena Zannoni's message of "Thu, 18 Sep 2025 12:54:53 -0600")

On 18 Sep 2025, Elena Zannoni uttered the following:

> Make sure that the examples directory gets installed. 
> It will be installed under /usr/share/doc/dtrace/examples.
>
>
> Signed-off-by: Elena Zannoni <elena.zannoni@oracle.com>

Reviewed-by: Nick Alcock <nick.alcock@oracle.com>

(Though this seems to be built on top of your previous commit -- I guess
they'll get squashed together or something?)

> diff --git a/Build b/Build
> index 1a66a824..220c9784 100644
> --- a/Build
> +++ b/Build
> @@ -7,12 +7,18 @@ install::
>  	mkdir -p $(INSTDOCDIR)/userguide/explanation
>  	mkdir -p $(INSTDOCDIR)/userguide/how-to
>  	mkdir -p $(INSTDOCDIR)/userguide/reference
> -	$(call describe-install-target,$(INSTDOCDIR),README INCOMPATIBILITIES NEWS doc/userguide)
> +	mkdir -p $(INSTDOCDIR)/examples/
> +	mkdir -p $(INSTDOCDIR)/examples/language_features

That first mkdir -p line is technically unnecessary (but harmless).

> +	$(call describe-install-target,$(INSTDOCDIR),README INCOMPATIBILITIES NEWS userguide examples)
>  	install -m 644 README INCOMPATIBILITIES NEWS $(INSTDOCDIR)
>  	install -m 644 doc/userguide/index.md $(INSTDOCDIR)/userguide
>  	install -m 644 doc/userguide/explanation/* $(INSTDOCDIR)/userguide/explanation
>  	install -m 644 doc/userguide/how-to/* $(INSTDOCDIR)/userguide/how-to
>  	install -m 644 doc/userguide/reference/* $(INSTDOCDIR)/userguide/reference
> +	install -m 755 examples/*.d $(INSTDOCDIR)/examples
> +	install -m 644 examples/README.md $(INSTDOCDIR)/examples
> +	install -m 755 examples/language_features/* $(INSTDOCDIR)/examples/language_features

... you want the files to be executable? I suppose they're .d scripts
starting with a hashbang, so that makes sense.

-- 
NULL && (void)

  reply	other threads:[~2025-09-18 19:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 18:54 [PATCH] Add examples directory to installed doc directory Elena Zannoni
2025-09-18 19:14 ` Nick Alcock [this message]
2025-09-18 19:21   ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87348jlgje.fsf@esperi.org.uk \
    --to=nick.alcock@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=elena.zannoni@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox