Re: [PATCH 01/14] No longer depend on libsystemd

[Nick Alcock <nick.alcock@oracle.com>]

On 25 Oct 2024, Kris Van Hees stated:
> On Thu, Oct 24, 2024 at 12:37:45PM +0100, Nick Alcock wrote:
>> --- a/GNUmakefile
>> +++ b/GNUmakefile
>> @@ -102,6 +102,7 @@ PKGCONFIGDIR = $(prefix)/share/pkgconfig
>>  INSTPKGCONFIGDIR = $(DESTDIR)$(PKGCONFIGDIR)
>>  TESTDIR = $(LIBDIR)/dtrace/testsuite
>>  INSTTESTDIR = $(DESTDIR)$(TESTDIR)
>> +WITH_SYSTEMD = true
>
> Why not: WITH_SYSTEMD = y
>
> (since everything else seems to use = y)

Fixed (though there is nothing else in GNUmakefile that uses = y, or in
any Build script, so I'm not sure what you're referring to...)

... oh, you mean in the output of Makeconfig. Makes sense, agreed.

>>  TARGETS =
>>  
>>  DTRACE ?= $(objdir)/dtrace
>> diff --git a/Makeconfig b/Makeconfig
>> index f3d47c086f4a..346078598624 100644
>> --- a/Makeconfig
>> +++ b/Makeconfig
>> @@ -218,7 +218,6 @@ $(eval $(call check-symbol-rule,ELF_GETSHDRSTRNDX,elf_getshdrstrndx,elf))
>>  $(eval $(call check-symbol-rule,LIBCTF,ctf_open,ctf,t))
>>  $(eval $(call check-symbol-rule,STRRSTR,strrstr,c))
>>  $(eval $(call check-symbol-rule,PTHREAD_ATFORK,pthread_atfork,c))
>> -$(eval $(call check-symbol-rule,LIBSYSTEMD,sd_notify,systemd,t))
>>  ifndef WANTS_LIBFUSE2
>>  $(eval $(call check-symbol-rule,FUSE_LOG,fuse_set_log_func,fuse3))
>>  $(eval $(call check-symbol-rule,LIBFUSE3,fuse_session_receive_buf,fuse3,t))
>> diff --git a/configure b/configure
>> index 4026a3eafcd3..42e496b97a7d 100755
>> --- a/configure
>> +++ b/configure
>> @@ -93,9 +93,13 @@ built locally, none of these should be needed):
>>  
>>  EOF
>>  	make help-overrides-header help-overrides-option
>> +	cat >&2 <<'EOF'
>> +--with-systemd=[yes/no]		Disable installation of the systemd unit files
>
> This makes no sense to me.  How would '--with-systemd' mean that installation
> of the systemd unit files is to be disabled?  Surely that is not the correct
> description?  Maybe something like: "Enable or disable ..." or
> "Specify whether ..."?

... that's a really stupid description, isn't it! I kept on rephrasing
until I got something that was in <80 and ended up with gibberish.

Simply 'Install the systemd unit files (default: yes)' 45 chars, just
barely fits in 80.

>> +        --with-systemd|--with-systemd=yes) write_make_var WITH_SYSTEMD "true";;
>
> "true" -> "y"

Ack.

I've also arranged that --with-systemd=y* turns it on, and n* turns it
off, entirely so yes and y turn it on, and n and no turn it off :)

-- 
NULL && (void)