public inbox for dtrace@lists.linux.dev
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
	 dtrace-devel@oss.oracle.com, dtrace@lists.linux.dev
Subject: Re: [DTrace-devel] [PATCH v4] Add packaging configuration for Debian
Date: Sat, 14 Feb 2026 13:34:31 +0000	[thread overview]
Message-ID: <874injxxco.fsf@gentoo.org> (raw)
In-Reply-To: <87tsvkn0ai.fsf@esperi.org.uk>

[-- Attachment #1: Type: text/plain, Size: 2528 bytes --]

Nick Alcock via DTrace-devel <dtrace-devel@oss.oracle.com> writes:

> On 10 Feb 2026, Kris Van Hees via DTrace-devel outgrape:
>
>> Packaging configuration files for Debian are provided in dists/debian.
>
> Nice! Seems to work, even on Debian stable (I was sure I'd need at least
> testing, but no!).
>
> [...]
>> diff --git a/dists/debian/patches/debian-configure.patch b/dists/debian/patches/debian-configure.patch
>> new file mode 100644
>> index 00000000..d4a89bb9
>> --- /dev/null
>> +++ b/dists/debian/patches/debian-configure.patch
>> @@ -0,0 +1,17 @@
>> +Description: issue a warning for unknown configure options
>> + The Debian build system specifies configure options that are not known to
>> + the DTrace configure script.  They should not cause the configure script
>> + to abort.
>> +--- dtrace-2.0.4.orig/configure
>> ++++ dtrace-2.0.4/configure
>> +@@ -172,8 +172,7 @@ for option in "$@"; do
>> +         HAVE_VALGRIND=*) write_config_var VALGRIND "$option";;
>> +         HAVE_BPFV3=*) write_config_var BPFV3 "$option";;
>> +         HAVE_BPFMASM=*) write_config_var BPFMASM "$option";;
>> +-        *) echo "Unknown option $option" >&2
>> +-           exit 1;;
>> ++        *) echo "Unknown option $option" >&2;;
>> +     esac
>> + done
>
> I assumed you could just stuff an || true in there, but this is being
> invoked by dh_auto_configure, so that option isn't available (plus, of
> course, if there's an actual error other than unknown args, we don't
> want to fail).
>
> Maybe we should just not exit with exitcode 1 on unknown configure
> options, only IIRC Gentoo actually wants us to. This may be the best we
> can do.

I really doubt this is the first / only package for Debian where there's
a non-autoconf configure script.

The real issue here is letting whatever Debian machinery that calls
configure think it is autoconf. ebuilds do the same, by default econf
will pass things assuming it's autoconf.

I'm sure there's a way to override that?

>
>> diff --git a/dists/debian/patches/debian-interpreter-paths.patch b/dists/debian/patches/debian-interpreter-paths.patch
>> new file mode 100644
>> index 00000000..58bea538
>> --- /dev/null
>> +++ b/dists/debian/patches/debian-interpreter-paths.patch
>> @@ -0,0 +1,107 @@
>> +Description: fix interpreter paths in tests
>> + Lintian prefers /bin/bash and /bin/sed over /usr/bin/bash and /usr/bin/sed.
>
> Honestly this one I think we should do upstream. I always thought that
> /bin/bash is universal and /usr/bin/bash less so.
>

Yes.

> [...]

sam

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 418 bytes --]

  reply	other threads:[~2026-02-14 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 20:59 [PATCH v4] Add packaging configuration for Debian Kris Van Hees
2026-02-13 15:14 ` [DTrace-devel] " Nick Alcock
2026-02-14 13:34   ` Sam James [this message]
2026-02-14 16:39     ` Kris Van Hees
2026-02-14 18:39       ` Kris Van Hees
2026-02-14 17:10   ` Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874injxxco.fsf@gentoo.org \
    --to=sam@gentoo.org \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=kris.van.hees@oracle.com \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox