From: Nick Alcock <nick.alcock@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com,
eugene.loh@oracle.com
Subject: Re: [PATCH v2 4/4] probe: make it possible to destroy probes in more cases
Date: Fri, 15 Nov 2024 22:55:07 +0000 [thread overview]
Message-ID: <874j48rttg.fsf@esperi.org.uk> (raw)
In-Reply-To: <87ttc8rz8s.fsf@esperi.org.uk> (Nick Alcock's message of "Fri, 15 Nov 2024 20:57:55 +0000")
On 15 Nov 2024, Nick Alcock outgrape:
> On 15 Nov 2024, Kris Van Hees said:
>
>> This patch is not needed. I do not see any failures related to the changes
>> in this patch and the test case passes even without these code changes as
>> far as I can see.
>
> It didn't when I ran it. Try under valgrind.
... and now it doesn't for me either! I guess 3/4 when done right (as
you suggested, not as I originally did it) obviates the need for 4/4.
Still don't entirely understand *why*, but maybe the probes vanish
before the parser terminates, so they're not left lingering for a late
deletion.
--
NULL && (void)
next prev parent reply other threads:[~2024-11-15 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 22:01 [PATCH v2 1/4] dtprobed: handle multiple providers in a single piece of DOF Nick Alcock
2024-11-14 22:01 ` [PATCH v2 2/4] runtest: detect coredumps in more cases Nick Alcock
2024-11-15 4:47 ` Eugene Loh
2024-11-15 20:56 ` Nick Alcock
2024-11-15 4:51 ` [DTrace-devel] " Kris Van Hees
2024-11-14 22:01 ` [PATCH v2 3/4] probe: do not try to reify probes from uncooked providers Nick Alcock
2024-11-15 4:53 ` Kris Van Hees
2024-11-15 20:57 ` Nick Alcock
2024-11-14 22:01 ` [PATCH v2 4/4] probe: make it possible to destroy probes in more cases Nick Alcock
2024-11-15 4:56 ` Kris Van Hees
2024-11-15 20:57 ` Nick Alcock
2024-11-15 22:55 ` Nick Alcock [this message]
2024-11-15 4:50 ` [PATCH v2 1/4] dtprobed: handle multiple providers in a single piece of DOF Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j48rttg.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=eugene.loh@oracle.com \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox