Re: [DTrace-devel] [PATCH] utils: add args output to showUSDT.c

[Nick Alcock <nick.alcock@oracle.com>]

On 1 Nov 2024, Kris Van Hees via DTrace-devel verbalised:

> The showUSDT utility now reports argument type (native and translated)
> and mapping data for probes.
>
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>

Nice! Dropped my corresponding one.

Reviewed-by: Nick Alcock <nick.alcock@oracle.com>

One caveat:

>      printf("      Probe %d: %s:%s:%s:%s\n",
>  	   id, name, "",
>  	   strtab + probe->dofpr_func, strtab + probe->dofpr_name);
>      printf("        argc %d noffs %d nenoffs %d\n",
> -	   probe->dofpr_nargc, probe->dofpr_noffs, probe->dofpr_nenoffs);
> +	   probe->dofpr_xargc, probe->dofpr_noffs, probe->dofpr_nenoffs);

I think you shuld still print dofpr_nargc here too, because if it's
wrong we don't want the loop beyond to overrun and crash without any
previous indication of why :)

-- 
NULL && (void)