From: Nick Alcock <nix@esperi.org.uk>
To: ealmorshdy@d-matrix.ai
Cc: dtrace@lists.linux.dev, Kris Van Hees <kris.van.hees@oracle.com>
Subject: Re: [PATCH v2 1/2] libproc: fix readlink() typo in Psystem_daemon()
Date: Thu, 19 Nov 2026 12:48:09 +0000 [thread overview]
Message-ID: <87a4n5m1h2.fsf@esperi.org.uk> (raw)
In-Reply-To: <20261119-b4-bug008-daemon-readlink-v2-1-c4bc5fbf156f@d-matrix.ai>
On 19 Nov 2026, Eslam Almorshdy via uttered the following:
> From: Eslam Almorshdy <ealmorshdy@d-matrix.ai>
>
> readlink() returns the number of bytes it stored or -1, never 0, so
> the check for a regular file outside /var never ran.
>
> Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
> Signed-off-by: Eslam Almorshdy <ealmorshdy@d-matrix.ai>
Reviewed-by: Nick Alcock <nix@esperi.org.uk>
(who is to blame. How did I miss this?!)
--
NULL && (void)
next prev parent reply other threads:[~2026-11-19 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 7:11 [PATCH v2 0/2] Fix a readlink() typo in Psystem_daemon() Eslam Almorshdy via B4 Relay
2026-11-19 7:11 ` [PATCH v2 1/2] libproc: fix " Eslam Almorshdy via B4 Relay
2026-11-19 12:48 ` Nick Alcock [this message]
2026-11-19 7:11 ` [PATCH v2 2/2] test: add test for system daemons with regular files as streams Eslam Almorshdy via B4 Relay
2026-11-19 12:51 ` Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4n5m1h2.fsf@esperi.org.uk \
--to=nix@esperi.org.uk \
--cc=dtrace@lists.linux.dev \
--cc=ealmorshdy@d-matrix.ai \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox