From: Nick Alcock <nick.alcock@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 3/6] dtprobed: stop skipping zero-tracepoint probes in dof_stash.c
Date: Thu, 24 Oct 2024 15:12:11 +0100 [thread overview]
Message-ID: <87a5ettwsk.fsf@esperi.org.uk> (raw)
In-Reply-To: <ZxfdBruw9o1XK9Ll@oracle.com> (Kris Van Hees's message of "Tue, 22 Oct 2024 13:12:38 -0400")
On 22 Oct 2024, Kris Van Hees verbalised:
> On Fri, Oct 18, 2024 at 08:58:05PM +0100, Nick Alcock wrote:
>> We already validate that they don't exist in dof_parser.c, so no such probes
>> can ever get here. Handling this impossible, untestable case has just got
>> harder, because we'd have to skip DIT_{NATIVE,XLAT,REMAP}_ARGS records too.
>> Just stop considering it.
>>
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>
> Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
Ack (adjusted comment to match the previous review comments).
--
NULL && (void)
next prev parent reply other threads:[~2024-10-24 14:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 19:58 [PATCH 0/6] usdt typed args, translators and arg remapping Nick Alcock
2024-10-18 19:58 ` [PATCH 1/6] error: add missing EDT_PRINT entry Nick Alcock
2024-10-21 9:10 ` Alan Maguire
2024-10-22 14:40 ` Kris Van Hees
2024-10-18 19:58 ` [PATCH 2/6] usdt: get arg types and xlations into DTrace from the DOF Nick Alcock
2024-10-22 17:03 ` Kris Van Hees
2024-10-18 19:58 ` [PATCH 3/6] dtprobed: stop skipping zero-tracepoint probes in dof_stash.c Nick Alcock
2024-10-22 17:12 ` Kris Van Hees
2024-10-24 14:12 ` Nick Alcock [this message]
2024-10-18 19:58 ` [PATCH 4/6] cg: add argument remapping in the trampoline Nick Alcock
2024-10-22 17:43 ` Kris Van Hees
2024-10-25 15:56 ` Nick Alcock
2024-10-25 19:15 ` Kris Van Hees
2024-10-28 21:11 ` Nick Alcock
2024-10-28 21:20 ` Kris Van Hees
2024-10-29 13:09 ` Nick Alcock
2024-10-29 14:51 ` Kris Van Hees
2024-10-18 19:58 ` [PATCH 5/6] usdt: typed args and arg remapping Nick Alcock
2024-10-22 18:40 ` Kris Van Hees
2024-10-28 12:52 ` Nick Alcock
2024-10-28 16:00 ` Kris Van Hees
2024-10-18 19:58 ` [PATCH 6/6] usdt: fix create_underlying error path Nick Alcock
2024-10-22 18:46 ` Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ettwsk.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox